From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A225C27C5E for ; Fri, 7 Jun 2024 02:27:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VLk2ud1Xawh3pm5ZEtzFPGSp+J+Z8zfaPxGuw/KTj/4=; b=Nk/iFxiuBgQK5X EDaj0einmIt0inazTUEWf43K09f0TKA5zle7ochOQQIImgYYWrpkiz6rDHzny3h3ryV/4gSt0lAFC 764+vLP2fyi0FSDro83HzJUsIJIhkw8WjUIub7HMkfPriO3PzLCVGJpJS32RsjaFoGT+h6iExEmrn aEJB72n920otHKy9iizVFCmFeNJfIaIlm2ikfPtf4c2Kj+o8qszGayEk4ZASBijBotNpD9U0u+LVG NkjXD5YIumIqV//qwelUSD8tG5rbHzVAZ2u0O2cyCTqdoXXgRlvCNOJBvk/QrGai1LQkUkUpcxFet x8uu4aV8+fREQ0VmYUpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFPJk-0000000C4wz-0YQo; Fri, 07 Jun 2024 02:27:00 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFPJg-0000000C4wa-3zPg for linux-arm-kernel@lists.infradead.org; Fri, 07 Jun 2024 02:26:58 +0000 X-UUID: 666e0262247511efba8bfb22b0451c12-20240606 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=BLEU828uCInFLuwTYCQ33Lcs5sdd10hyJlrloS9Xaw4=; b=uIFYUYCkFdwmPziXHOc7czH/inm67R50e4fF2fUNvafml+9YY4gfb0fpfhHVRg1bnQUMGSgUWNjqdp1wlDQBx++vJgZ7mj/tvwKw8qPqTEvSHUp/DJaiCEtCBtFeXH/XiolcO0kSeUVCI7QJgXK7uVX2LXtIAvXUt+Mc8IS3bdo=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.39,REQID:adfebe64-7446-48be-af03-5fa709579bfd,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:393d96e,CLOUDID:de8c5088-8d4f-477b-89d2-1e3bdbef96d1,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1, SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 666e0262247511efba8bfb22b0451c12-20240606 Received: from mtkmbs13n1.mediatek.inc [(172.21.101.193)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 365562526; Thu, 06 Jun 2024 19:26:52 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 7 Jun 2024 10:26:16 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 7 Jun 2024 10:26:16 +0800 From: Phil Chang To: CC: , , , , , , , , Subject: [PATCH v2] hrtimer: check hrtimer with a NULL function Date: Fri, 7 Jun 2024 10:26:14 +0800 Message-ID: <20240607022614.22902-1-phil.chang@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <877cf2i56q.fsf@somnus> References: <877cf2i56q.fsf@somnus> MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240606_192657_104868_EEC30ABE X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since hrtimers do not allow a NULL function to be passed, to prevent a kernel crash, return before adding the timer to a queue. Signed-off-by: Phil Chang --- kernel/time/hrtimer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c index 492c14aac642..d32c1afe59b3 100644 --- a/kernel/time/hrtimer.c +++ b/kernel/time/hrtimer.c @@ -1285,6 +1285,9 @@ void hrtimer_start_range_ns(struct hrtimer *timer, ktime_t tim, struct hrtimer_clock_base *base; unsigned long flags; + if (WARN_ON(!timer->function)) + return; + /* * Check whether the HRTIMER_MODE_SOFT bit and hrtimer.is_soft * match on CONFIG_PREEMPT_RT = n. With PREEMPT_RT check the hard -- 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel