From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A597C27C53 for ; Fri, 7 Jun 2024 11:31:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K/8rOdvvVbaVwhSdjHzSglNiIU1ZhijQJ7vUDLYxioU=; b=tVk7fMV0R68zxj sbmEnMHG4/DYJDGuJFurcbhe9O51xJxr3W85f0ZqDk1KVIuoLtRwWjm4swtMb8HBUhMu3eIB5ssD1 AYS6DxJzM2hUvsnrT/4uiw+FAQU2/AgOg5MobZBIiHLZdQovobszmnHOEcGJsdayY5sFhE58c8qpg pvBpdomcpEB5w54zbArsNHjcgKWurUF1E9Ouf783Zqa1Ynf6rKnajJmfwKfu8TlYeNDPsKHyVqzyP l4oInLrrt2zoTF36DwOVm5LAJzjoA+LgpGv30FKpdxRJPnOcErpmU07VtQqv0PhVWfM9IRNgQk4Oj 4eeluIFtLi4rVU72Fdow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFXoZ-0000000DlOa-0Fsx; Fri, 07 Jun 2024 11:31:23 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFXoV-0000000DlMZ-3paY for linux-arm-kernel@lists.infradead.org; Fri, 07 Jun 2024 11:31:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 71268CE1C93; Fri, 7 Jun 2024 11:31:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DD8CC2BBFC; Fri, 7 Jun 2024 11:31:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717759876; bh=Nkzv4hcPPvps22qWpC47FSwYdykZx12iKlrS0Wd94wA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cQSQfIhVy92SkTaaGnvSgGOmaOrGPEO9ebOslY3tPDyGu2jF1GTJI9arb4XK29his 0BLTfM2LZthM3JHTsdnQHQt0Z4GQiN7MUermB1jSdlNyTlO1ebFCHNF2nXBVU7sbDs N9dCpUgXtuB9ixdap7wO+KFbjkfX+Fe6eWjl+w1HdJ7rrbqG6mvqzpIHR+sxpLYEBy h7g2mVnP6NnWsT3CayAWQbJNEjj4VeA41bOhubBCrmLD+Op1b9G/fVnN4BqtzwWJmv zYcpo16xMyADhz6EMSN1zwreNy5aX1bROtpuyJXMk6eS6rivF7GgpBMYO/OFEV4fJP Bj9egWQZQQb8g== Date: Fri, 7 Jun 2024 12:31:11 +0100 From: Simon Horman To: Sagar Cheluvegowda Cc: Vinod Koul , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Jochen Henneberg , linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Lunn , Andrew Halaney Subject: Re: [PATCH net v2] net: stmmac: dwmac-qcom-ethqos: Configure host DMA width Message-ID: <20240607113111.GA27689@kernel.org> References: <20240605-configure_ethernet_host_dma_width-v2-1-4cc34edfa388@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240605-configure_ethernet_host_dma_width-v2-1-4cc34edfa388@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240607_043120_208879_B6E2EC70 X-CRM114-Status: GOOD ( 18.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 05, 2024 at 11:57:18AM -0700, Sagar Cheluvegowda wrote: > Commit 070246e4674b ("net: stmmac: Fix for mismatched host/device DMA > address width") added support in the stmmac driver for platform drivers > to indicate the host DMA width, but left it up to authors of the > specific platforms to indicate if their width differed from the addr64 > register read from the MAC itself. > > Qualcomm's EMAC4 integration supports only up to 36 bit width (as > opposed to the addr64 register indicating 40 bit width). Let's indicate > that in the platform driver to avoid a scenario where the driver will > allocate descriptors of size that is supported by the CPU which in our > case is 36 bit, but as the addr64 register is still capable of 40 bits > the device will use two descriptors as one address. > > Fixes: 8c4d92e82d50 ("net: stmmac: dwmac-qcom-ethqos: add support for emac4 on sa8775p platforms") > Signed-off-by: Sagar Cheluvegowda > --- > Changes in v2: > Fix commit message to include a commit body > Replace the proper fixes tag > Remove the change-Id > - Link to v1: https://lore.kernel.org/r/20240529-configure_ethernet_host_dma_width-v1-1-3f2707851adf@quicinc.com Thanks, this change looks good to me - the usage of dma_addr_width is in line with my understanding of how it is intended to be used. And, AFAICS, the changes in v2 address the review of v1. Reviewed-by: Simon Horman ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel