From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2569C27C53 for ; Fri, 7 Jun 2024 18:24:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UoyXrs4ouBgKVncSsW0hC/GH+x2IOhfptzUWKREpgAw=; b=kMryZvxs03IPmS gJ8c5idgM0WulBj1TBcbAU+OUypTmOBcU4V69uwa9V5X9NjGLm6R3sL66+XBQNCzYzGKy7p5oZsSY hds7HY1gxAGRict0dDpI/tgWjprt+tBO+OhtIwRsLlM8bL2dM7HA1knfoxTr6wSytEwGla8rBYxEy 5QTY8d9v6cYEevYBASAg7wjN4sxz+Ny2+NPRqH9/ic2WP0GX4xEs4e3vBz140LDCZ8no6X4GiAtMM BigtV/SMVIdxZ3ChNv9e6tr2biGlUcYJ/vMpzFq6fXpDsjLzHgjg5TSxfQonpLoczQl/gpeMacxsz rmh4hfKQtquBD8ut3r6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFeGG-0000000FFD7-0rLU; Fri, 07 Jun 2024 18:24:24 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFeGD-0000000FFCb-3LzI for linux-arm-kernel@lists.infradead.org; Fri, 07 Jun 2024 18:24:23 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F3FA461F9D; Fri, 7 Jun 2024 18:24:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7075C2BBFC; Fri, 7 Jun 2024 18:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717784660; bh=jXS45UQrPnM99RQ0JyTFd4KZqPVi2vCjrSX/9pcHsAg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LM3uyI6HPiy6Y91PHyCpqMy1KohN4r2IHsdimU3+zCMGAaPl39CljmvqtPCB5Vc8O r2E5ewjYXjvTHpcb8J43FE0D1bruxW89Clj6mqGVBvaLhv1luzY5gM9FHVg5fnMrGx +lp6H1dgTd1A23QOXdvC9183UNMCBfFvNZAGgMNYTZbuUFCBupQO8R5k7mw999spRa oRzfv2GWTfHhp+ve6dntKUVFqxXdptQMundG6GDvbBBLQoPFepsKUzXoxWNRd7S4gv ZvzpiKvNzfQYG7ZfJSunbnJ39ZqC6JGl8CKHsSTrM9j9gkUBTcq1olNaCiWLrY0sBT eMaa6Ow2hFuyg== Date: Fri, 7 Jun 2024 19:24:14 +0100 From: Simon Horman To: Diogo Ivo Cc: MD Danish Anwar , Roger Quadros , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jan Kiszka , Jacob Keller , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next v3 2/4] net: ti: icss-iep: Remove spinlock-based synchronization Message-ID: <20240607182414.GH27689@kernel.org> References: <20240607-iep-v3-0-4824224105bc@siemens.com> <20240607-iep-v3-2-4824224105bc@siemens.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240607-iep-v3-2-4824224105bc@siemens.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240607_112421_938633_CFAB423D X-CRM114-Status: GOOD ( 17.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 07, 2024 at 02:02:43PM +0100, Diogo Ivo wrote: > As all sources of concurrency in hardware register access occur in > non-interrupt context eliminate spinlock-based synchronization and > rely on the mutex-based synchronization that is already present. > > Signed-off-by: Diogo Ivo > --- > drivers/net/ethernet/ti/icssg/icss_iep.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/net/ethernet/ti/icssg/icss_iep.c b/drivers/net/ethernet/ti/icssg/icss_iep.c > index 3025e9c18970..1d6ccdf2583f 100644 > --- a/drivers/net/ethernet/ti/icssg/icss_iep.c > +++ b/drivers/net/ethernet/ti/icssg/icss_iep.c > @@ -110,7 +110,6 @@ struct icss_iep { > struct ptp_clock_info ptp_info; > struct ptp_clock *ptp_clock; > struct mutex ptp_clk_mutex; /* PHC access serializer */ > - spinlock_t irq_lock; /* CMP IRQ vs icss_iep_ptp_enable access */ > u32 def_inc; > s16 slow_cmp_inc; > u32 slow_cmp_count; > @@ -199,7 +198,6 @@ static void icss_iep_settime(struct icss_iep *iep, u64 ns) > return; > } > > - spin_lock_irqsave(&iep->irq_lock, flags); > if (iep->pps_enabled || iep->perout_enabled) > writel(0, iep->base + iep->plat_data->reg_offs[ICSS_IEP_SYNC_CTRL_REG]); > > @@ -210,7 +208,6 @@ static void icss_iep_settime(struct icss_iep *iep, u64 ns) > writel(IEP_SYNC_CTRL_SYNC_N_EN(0) | IEP_SYNC_CTRL_SYNC_EN, > iep->base + iep->plat_data->reg_offs[ICSS_IEP_SYNC_CTRL_REG]); > } > - spin_unlock_irqrestore(&iep->irq_lock, flags); > } > > /** Hi Diogo, This is not a full review, but flags is now unused in icss_iep_settime() and should be removed. Likewise in icss_iep_perout_enable() and icss_iep_pps_enable(). Flagged by W=1 builds with gcc-13 and clang-18. ... -- pw-bot: changes-requested _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel