From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EC73C25B76 for ; Sat, 8 Jun 2024 16:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4yYCOiS96w0h6kE3PjlVn0+E6VTKYJTcniG+m/zWnf8=; b=MGRzlsLshuAAr3 31m5GgkJSps0ESkTSCPRmuslGVeYaVjpG7J5sh8Ll0TS0Tkhj6GTW0cgrCmthB81vVdmZY+pvbXei BebqzwbI6wIAhVjiZMzYrxrOb2VqJTMAz/PyKt8L7XfSxSzkDZlaigMqc19aAq2D28eEobi+dmSMA LuNWoGQkzoWrYVd6Et4Ijd+dkCBACgxdtF/UL7uHIz/8G4Do5PhlLz6C7OuBIZFzforUokjETXIr5 ikAhjwBrVclfyK9fvK56NIvRPL5zPeMmtbmqCa2NZYvD7NUSGQnvHX2YIKto2oFi9tUjY9sBtWUMi 7p9SCHFL7DfJwig4ZD+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFzHV-00000000NPM-0MdE; Sat, 08 Jun 2024 16:51:05 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFzHR-00000000NNO-2VaB for linux-arm-kernel@lists.infradead.org; Sat, 08 Jun 2024 16:51:03 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DB73E4CA; Sat, 8 Jun 2024 18:50:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1717865449; bh=NR+U+CNKQauqseXIio4VAlyFeO1ifNiLWsnsAqPQSkg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PyWZaVPb8FZDImIFRChwkX7UjSx5WbPxtmSjdCnMoHRDfJpXWYGvTq7bgRO70AuaF T+B9tL4FpoW/7w+FfppV6ZJR1tUGDnfCStDg8ovkRuguoP/6vSMZS22PeFV98l1haz ekRBaRQThh66wrzZdZF7G0LUsWt1zle/oeGUJ6Ug= Date: Sat, 8 Jun 2024 19:50:40 +0300 From: Laurent Pinchart To: Ahmad Fatoum Cc: linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Harshesh Valera , Pengutronix Kernel Team , Li Yang , Rob Herring , Krzysztof Kozlowski , FrancescoFerraro , Nate Drude , Shawn Guo , Marco Contenti Subject: Re: [PATCH v2 2/4] arm64: dts: freescale: Add support for the Variscite DART-MX8M-PLUS SoM Message-ID: <20240608165040.GF18479@pendragon.ideasonboard.com> References: <20231025165058.31697-1-laurent.pinchart@ideasonboard.com> <20231025165058.31697-3-laurent.pinchart@ideasonboard.com> <962e1d33-bc97-6bf8-b94d-581762dd6afa@pengutronix.de> <7046940b-854c-c4c0-461a-c817484f5d50@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7046940b-854c-c4c0-461a-c817484f5d50@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240608_095101_805453_9EEB27D7 X-CRM114-Status: GOOD ( 23.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 27, 2023 at 07:13:37AM +0100, Ahmad Fatoum wrote: > On 27.11.23 06:58, Ahmad Fatoum wrote: > > Hello Laurent, > > Ah, I see now, that this series was about to be merged. I missed it at first, > because of the MAINTAINERS entry losing a F:, which I now sent a fix for. > > Anyways, should you resend to fix the binding errors, you could address some > of the nitpicks, but I found nothing critical. As the series hasn't been merged yet, I'll submit a v3 that addresses your comments. Thanks for the detailed review. > > On 25.10.23 18:50, Laurent Pinchart wrote: > >> + reg_eqos_phy: regulator-eqos-phy { > >> + compatible = "regulator-fixed"; > >> + regulator-name = "eqos-phy"; > >> + regulator-min-microvolt = <3300000>; > >> + regulator-max-microvolt = <3300000>; > >> + gpio = <&gpio2 20 GPIO_ACTIVE_HIGH>; > >> + enable-active-high; > >> + regulator-always-on; > > > > Apparently, https://lore.kernel.org/all/20230721110345.3925719-1-m.felsch@pengutronix.de/ > > didn't make it upstream. Perhaps you mentioning that you could use this would help get > > it unstuck? :) > > > >> +&eqos { > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&pinctrl_eqos>; > >> + phy-mode = "rgmii"; > >> + phy-handle = <ðphy0>; > >> + status = "okay"; > >> + > >> + mdio { > >> + compatible = "snps,dwmac-mdio"; > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + > >> + ethphy0: ethernet-phy@0 { > >> + compatible = "ethernet-phy-ieee802.3-c22"; > >> + reg = <0>; > >> + eee-broken-1000t; > >> + reset-gpios = <&gpio2 11 GPIO_ACTIVE_LOW>; > > > > Nitpick: Separate pinctrl entry for PHY GPIOs that's added to the PHY node? > > Makes it easier to check that all used signals are indeed muxed. > > > >> + pmic@25 { > >> + compatible = "nxp,pca9450c"; > >> + reg = <0x25>; > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&pinctrl_pmic>; > >> + interrupt-parent = <&gpio1>; > >> + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; > >> + > >> + regulators { > >> + BUCK1 { > >> + regulator-name = "BUCK1"; > >> + regulator-min-microvolt = <600000>; > >> + regulator-max-microvolt = <2187500>; > > > > Nitpick: These may be the limits of what the BUCK can output, but they > > don't look like a safe operating range for the board. The Linux driver already > > has ranges hardcoded to cover what's possible by the hardware, so if you specify > > regulator range here, it should pertain to what the board and SoC are designed > > to handle. > > > >> +/* eMMC */ > >> +&usdhc3 { > >> + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > >> + pinctrl-0 = <&pinctrl_usdhc3>; > >> + pinctrl-1 = <&pinctrl_usdhc3_100mhz>; > >> + pinctrl-2 = <&pinctrl_usdhc3_200mhz>; > >> + bus-width = <8>; > >> + non-removable; > > > > no-sd > > no-sdio > > > > may give you a tiny bit of speedup during probe, if you know that there will > > always be an eMMC here. > > > >> + pinctrl_i2c1: i2c1grp { > >> + fsl,pins = < > >> + MX8MP_IOMUXC_I2C1_SCL__I2C1_SCL 0x400001c2 > >> + MX8MP_IOMUXC_I2C1_SDA__I2C1_SDA 0x400001c2 > >> + >; > >> + }; > >> + > >> + pinctrl_i2c1_gpio: i2c1gpiogrp { > >> + fsl,pins = < > >> + MX8MP_IOMUXC_I2C1_SCL__GPIO5_IO14 0x1c2 > >> + MX8MP_IOMUXC_I2C1_SDA__GPIO5_IO15 0x1c2 > > > > This surprises me. I'd expect that the SION bit needs to be set for GPIO bus recovery. -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel