From: Jonathan Cameron <jic23@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
lars@metafoo.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, matthias.bgg@gmail.com, lee@kernel.org,
andy@kernel.org, nuno.sa@analog.com, bigunclemax@gmail.com,
dlechner@baylibre.com, marius.cristea@microchip.com,
marcelo.schmitt@analog.com, fr0st61te@gmail.com,
mitrutzceclan@gmail.com, mike.looijmans@topic.nl,
marcus.folkesson@gmail.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v2 4/5] iio: adc: Add support for MediaTek MT6357/8/9 Auxiliary ADC
Date: Sat, 8 Jun 2024 18:44:04 +0100 [thread overview]
Message-ID: <20240608184404.5c34668f@jic23-huawei> (raw)
In-Reply-To: <575186dc-8a4a-4d93-98f0-d2271b0aa1fb@collabora.com>
On Tue, 4 Jun 2024 15:24:31 +0200
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote:
> Il 04/06/24 15:22, Andy Shevchenko ha scritto:
> > On Tue, Jun 4, 2024 at 3:30 PM AngeloGioacchino Del Regno
> > <angelogioacchino.delregno@collabora.com> wrote:
> >>
> >> Add a driver to support reading the Auxiliary ADC IP found in the
> >> MediaTek MT6357, MT6358 and MT6359 Power Management ICs, featuring
> >> a different register layout, configurationm reset and ADC reading
> >
> > configuration
> >
>
> Oh, oops! If there's no further comment to address, can this be fixed while
> applying, please?
>
Yes if Rob is happy with your response to his question on the
dt-binding.
LGTM as well btw.
Jonathan
> Otherwise I can send a v3 :-)
>
> >> sequence from the other already supported MediaTek SoC or PMIC
> >> (aux)ADC HW.
> >>
> >> This driver provides multiple ADC channels for system monitoring,
> >> such as battery voltage, PMIC temperature, PMIC-internal voltage
> >> regulators temperature, and others.
> >
> > Seems all my concerns were addressed, so
> > Reviewed-by: Andy Shevchenko <andy@kernel.org>
> >
>
> Thanks!
> Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-06-08 17:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 12:30 [PATCH v2 0/5] MediaTek MT6357/8/9 PMIC Auxiliary ADC support AngeloGioacchino Del Regno
2024-06-04 12:30 ` [PATCH v2 1/5] dt-bindings: iio: adc: Add MediaTek MT6359 PMIC AUXADC AngeloGioacchino Del Regno
2024-06-05 23:52 ` Rob Herring
2024-06-10 8:00 ` AngeloGioacchino Del Regno
2024-06-17 19:33 ` Jonathan Cameron
2024-07-01 17:17 ` Rob Herring
2024-06-04 12:30 ` [PATCH v2 2/5] dt-bindings: mfd: mediatek,mt6357: Describe Auxiliary ADC subdev AngeloGioacchino Del Regno
2024-09-12 8:52 ` AngeloGioacchino Del Regno
2024-09-12 15:20 ` Lee Jones
2024-06-04 12:30 ` [PATCH v2 3/5] math.h: Add unsigned 8 bits fractional numbers type AngeloGioacchino Del Regno
2024-06-04 13:18 ` Andy Shevchenko
2024-06-04 12:30 ` [PATCH v2 4/5] iio: adc: Add support for MediaTek MT6357/8/9 Auxiliary ADC AngeloGioacchino Del Regno
2024-06-04 13:22 ` Andy Shevchenko
2024-06-04 13:24 ` AngeloGioacchino Del Regno
2024-06-08 17:44 ` Jonathan Cameron [this message]
2024-06-04 12:30 ` [PATCH v2 5/5] arm64: dts: mediatek: Add ADC node on MT6357, MT6358, MT6359 PMICs AngeloGioacchino Del Regno
2024-07-01 18:40 ` [PATCH v2 0/5] MediaTek MT6357/8/9 PMIC Auxiliary ADC support Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240608184404.5c34668f@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bigunclemax@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=fr0st61te@gmail.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=marcelo.schmitt@analog.com \
--cc=marcus.folkesson@gmail.com \
--cc=marius.cristea@microchip.com \
--cc=matthias.bgg@gmail.com \
--cc=mike.looijmans@topic.nl \
--cc=mitrutzceclan@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox