From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3364C25B76 for ; Sat, 8 Jun 2024 22:58:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LnGGQUj6TxSstWnGZRdFkljPFeRJWZ9hvwt+34X2eNQ=; b=F5a1Vi5Gd3fwT2 ifH6KsT5hp7yEdOZ6VfaMdEvzahdMnkPZxr6K7dTxoMDfgEK+jgIVn6SAB9gM1d+oDOo3aYCPzbTi bUUnMYs7qtPjMfXT4pMpldIuHUpk4PnclzykPshuu9odAmpA7Hz3i+cMZiy8HibPWoLM5ZTxV7sok UHwTqSRAVCUiDVD0oj07XCC5Ol3sTaJJuBWlePbZ4VMdq41on8+QNVysFlnvkiQx/4H4ZK1EWD1/1 4E7UMaaE8X98mJUkV00AYJoV2kd1eB9oQbn5GPMt+cE3ERFwdfAe+DEgQ4o0aPCmsHQzdgxC9Dg3h QjtcTqZ08ksR9FJqUalg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sG51A-000000017eX-14UF; Sat, 08 Jun 2024 22:58:36 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sG517-000000017ds-0YvV for linux-arm-kernel@lists.infradead.org; Sat, 08 Jun 2024 22:58:34 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a6ef46d25efso183569366b.0 for ; Sat, 08 Jun 2024 15:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717887508; x=1718492308; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xnNwc2LGbMmroe/knes/Yk2//+knIMtvNN3CoAHTpmU=; b=IjW+yiYLu9aK2e7VbYoisLjaR/Ik31djEtinydiz9s23M7HdaGRZH/N0LHbsNfuS7h BZ/QWsdLeQRC2Jsku+pscpEKbDrCbDq1J31xqviVjEuOs76lkLzY1PEMm53plnE9RBUG uVgPilNr27SeuayltihK9UfZ8RCxIa3Q0qE2WnF0HzkFt74Xid59qL1Gga+HIo4UWDoo yuoBAiYRkmFSs9uuNJOfodZjDl7Wd+oINCl80Jl1GS1Lp47p6zZYzTvSrYslTMAg2+iA QS/o+xYFA1zO5N+6yx4ocRyqNpPNLOD1+c5fHR4x6cvzsSu+/Nl8O5gPuMS6TUbO/luT ZjKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717887508; x=1718492308; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xnNwc2LGbMmroe/knes/Yk2//+knIMtvNN3CoAHTpmU=; b=JY98hgUyYH4FRH8JUYenAx2EcOe1oPAX12spVYyIFvNj+rjIlQ86okeLk5RTijBT8p pyv435GxbNFZQn42ydYtJE0LU2Flij/Qy48HE2snDY3GLQUCHBqb1QqxKpnZI4Zu/mXC ZJeMBsEPFauaS+QvZM34nO3e9x9Tkh+cd16FNGNlHPccCzN8yJo/qSMdy5SH6kOJR/DT Nqe2EedOwj00+Q+IsT5X/sJzQYHxWR5rOmhBkIV4uzrVKUbLT6pjXYpf1itakjOSzjf2 S+pCGicFtnf2ENRzCMxzSiDOXh37xMyvXEYEd508/KDVw1oaOauUU+9WmPNcrmkALKkZ E9Cg== X-Forwarded-Encrypted: i=1; AJvYcCV+397RS9R/uervS4bQ8LYimyWIVMVwRtVYi0TKrdoYLJULIwFg/PB7vfsOIeuVI/UctV9TwyrcmKL/pDGhI2hmplyW+tPKOElBdlbesr9A+Coiqm0= X-Gm-Message-State: AOJu0YwwAUhP7x0/Ll3Qa8ZHh39P7n9SaFUQ4QKj6JesLmxZ77U1ei6+ SVBD3r8Fd1h2YQJDpqHUR3MCWEInOaNQe1APTlKzRgsQMMgdbiMGowsmQ5NX X-Google-Smtp-Source: AGHT+IHzT4dW0AQbWU8Ll27rAW1mMXU6/phWBWaFUZTgEyUAKve+QqneDBv9Atir+V20O1ejYoBo6A== X-Received: by 2002:a17:906:495a:b0:a6f:cce:4457 with SMTP id a640c23a62f3a-a6f0cce4ce2mr110771466b.71.1717887507926; Sat, 08 Jun 2024 15:58:27 -0700 (PDT) Received: from skbuf ([188.25.55.166]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f16427842sm21529266b.100.2024.06.08.15.58.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jun 2024 15:58:27 -0700 (PDT) Date: Sun, 9 Jun 2024 01:58:24 +0300 From: Vladimir Oltean To: Xiaolei Wang Cc: linux@armlinux.org.uk, andrew@lunn.ch, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, wojciech.drewek@intel.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [net v5 PATCH] net: stmmac: replace priv->speed with the portTransmitRate from the tc-cbs parameters Message-ID: <20240608225824.nae2ptctjzf5reee@skbuf> References: <20240608143524.2065736-1-xiaolei.wang@windriver.com> <20240608143524.2065736-1-xiaolei.wang@windriver.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240608143524.2065736-1-xiaolei.wang@windriver.com> <20240608143524.2065736-1-xiaolei.wang@windriver.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240608_155833_292439_DCCD1C83 X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jun 08, 2024 at 10:35:24PM +0800, Xiaolei Wang wrote: > The current cbs parameter depends on speed after uplinking, > which is not needed and will report a configuration error > if the port is not initially connected. The UAPI exposed by > tc-cbs requires userspace to recalculate the send slope anyway, > because the formula depends on port_transmit_rate (see man tc-cbs), > which is not an invariant from tc's perspective. Therefore, we > use offload->sendslope and offload->idleslope to derive the > original port_transmit_rate from the CBS formula. > > Fixes: 1f705bc61aee ("net: stmmac: Add support for CBS QDISC") > Signed-off-by: Xiaolei Wang > Reviewed-by: Wojciech Drewek > --- Reviewed-by: Vladimir Oltean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel