From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FFFCC27C55 for ; Mon, 10 Jun 2024 16:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rTe+ng+FMnSd5hjepO+0glt8WgD4QEP4CwUVEyo77go=; b=aAXQFrZTpgqgP97SeTpTaidmoU BplyjWM5WILBIzyawGL6mTB7bKbFIkxBbYVne08/XhgLLdUM0lXuplBMLFaKeQhDsoN17GEs/lgZq b2Za0x47uyGE5KXEi3Mi6K+ZkWS7Z6yH/rgXSykMCYN+IGheQ8gUbfi0D9Z1AXt9z3IlXC6h+yHkc YmR2kVdcVXGRSK255KB0vN5bPEZBOgvxDz81enRmuKYaFM9oveAiipCP8UajRkfA4EoC8psImOzpE zk713h0bI+aBLaSQHkbquiKHLBh3GH7jXrZbP8kVaHEqe4wNLNIaVbI2CkqfYt9gRV0W4o1jYmJq3 jsgTqVYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGhqm-00000005n16-2OsU; Mon, 10 Jun 2024 16:26:28 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGhqe-00000005n0B-45iw for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2024 16:26:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 61AFC60B50; Mon, 10 Jun 2024 16:26:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A21EC2BBFC; Mon, 10 Jun 2024 16:26:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718036779; bh=3UIaTShxInkjQ1pe5ZJloG0WAaJI7u1kBfrsEMbDQZs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IiMbKDcMuesDyvDpScf+uzY9N15WDFL2TEbbvcXbuaDQi4quSO4LZSZgDoHDo+vJf XLXvRyXSb9tKLQwwjW3fO/1ZhK2sixRt88ZKibbFE/keLp9nCivgZRs3+MGJawIKnF RbwW2JEWe1kgbgqp0POECn9HZdpCNM2jQGJv/cBkXYipGs9libJJ50+AHvwyS41xtg qFA3JOqi4msxRDtdliZz+mpChRqxWMC4evZs5SjYuuThDaF6riZJ3UbNDHDpaHsTTw ygnhdXrDTKTOiDIM+OSTyUSNaVjdgZaogn5nJhxzMag6c9P08frv9sf8m6Mk8KA2V3 oh2PYNQ5V3Mlw== Date: Mon, 10 Jun 2024 17:26:13 +0100 From: Conor Dooley To: Christophe Roullier Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown , Marek Vasut , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [net-next,PATCH v6 1/8] dt-bindings: net: add STM32MP13 compatible in documentation for stm32 Message-ID: <20240610-relay-vanquish-b939690775dc@spud> References: <20240610071459.287500-1-christophe.roullier@foss.st.com> <20240610071459.287500-2-christophe.roullier@foss.st.com> MIME-Version: 1.0 In-Reply-To: <20240610071459.287500-2-christophe.roullier@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_092621_274175_F39F530F X-CRM114-Status: GOOD ( 18.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4309039860371329698==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4309039860371329698== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="chgm6HB084fcCxg1" Content-Disposition: inline --chgm6HB084fcCxg1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 10, 2024 at 09:14:52AM +0200, Christophe Roullier wrote: > New STM32 SOC have 2 GMACs instances. > GMAC IP version is SNPS 4.20. >=20 > Signed-off-by: Christophe Roullier > --- > .../devicetree/bindings/net/stm32-dwmac.yaml | 43 ++++++++++++++++--- > 1 file changed, 36 insertions(+), 7 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b/Doc= umentation/devicetree/bindings/net/stm32-dwmac.yaml > index 7ccf75676b6d5..f6e5e0626a3fb 100644 > --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > @@ -22,18 +22,17 @@ select: > enum: > - st,stm32-dwmac > - st,stm32mp1-dwmac > + - st,stm32mp13-dwmac > required: > - compatible > =20 > -allOf: > - - $ref: snps,dwmac.yaml# > - > properties: > compatible: > oneOf: > - items: > - enum: > - st,stm32mp1-dwmac > + - st,stm32mp13-dwmac > - const: snps,dwmac-4.20a > - items: > - enum: > @@ -75,12 +74,15 @@ properties: > st,syscon: > $ref: /schemas/types.yaml#/definitions/phandle-array > items: > - - items: > + - minItems: 2 > + items: > - description: phandle to the syscon node which encompases the= glue register > - description: offset of the control register > + - description: field to set mask in register > description: > Should be phandle/offset pair. The phandle to the syscon node which > - encompases the glue register, and the offset of the control regist= er > + encompases the glue register, the offset of the control register a= nd > + the mask to set bitfield in control register > =20 > st,ext-phyclk: > description: > @@ -112,12 +114,39 @@ required: > =20 > unevaluatedProperties: false > =20 > +allOf: > + - $ref: snps,dwmac.yaml# > + - if: > + properties: > + compatible: > + contains: > + enum: > + - st,stm32mp1-dwmac > + - st,stm32-dwmac > + then: > + properties: > + st,syscon: > + items: > + minItems: 2 > + maxItems: 2 > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - st,stm32mp13-dwmac > + then: > + properties: > + st,syscon: > + items: > + minItems: 3 > + maxItems: 3 > + > examples: > - | > #include > #include > - #include > - #include Unrelated change. Otherwise, Reviewed-by: Conor Dooley Thanks, Conor. > //Example 1 > ethernet0: ethernet@5800a000 { > compatible =3D "st,stm32mp1-dwmac", "snps,dwmac-4.20a"; > --=20 > 2.25.1 >=20 --chgm6HB084fcCxg1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZmcpJQAKCRB4tDGHoIJi 0tffAQDMCZd4Y8qJBiuAkUt0ppGvuLVuiB+9OHGL+/fRrxrGNQD/XXHMOtOGzn7O 9e8VAL9hwogjnLKXF/R6ClOO4Hj/ZgI= =LIXm -----END PGP SIGNATURE----- --chgm6HB084fcCxg1-- --===============4309039860371329698== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4309039860371329698==--