From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 092F3C27C4F for ; Tue, 11 Jun 2024 00:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v3PHSbBwZzK0F8gumb6V2tQm7FevxZ5gks/sYV4ItBA=; b=GP8X1fjwCYpG0/ NQEeoe6+VvKumLfZpZsZE3x0sl3Z8lx13wUA3jhrGVj/JtLnPXNWQZOJC6A08sXsdJGrWpBjWLZbH Vb81LpcX+8cfSr5lOU9LqQZsSdEmttxxD7hMS7ge5lAvx47VApDPrf86xhqmd7Cr3CcukO2vNL0HX ciAbJMmIjmenLLYXfK8nL6j0pdMrDG3ndSFWkC8EaQUk8NqT9sljeM+HSBfmOfsQNiBAKnClvQj5K DZdxM91lr6HQcEVua9+FXrw71N2NNiv05VIWh9OMyY6p34LruxEnt3oT9sFfvLmpnmJoVbPnctW5i +64i1DCtp5si56WnTY5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGpNi-00000006xyD-3zHe; Tue, 11 Jun 2024 00:28:58 +0000 Received: from mail-mw2nam10on2061a.outbound.protection.outlook.com ([2a01:111:f403:2412::61a] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGpNg-00000006xwr-3FJX for linux-arm-kernel@lists.infradead.org; Tue, 11 Jun 2024 00:28:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mr/+/PuwhzKeFMMqfsCgf1xoYfNMLLtke81s+Gy6ezvLfvEJkGpHldhBbxDPE4XljGLDkZfIYAW3Mc6yXhyJeUNMXAoQWH7sqD/qrT+GeIXfOjALspYB+hZwtnDHNDmFpIebICMHCO1hV1gvlpXu6QnVd6XCvBrZY0bcpNwIGMpOglhhhHOgB54wIVKv4Qp4nv4CtMy/J4/UGrUu+b7z1ZYNtohXxTDW4glJrm6jiZxNwPQQkvqVB+6Hlj0YU384SHx+xuRV6Z1Wa/2mdbZZ8NWp7nhLznvFQ7UAmrTly8WzfVvGv8CPOBKhktu6Pf/uzvbfmUujCqMsUGiD9V/PXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e/fkboRB9aqDVnYobjSDW2v5sdX07FI5DTLk0iSYBfc=; b=Msj3RtM/IcSUNKOQOrOm0LntIPXKEbojexT58ojP9icwtJ0HscjLhlrRGvNlZymGnPzrIVrBfaFHCVyhEAp0HW+VatVwTqgozRI+mSmr20cR00W9NOctwLivG8zmeveRabrkaNoKbjRegGkQqy8yIh8MbSO9lCfHlLdG49tNkDKHD58385rNq7cOr9hxIF5zyfOH/sdiYv4EgHxHAGkeYENpA9JOjMWFOCqfoXcDgS8iyKdaS82vBkiZ3n3B086JXbUOqd/aOKG7+8W2PlJBBFQzvIcb3lD6c45tLxTqtacQjKN9W9Ud5z+Ckw94atzrjQKyGk3fBFhPZHho3877jQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e/fkboRB9aqDVnYobjSDW2v5sdX07FI5DTLk0iSYBfc=; b=YpFqA0XmZIjI480V0Ga0egNaiy/ojVuoF+fprlV7KdwHV7ZnweZSiPJ3XbWZZ/gGIlTdBW48YQ5y+TIXuS88Mng90yznXU0swgh2Jzke434M6S4lODV4mTSAkxFg4z2i5BrxAP5unbSOVzna+XOvVSSA3v1z6rGghFgO4T6Ef+lrAhBbf/NIKTu0PX2gXs2hsoU+VbWb+hRoyGiZSAQ79Fp7dimr1FcAv4RJHInoUhPW9dDJr4TFGTFroVg6NdQYddJXGQ3zCnjrYybCraK+zllebNzpNx039AoWLs6fUQXrC9RAZf3DAMCgR1qvj7TOaTd5w9qbJ/XzCBQRFHIVqQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) by MN6PR12MB8565.namprd12.prod.outlook.com (2603:10b6:208:47d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.36; Tue, 11 Jun 2024 00:28:42 +0000 Received: from DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::c296:774b:a5fc:965e]) by DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::c296:774b:a5fc:965e%4]) with mapi id 15.20.7633.036; Tue, 11 Jun 2024 00:28:42 +0000 Date: Mon, 10 Jun 2024 21:28:39 -0300 From: Jason Gunthorpe To: Nicolin Chen Cc: "Tian, Kevin" , "will@kernel.org" , "robin.murphy@arm.com" , "suravee.suthikulpanit@amd.com" , "joro@8bytes.org" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" , "Liu, Yi L" , "eric.auger@redhat.com" , "vasant.hegde@amd.com" , "jon.grimm@amd.com" , "santosh.shukla@amd.com" , "Dhaval.Giani@amd.com" , "shameerali.kolothum.thodi@huawei.com" Subject: Re: [PATCH RFCv1 08/14] iommufd: Add IOMMU_VIOMMU_SET_DEV_ID ioctl Message-ID: <20240611002839.GS19897@nvidia.com> References: <20240606182423.GF19897@nvidia.com> <20240607002707.GJ19897@nvidia.com> <20240607144917.GK19897@nvidia.com> <20240610120446.GP19897@nvidia.com> <20240610220110.GQ19897@nvidia.com> Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BL1P221CA0008.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:2c5::28) To DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB3849:EE_|MN6PR12MB8565:EE_ X-MS-Office365-Filtering-Correlation-Id: 81437f83-072c-425d-2ef3-08dc89ad7237 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|7416005|376005|1800799015|366007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?UjABrzzXC/AiKqQm6tq5E2oUMRm7UoP5BAGRAKS8uXr4mwrE4MbdARYtB6Ql?= =?us-ascii?Q?6K9FQ88Mw8qMlJ7PZC3d4IJBeWxD+CAD6YAQH5h79W+hUZSNDf2T0IfSxVHS?= =?us-ascii?Q?oPEf46aWC27riyqBCdiBcN2nR66+U9Mi79dx0KAoyLA3wkl6P507bc7aFApz?= =?us-ascii?Q?jLUXYaanQCXIxyjQhFTLSv5a8UoxvTRIvDQF73SvgT1KprRmjsf6fwGHaDTo?= =?us-ascii?Q?MqVw6mlLnFjA85STCQDbQpKSr1oZ1ZtmuGxM/BwTS7XVqCuZ0+iy16nTpq8A?= =?us-ascii?Q?vhOfcYyskO/xaHl+trEnrPYlXx1+IHbastqsV3zWrfsQLo5fJc0dJyqS3HZ2?= =?us-ascii?Q?gVCsxCVGDXQDtw+VRTOunoBqcKz/a7wk7lpPT+XNHekoOuz5x7/6FBBcM6dW?= =?us-ascii?Q?5NsE/nS0TMBP52yAr6lsagYUctx1dcRKZgyjTDafohcVBkiemEWgmCycrQBV?= =?us-ascii?Q?5Fmer7Vg31wsZujk/sU63F+946RPDzz/ItDFuors/KSZkRxwXF82oRFBNNGt?= =?us-ascii?Q?S57DcJ2RPrPWalYW7MItcXne52dYYIu31z2wPi5vwwPQJPOzhle9TXdiDWaE?= =?us-ascii?Q?yn0Eiilw/6KEMt0QWXoaDboE1m+i/TcmjaHJKCxdyOtX1xSFL6UMWI36JjVF?= =?us-ascii?Q?N+AxxOocDsDwD9pGHMHQri0gHhnXve+lT7lkEFEhxVFoDZKrPFVu7WPXxNUD?= =?us-ascii?Q?T1aox/QkWcDcukSkU8VL2u30skzIaBZcfMauVkKH7HvV8UI5CKFjY1kptvcw?= =?us-ascii?Q?5Yfu6hl5WjcKCiQkP9vex9bGFH2yHK+QC7nNxE5pNDmpUKNEWchnpYQe8yzq?= =?us-ascii?Q?OwKfFXc1MyD5qIKiD7NM44FlfAhksK+9pqVGdPJn7OrlGlcGnBYcStGR0Lz5?= =?us-ascii?Q?ZdtzBTKEFaTCK7ULBfqdFRJLzEvlQV0hWs+45bU+FifCbWBQvWKrMvTAR0qy?= =?us-ascii?Q?SZ/ZT/1rVtMQ2U8GNkCFF6j6sGM1SAFuaTv3Kx7qZktCkRx+pYmM9mcmKHkT?= =?us-ascii?Q?4X2N4HARCfNlrML92syDehtYl0eV+CrbgrkNUgMzkDXsKy/pYTzHQFix9AmN?= =?us-ascii?Q?X1m8zlbe4MynVlSFRMDOpALgEvcS+qm4K4oZyMB0mXvwn9i+Fi/6vqBpNglQ?= =?us-ascii?Q?9AfsSSDHi6gEpSXzu531+I1FMEv7ddLcdPs9Pq7PyTlNZuhb/AB5LCm7YOOR?= =?us-ascii?Q?ZivNKkFdTdeOLbLYSJ3yW2kh/be1jMoTVkKp5R0Z7wzysgMQ8wUP5P2N/Gek?= =?us-ascii?Q?yBMJrKubtG1/isMjXavWgSGB+JR7ztOXrQrTmlHVDAhC2UL2C0ZimJWIsHIe?= =?us-ascii?Q?idX2mhGdLpWlUwt9mjde5mIq?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3849.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(376005)(1800799015)(366007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PUcuk+8P+zgVB+u7eb8zceXN4wytP7/ueILOK8IQDSvjweL+LPf5JxBJjXxY?= =?us-ascii?Q?GPsFvppC2RGR5ZBTXwKE4E443YhrDlvfpSmtgAf34MdBZjnd53JVV0Gq3NT+?= =?us-ascii?Q?jSlLb1xEVhlretr1Yz20+Ppez/WnJL2D8IqRluchLJ3w6kObgmLolqGO0KEw?= =?us-ascii?Q?zD7uuj+CegKLJLrzLZCgsZncu6DcDuTXu97TOhJjowd2RKedTaH5YZCuA9sq?= =?us-ascii?Q?yrf9d13UQNI+TVr3IwLQ/JZloXdlYdNvG0/MYmm82ythjpfTE8ltPOld6eVE?= =?us-ascii?Q?ib3qBjOxLMVsDacDBjx0A0ipEhudA7PiSD+OoWsyceEaHvaUz4bGXhZ0D9yc?= =?us-ascii?Q?i0FtRhmCkj/oSbZ8qfx/zD/HcRd0LbsFTMr0F/a9eqXtQ4AoNFupSAPE3RNo?= =?us-ascii?Q?q2NiQYEPQALH4YnHz9BF2uyw/CX7cbU1MkV+orydSXvhyBn1EJhK30CW3wHL?= =?us-ascii?Q?3BuLAEpZGKgNybKpvktnlQZicDFhp+0TbAET9FQ/Chqov3wgz2fAYv/ECZMi?= =?us-ascii?Q?zOthg3PXr783WBDCpNvbOFdDFCMxYZVnfoYr/t7owSc5qDiyUcT8Jx8oFfCg?= =?us-ascii?Q?hwHwW5Y1UFOVq8/Afc/5+ImZAK78HcLZpgGGCfi6Thx/x5Bm59OxhWKbVbfi?= =?us-ascii?Q?DYSbVJZKZUT9xyE4ZBDh3cGKtGJwFBPRNfJqCnrGA/2h4m1m60iH8YxMJJTX?= =?us-ascii?Q?Fh3WRLW+1OgrgwiMq9VBa+e/6BaBNbskT7JqEnM53Z7LfvbwEYznbtE47nFF?= =?us-ascii?Q?gacYYyJWRy2sbOx5BP03cn4BaxMFQfBrTOVx7x3tdSV1tr6yAQJPaShtXjea?= =?us-ascii?Q?r+VltQe+8EpI48rXJoxeDDuERsWGZAYKKqACkP7DSrsJwJxiaipRrWwGdR+U?= =?us-ascii?Q?X5+ClkVCHDRW8Jweovq0sjb/8WxWzyHFVYqJ0BLDKJ2vAzSAZDATlpr+Hiqf?= =?us-ascii?Q?16OoKduQkZti/C5rKbdiagPsTSoqjh/5HtyTed6URQrOTnk9/CMKtNN5B7wR?= =?us-ascii?Q?KeRHo2kXiWgDB8kGZ5Gov2VWtaXJxBpiRoRugXZdJFGJmaxII2yqD1cOAkaN?= =?us-ascii?Q?JaGEbh3XFsujl0uhRtwzMB96t+jCayPpDC2Zdt77W0Iw4LFgt2pB93sGjpQh?= =?us-ascii?Q?1CqlyXd4orBgXc6L0sTtGsT1aa93uVol78UYu+uPo6evnWN+mHzQAilYwSH0?= =?us-ascii?Q?nFAuqH0SbZeSjx7PCuSQtwrsChmjfmlOKGgg2sV6uVEvyTVxmv0bUrnWktJA?= =?us-ascii?Q?yHgi5USDAvKD3FNrEgg1HR+nyhrAUArxQ8Bhu+W3EOtJVnn8NbEtA1rMuxSg?= =?us-ascii?Q?l1AJTd8WrEJvfbXkbUN3sBgceZMmv/Xa8Xhw4ieuw3pmq3GhjOUZGO2xJ9zj?= =?us-ascii?Q?M6HATrU/CFK4f6vmfY/ewmfzHEYMDSyLC6qQQ2tCSkb9mqa9bZwuhVhyhGDI?= =?us-ascii?Q?ht5JaE0o4HowHml9h8a3YXTxeEF4Pee3NI7hq00DmGgqVvv0UhxR2GvAMu9p?= =?us-ascii?Q?NP4Ch5fP1FyWF2caAmz/A2zvjVYz5nHdCpHlBc7G/x8xruCG1fYIGV5ZiZ0m?= =?us-ascii?Q?lEMrWxH5sbP0KhmGlmw=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81437f83-072c-425d-2ef3-08dc89ad7237 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 00:28:41.9629 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IZl4atCQUIJOesSlW+mELE+tyzpo9Te0SNZPxdIaZKlasLYfLf8aAC8vqlYkkdtB X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8565 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_172856_840266_4FE9583A X-CRM114-Status: GOOD ( 15.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 10, 2024 at 04:04:30PM -0700, Nicolin Chen wrote: > > > Actually, even now as we put a dispatcher in VMM, VMM still does > > > decode the CD table to link ASID to s1_hwpt. Otherwise, it could > > > only broadcast a TLBI cmd to all pSMMUs. > > > > No, there should be no CD table decoding and no linking ASID to > > anything by the VMM. > > > > The ARM architecture is clean, the ASID can remain private to the VM, > > there is no reason for the VMM to understand it. > > But a guest-level TLBI command usually has only ASID available to > know which pSMMU to dispatch the command. Without an ASID lookup > table, how could VMM then dispatch a command to the corresponding > pSMMU? It can broadcast. The ARM architecture does not expect a N:1 mapping of SMMUs. This is why I think it is not such a good idea.. Yes the VMM could walk the CD tables too and build up a bitmap of what ASIDs are being used by what pSMMUs, and that would be fine for the VMM to do, but I wouldn't necessarily recommend it :) Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel