From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D082BC27C4F for ; Tue, 11 Jun 2024 03:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/Va0Th+rqcTr0ujqJo/R7vDfBAn8puR6wW/XldpG3HA=; b=0rDhDZy5tKrg7R l+2/IzH000SDIjZRfDbgAL1+x/raGywxPDsjFQaEBFL8x3Z44KwS0n7dowB3q0keTPrlVPzWZ5YYQ ICyFxPt/mKIm9c9k1971zRX3hqvsndutXu58O/uM4Y/AeC8vn9QW2C85oH33k9XOBUNEmOQTm85f6 TIKcOQ7rU0OZJTGNXzOxnC3JDYCxAUMcSv/Q4yDT6+wcHmc7pH4ZB/CQnmtSUG+QmenDgcHuNUcOB nA12tTK0PsW7o0+Hx89Xs6bnsvSjGPLVErhi1FuGbRyHfprknbr5tK2I1YtSBbnaRaU/hcgGUn7RT WEvHtOewykvs3BSX5QRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGrwp-00000007ESt-1Rzw; Tue, 11 Jun 2024 03:13:23 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGrwn-00000007ESM-0cT0 for linux-arm-kernel@lists.infradead.org; Tue, 11 Jun 2024 03:13:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DF9B660B5B; Tue, 11 Jun 2024 03:13:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FA24C2BBFC; Tue, 11 Jun 2024 03:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718075596; bh=ZMZKxxJuYo9eKsMIOrsBuBANLaKNn9wG+ufnOZCOjg8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qwrt7BtcqvK3RqTdB+lO3NW2bXjr5H6ZeRZRK31zbrHc2Dw8811Rc9KWlhaRKnwpg kaGVXt8lp+WTZDw2EJeZ2b/rKVU7nX9BoGIcCLyGcvHDtBtjW12M7yR0i371HyNbj7 W0d603VGCTb8cU2/jQxFXpkiQQ8tvE9jDRu54Qr2kcfu84Z85k4Esc0YMVKzD5c3An T22n5eTOYz6MzRZe+nbjkJHaVZqRsbDhvwilQlC7bCrQMyer7dqSP0ynMcCVYCM74t DaMBqK+kHk57pPXIlLqXiBmUTouhB+0NLMdTrdoAsbCosCP+8BhzYxOy6xfxfH/bqd C/1n6fqamoA2w== Date: Mon, 10 Jun 2024 20:13:14 -0700 From: Eric Biggers To: Herbert Xu Cc: Kamlesh Gurudasani , kristo@kernel.org, will@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, vigneshr@ti.com, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 0/6] Add support for MCRC64 engine to calculate 64-bit CRC in Full-CPU mode Message-ID: <20240611031314.GA2557@sol.localdomain> References: <20240524-mcrc64-upstream-v3-0-24b94d8e8578@ti.com> <87tti098af.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_201321_280968_A11CC3B5 X-CRM114-Status: GOOD ( 17.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 11, 2024 at 10:31:45AM +0800, Herbert Xu wrote: > On Mon, Jun 10, 2024 at 08:03:44PM +0530, Kamlesh Gurudasani wrote: > > writes: > > > > > From: Kamlesh Gurudasani > > > > > > MCRC64 engine calculates 64-bit cyclic redundancy checks (CRC) > > > according to the ISO 3309 standard. > > > > Could you please review this and let me know if any changes are needed > > to get it merged. > > Eric Biggers had concerns about adding this to the kernel. I'd > like know if he's OK with this or not. > I thought the rule is that there needs to be an in-kernel user to add algorithms to the crypto API? Is there any precedent for adding new algorithms purely so that accelerators that implement them can be accessed from userspace via AF_ALG? Even if acceptable, the motivation for this one does seem weak, given that a userspace software implementation would actually be faster. It could be marginally useful for freeing up the CPU for other tasks if the inputs being processed are very large (probably at least several megabytes), though. - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel