From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC4F0C27C65 for ; Tue, 11 Jun 2024 06:10:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6WgV6eCXPKFpbCCL3cAsGSsmtIeRM45BvvjCfa0PUrI=; b=zoPlMGDHweUCKI R0lYuZkS/2bUGcnF0wiiggKWTm8tbelH41FO03XbukDunfWgambF+jxqQt6AX6eDfncChOkBAMdE5 9wcUES9bS6Ti7G6Joyp4Fx7gI9dr+2JP4ocMpLquuSL4QX/XC/dXG8cbfvCcLkUkGgBNmYVymiGeo AVpYK8HTu579q43xK4N9w21pLg2zIHpLan/WsM93oM0j/Mr4pWkeIJlEjJYFd95OkNl6DgdZf4ES3 610COVflRXllL1Qb1wyiFAjfjPXdJRbEF71QetbvXuobVDuTnBYF4bTaNIKXdzncNIKIn7FmcALAw I7oEufzNS+A/q8fu+Sow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGui1-00000007dTl-2yQe; Tue, 11 Jun 2024 06:10:17 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGuhy-00000007dRe-25Lg for linux-arm-kernel@lists.infradead.org; Tue, 11 Jun 2024 06:10:16 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 45B6A0Xi121243; Tue, 11 Jun 2024 01:10:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1718086200; bh=FtYObnNVwakYowCUn2TrHl3DGDxxEgIe5m751WPYKCk=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=KNhOCk7YtcetQ4y9KJAxAuLlrM74orpfPG7ki3L4JPIL0P6oT+RbrXPtCZpAlKMxz ywLkblqsB1zpXK+vHTnBOgi2/KJzAIfDFEaikhZwMvHhKOkeLUbVRiP2SnNXNyvUT5 JVDBty64X+4hMVHjPS+/bWD8Zhexp5NUJnjA2XnI= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 45B6A0J9048676 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 11 Jun 2024 01:10:00 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 11 Jun 2024 01:10:00 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 11 Jun 2024 01:10:00 -0500 Received: from localhost (dhruva.dhcp.ti.com [172.24.227.68]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 45B69x5t051533; Tue, 11 Jun 2024 01:10:00 -0500 Date: Tue, 11 Jun 2024 11:39:59 +0530 From: Dhruva Gole To: Andrew Davis CC: Sebastian Reichel , Florian Fainelli , Broadcom internal kernel review list , , , Subject: Re: [PATCH 1/5] power: reset: brcmstb: Use normal driver register function Message-ID: <20240611060959.nvcaasoft7l2gr3w@dhruva> References: <20240610142836.168603-1-afd@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240610142836.168603-1-afd@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_231014_649613_2472B6C0 X-CRM114-Status: GOOD ( 17.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Jun 10, 2024 at 09:28:32 -0500, Andrew Davis wrote: > The platform_driver_probe() helper is useful when the probe function > is in the _init section, that is not the case here. Use the normal > platform_driver_register() function. > > Signed-off-by: Andrew Davis > --- > drivers/power/reset/brcmstb-reboot.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/power/reset/brcmstb-reboot.c b/drivers/power/reset/brcmstb-reboot.c > index 0f2944dc93551..797f0079bb590 100644 > --- a/drivers/power/reset/brcmstb-reboot.c > +++ b/drivers/power/reset/brcmstb-reboot.c > @@ -140,7 +140,6 @@ static struct platform_driver brcmstb_reboot_driver = { > > static int __init brcmstb_reboot_init(void) > { > - return platform_driver_probe(&brcmstb_reboot_driver, > - brcmstb_reboot_probe); > + return platform_driver_register(&brcmstb_reboot_driver); Reviewed-by: Dhruva Gole -- Best regards, Dhruva _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel