From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A60EC27C5E for ; Tue, 11 Jun 2024 06:16:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bNKI9Z9WoF3/cYUMLKEgMY5UD/WDX/wu2JDnc/2IyhY=; b=K6XVxArsvo1x1I +48JIf4o3i84AvvE8eHC/jviz0jwup6YNBdEKH2AJnmczz0MglH34nIEz9ulSbiUijtEpdoC2v1fy 0ZWwtNeSufCUchIBDtuQtj9DPVlVgC1NaNA5nI0hudri6fVe8YQ1FM5HWvD4gN4bMBiF11N9DbPAW x43O6XEPjcVV12oT780PDvtnV09/RUFy2r8ST+nwPLhKpbQSIGq7d9UCYmzmTJ1GCtQd2Hk1cG8oc LSvO4iclxovKWl/GBq1t66X5fzJIJg+BlkSEudtuc47tPwVW6gO99VCEE22b2WnAx+50URnNn1f1+ HiVPb6GZJaTr76lRmXhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGunR-00000007e1E-3PMd; Tue, 11 Jun 2024 06:15:53 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGunO-00000007e0s-13wm for linux-arm-kernel@lists.infradead.org; Tue, 11 Jun 2024 06:15:51 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 45B6FjEE123312; Tue, 11 Jun 2024 01:15:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1718086545; bh=rW+1bWfOjK8LklAi5rLMDUblTYcqO24dKWlfvRIgaZY=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=IWyXzCkV+gdrroEyemV28abeEAboGTyRf1vPNNWBfAqkZiSo3hLHaEaLyF2NoySfv pSGxKjjJ0qvIOqZHtuJyGx73blIONVZJJqR2JYQY0oC93qLvuk+XQxnvYsdGsNVzLW BaPV7XON4qNAj3lgbLrUVIAPnKLm4i0QACQRnRGU= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 45B6Fihl028990 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 11 Jun 2024 01:15:45 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 11 Jun 2024 01:15:44 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 11 Jun 2024 01:15:44 -0500 Received: from localhost (dhruva.dhcp.ti.com [172.24.227.68]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 45B6FhHU060985; Tue, 11 Jun 2024 01:15:44 -0500 Date: Tue, 11 Jun 2024 11:45:43 +0530 From: Dhruva Gole To: Andrew Davis CC: Sebastian Reichel , Florian Fainelli , Broadcom internal kernel review list , , , Subject: Re: [PATCH 3/5] power: reset: brcmstb: Use syscon_regmap_lookup_by_phandle_args() helper Message-ID: <20240611061543.jivkvda6hhsyv4xu@dhruva> References: <20240610142836.168603-1-afd@ti.com> <20240610142836.168603-3-afd@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240610142836.168603-3-afd@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_231550_424672_6877F954 X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Jun 10, 2024 at 09:28:34 -0500, Andrew Davis wrote: > Simplify probe by fetching the regmap and its arguments in one call. > > Signed-off-by: Andrew Davis > --- > drivers/power/reset/brcmstb-reboot.c | 22 ++++------------------ > 1 file changed, 4 insertions(+), 18 deletions(-) > > diff --git a/drivers/power/reset/brcmstb-reboot.c b/drivers/power/reset/brcmstb-reboot.c > index db5b7120eadd0..94ea317f61ef4 100644 > --- a/drivers/power/reset/brcmstb-reboot.c > +++ b/drivers/power/reset/brcmstb-reboot.c > @@ -18,9 +18,6 @@ > #include > #include > > -#define RESET_SOURCE_ENABLE_REG 1 > -#define SW_MASTER_RESET_REG 2 > - > static struct regmap *regmap; > static u32 rst_src_en; > static u32 sw_mstr_rst; > @@ -87,6 +84,7 @@ static int brcmstb_reboot_probe(struct platform_device *pdev) > { > int rc; > struct device_node *np = pdev->dev.of_node; > + unsigned int args[2]; You can also call it syscon_args, but I'm fine either way. > > reset_masks = device_get_match_data(&pdev->dev); > if (!reset_masks) { > @@ -94,25 +92,13 @@ static int brcmstb_reboot_probe(struct platform_device *pdev) > return -EINVAL; > } > > - regmap = syscon_regmap_lookup_by_phandle(np, "syscon"); > + regmap = syscon_regmap_lookup_by_phandle_args(np, "syscon", 2, args); > if (IS_ERR(regmap)) { > pr_err("failed to get syscon phandle\n"); > return -EINVAL; > } > - > - rc = of_property_read_u32_index(np, "syscon", RESET_SOURCE_ENABLE_REG, > - &rst_src_en); > - if (rc) { > - pr_err("can't get rst_src_en offset (%d)\n", rc); > - return -EINVAL; > - } > - > - rc = of_property_read_u32_index(np, "syscon", SW_MASTER_RESET_REG, > - &sw_mstr_rst); > - if (rc) { > - pr_err("can't get sw_mstr_rst offset (%d)\n", rc); > - return -EINVAL; > - } > + rst_src_en = args[0]; > + sw_mstr_rst = args[1]; Reviewed-by: Dhruva Gole -- Best regards, Dhruva _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel