From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B129C25B76 for ; Tue, 11 Jun 2024 06:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L6GhtUoV31F/DMpHOAeg/gn3VwKk4JqzdI5PdcDaJnw=; b=I98ly5dry7NlCw zYeCoZ3SgA6A9TYQgrT6Gtu27SU9cTZdq0qydxRlaAkn3wIdLVWEnCCqeuE/overRMZLdMqIwuTgI VVrbwuzFmy7CuIMZRsbelIkh4eq1jKTNXbirmZU2o3vdrDOBAWYcz2JKFmbMyCbGLHbGam9Zx5GRj gY/4nbDF9dOc+TgvJw/7z7g9He0580OHViffNGqdyFuivRaR5KZq7mA10fYH4l8eTg0FE1gjlwX1V No1DPMDq2XFKAWFAM3cNwmPdsYId6eqODMyv6X27RE/FSrbaTVHkW48O8kI4zca+veJ1a9MWjiVCi Ks7FDaykOLDb83ErobrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGust-00000007fQT-0o3k; Tue, 11 Jun 2024 06:21:31 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGusY-00000007fHu-38G4 for linux-arm-kernel@lists.infradead.org; Tue, 11 Jun 2024 06:21:29 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 45B6L4gX126284; Tue, 11 Jun 2024 01:21:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1718086864; bh=CP+LDdPyvvolLB5E7oanQuL7LYswwkSefkdI+mxK7sA=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=dUSA/8OcxlFnu1uvIxYLxrjjFdJspH3GiAkjgxm+/kKM93I9AnPU5/71ab8pqJnvy KLB6/bMkcskPcff+lhPDHYLqK2zNJ750UHRTHgXtogv6tMoF9JuiYPFX30/6Ob4w+e mPyIJl/H5DSmfd111XhCyNeNkPnBAoRWsi9xKhSc= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 45B6L46g032093 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 11 Jun 2024 01:21:04 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 11 Jun 2024 01:21:03 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 11 Jun 2024 01:21:04 -0500 Received: from localhost (dhruva.dhcp.ti.com [172.24.227.68]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 45B6L3Tj069287; Tue, 11 Jun 2024 01:21:03 -0500 Date: Tue, 11 Jun 2024 11:51:02 +0530 From: Dhruva Gole To: Andrew Davis CC: Sebastian Reichel , Florian Fainelli , Broadcom internal kernel review list , , , Subject: Re: [PATCH 5/5] power: reset: brcmstb: Do not go into infinite loop if reset fails Message-ID: <20240611062102.ez66rcvf4d464oqz@dhruva> References: <20240610142836.168603-1-afd@ti.com> <20240610142836.168603-5-afd@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240610142836.168603-5-afd@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_232111_069216_2606B5F8 X-CRM114-Status: GOOD ( 15.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Jun 10, 2024 at 09:28:36 -0500, Andrew Davis wrote: > There may be other backup reset methods available, do not halt > here so that other reset methods can be tried. > > Signed-off-by: Andrew Davis > --- > drivers/power/reset/brcmstb-reboot.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/power/reset/brcmstb-reboot.c b/drivers/power/reset/brcmstb-reboot.c > index 59ed1513cfb30..441b44e0a9f29 100644 > --- a/drivers/power/reset/brcmstb-reboot.c > +++ b/drivers/power/reset/brcmstb-reboot.c > @@ -58,9 +58,6 @@ static int brcmstb_restart_handler(struct sys_off_data *data) > return NOTIFY_DONE; > } > > - while (1) > - ; > - I agree, while (1) may not be the best thing to do here. Reviewed-by: Dhruva Gole -- Best regards, Dhruva _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel