From: Greg KH <gregkh@linuxfoundation.org>
To: Jacky Huang <ychuang570808@gmail.com>
Cc: dan.carpenter@linaro.org, jirislaby@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jacky Huang <ychuang3@nuvoton.com>
Subject: Re: [PATCH] tty: serial: ma35d1: Add a NULL check for of_node
Date: Tue, 11 Jun 2024 13:11:28 +0200 [thread overview]
Message-ID: <2024061118-sycamore-leggings-05a9@gregkh> (raw)
In-Reply-To: <20240611092251.159149-1-ychuang570808@gmail.com>
On Tue, Jun 11, 2024 at 09:22:51AM +0000, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@nuvoton.com>
>
> The pdev->dev.of_node can be NULL if the "serial" node is absent.
> Add a NULL check to return an error in such cases.
>
> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
> ---
> drivers/tty/serial/ma35d1_serial.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c
> index 19f0a305cc43..3b4206e815fe 100644
> --- a/drivers/tty/serial/ma35d1_serial.c
> +++ b/drivers/tty/serial/ma35d1_serial.c
> @@ -688,12 +688,13 @@ static int ma35d1serial_probe(struct platform_device *pdev)
> struct uart_ma35d1_port *up;
> int ret = 0;
>
> - if (pdev->dev.of_node) {
> - ret = of_alias_get_id(pdev->dev.of_node, "serial");
> - if (ret < 0) {
> - dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret);
> - return ret;
> - }
> + if (!pdev->dev.of_node)
> + return -ENODEV;
> +
> + ret = of_alias_get_id(pdev->dev.of_node, "serial");
> + if (ret < 0) {
> + dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret);
> + return ret;
> }
> up = &ma35d1serial_ports[ret];
> up->port.line = ret;
What commit id does this fix?
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-06-11 11:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 9:22 [PATCH] tty: serial: ma35d1: Add a NULL check for of_node Jacky Huang
2024-06-11 11:11 ` Greg KH [this message]
2024-06-12 0:43 ` Jacky Huang
2024-06-12 7:23 ` Greg KH
2024-06-13 2:54 ` Jacky Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024061118-sycamore-leggings-05a9@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ychuang3@nuvoton.com \
--cc=ychuang570808@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox