From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 792C9C27C75 for ; Tue, 11 Jun 2024 21:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gja6B9TGACnXdIlN4JcI0JsSBHbvPVxHbJQIgM1sCuw=; b=Rvsl6e6JAXuWNa8rISgsi6BDqB MjpUr5bDmc0pOC9luaZlkLJdtR9rpMw2zhGvPy1KTdjmoklM+07krclDhMBa+MbrTQzIPghJ9+xdl Ibb7ecvG3YzB5qS3hXHeBAujPA++IHLLBPZZnKqxsk8xq++aMFVtAVR+uxQN7TKncpmRGe6iZFvy3 /Booe8SbiIfMx4rm0cyp/NJb87+DOoo6TdP/rY6M9ec9bGVFV1/5LWDwHh750QlPhRreuq7WaPQqq SPm+Yorpe8An4sZ6zDAuhRsIMfjGbiV/PohVye67tFlce7zYbXPpZlBX/mCRYCvzSiKbI9l/BfEK4 XX4GU+/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sH906-0000000AHFr-3TXa; Tue, 11 Jun 2024 21:25:54 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sH903-0000000AHF9-0gYH for linux-arm-kernel@lists.infradead.org; Tue, 11 Jun 2024 21:25:52 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F1A49512; Tue, 11 Jun 2024 23:25:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1718141137; bh=PJx9c38KWj7AAwOnRB6KVIEEYvCT18jAmmiFIEns1EA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aRALIufb0KpSwRKk962z4w71QI7/qZiEjOOKWPfZUN7DUwTVJa71B28CMQbM+lNbF RrmRazb1mwIzGFNVsbDUpc6ZkmORHVCKfPKW6jLrMcP3ELosdSlFINF3KdeOXYn9kD fWfWwx198dScWwlTpccCUZpngxQGoB3lIe06SV+E= Date: Wed, 12 Jun 2024 00:25:30 +0300 From: Laurent Pinchart To: Stefan Wahren Cc: Greg Kroah-Hartman , Florian Fainelli , Umang Jain , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2 09/10] staging: vchiq_arm: Don't cast scatter-gather elements Message-ID: <20240611212530.GH10397@pendragon.ideasonboard.com> References: <20240610210220.95524-1-wahrenst@gmx.net> <20240610210220.95524-10-wahrenst@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240610210220.95524-10-wahrenst@gmx.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240611_142551_385182_50D1E507 X-CRM114-Status: GOOD ( 15.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, Thank you for the patch. On Mon, Jun 10, 2024 at 11:02:19PM +0200, Stefan Wahren wrote: > The kernel uses different types for DMA length & address, > so better use them. > > Signed-off-by: Stefan Wahren Reviewed-by: Laurent Pinchart > --- > .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index 706bfc7a0b90..02392073c4aa 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -162,7 +162,7 @@ cleanup_pagelistinfo(struct vchiq_instance *instance, struct vchiq_pagelist_info > } > > static inline bool > -is_adjacent_block(u32 *addrs, u32 addr, unsigned int k) > +is_adjacent_block(u32 *addrs, dma_addr_t addr, unsigned int k) > { > u32 tmp; > > @@ -377,8 +377,8 @@ create_pagelist(struct vchiq_instance *instance, char *buf, char __user *ubuf, > /* Combine adjacent blocks for performance */ > k = 0; > for_each_sg(scatterlist, sg, dma_buffers, i) { > - u32 len = sg_dma_len(sg); > - u32 addr = sg_dma_address(sg); > + unsigned int len = sg_dma_len(sg); > + dma_addr_t addr = sg_dma_address(sg); > > /* Note: addrs is the address + page_count - 1 > * The firmware expects blocks after the first to be page- -- Regards, Laurent Pinchart