From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C16E3C27C77 for ; Wed, 12 Jun 2024 14:42:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bgh2Hqh4z3NY3Anx1gpI1WytIsuTQd5xShdpQXhF2Mg=; b=pu4nE9A99Z1e+T2DBL3Ww2M/1r mpyc+NBHM1YRKMZFR230x09f7H+JAFplvo/pAlvv/UdGtxwsESqAjuYK8n/boNq+NT2j4QgHgORmG XIwPv/kqCCPS0bpnunAf+ATkEuxLGSZtX1AX12tjUpo4Kgxw3Yav3SPHkNfx2R412J7cF+iywS4sE lMONYBEd30X48jVpH7pHMGhu+95+ems/odWS6m8x9RLpgbadGAM7SdjHEwZI9l6Qng21ZpHLoRWKy B6jyEmhlPzIzUw9eQGHO3HU4YpXeus5uJSQkdZOWdmaZ3+1eGBkoMoVufvp1w9Ro6IwwWl8Wfd3/H 3u2EwjJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHPBH-0000000CzXP-1zyV; Wed, 12 Jun 2024 14:42:31 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHPBC-0000000CzTp-0tRQ for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2024 14:42:29 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D06CDCE0C2F; Wed, 12 Jun 2024 14:42:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C34FC116B1; Wed, 12 Jun 2024 14:42:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718203342; bh=fIyHMCmdFag/kreazotdgSfqaaLxX6azOoYs64Naiq8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2r7wGhybYveJ0OLks02tsdo8uWtqpEFFUrtDCrsXCKYC1H7xvfiNjkI9VxsQ345hk TJKFXsJYUE9xA7aEoZdI9C2Va7O2R3Yd0hrKq8OC0ZkL3c5HWp82SMRze2saG2/DHQ icYL9JmNEzpNy+dkQ2CDZOVDP7TwVbPDBXqoCCAs= Date: Wed, 12 Jun 2024 16:42:20 +0200 From: Greg KH To: Linux regressions mailing list Cc: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= , Frank Oltmanns , stable@vger.kernel.org, Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Guido =?iso-8859-1?Q?G=FCnther?= , Purism Kernel Team , Ondrej Jirman , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 1/5] clk: sunxi-ng: common: Support minimum and maximum rate Message-ID: <2024061208-trapping-diminish-fda6@gregkh> References: <20240310-pinephone-pll-fixes-v4-0-46fc80c83637@oltmanns.dev> <20240310-pinephone-pll-fixes-v4-1-46fc80c83637@oltmanns.dev> <8be80682-067a-4685-9830-cfed0287e617@leemhuis.info> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8be80682-067a-4685-9830-cfed0287e617@leemhuis.info> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240612_074226_668674_9922E108 X-CRM114-Status: GOOD ( 20.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 12, 2024 at 03:28:01PM +0200, Linux regression tracking (Thorsten Leemhuis) wrote: > On 23.05.24 20:58, Måns Rullgård wrote: > > Måns Rullgård writes: > >> Frank Oltmanns writes: > >>> 21.05.2024 15:43:10 Måns Rullgård : > >>>> Frank Oltmanns writes: > >>>> > >>>>> The Allwinner SoC's typically have an upper and lower limit for their > >>>>> clocks' rates. Up until now, support for that has been implemented > >>>>> separately for each clock type. > >>>>> > >>>>> Implement that functionality in the sunxi-ng's common part making use of > >>>>> the CCF rate liming capabilities, so that it is available for all clock > >>>>> types. > >>>>> > >>>>> Suggested-by: Maxime Ripard > >>>>> Signed-off-by: Frank Oltmanns > >>>>> Cc: stable@vger.kernel.org > >>>>> --- > >>>>> drivers/clk/sunxi-ng/ccu_common.c | 19 +++++++++++++++++++ > >>>>> drivers/clk/sunxi-ng/ccu_common.h |  3 +++ > >>>>> 2 files changed, 22 insertions(+) > >>>> > >>>> This just landed in 6.6 stable, and it broke HDMI output on an A20 based > >>>> device, the clocks ending up all wrong as seen in this diff of > >>>> /sys/kernel/debug/clk/clk_summary: > > [...] > > > >>>> Reverting this commit makes it work again. > >>> Thank you for your detailed report! > > [...] > > It turns out HDMI output is broken in v6.9 for a different reason. > > However, this commit (b914ec33b391 clk: sunxi-ng: common: Support > > minimum and maximum rate) requires two others as well in order not > > to break things on the A20: > > > > cedb7dd193f6 drm/sun4i: hdmi: Convert encoder to atomic > > 9ca6bc246035 drm/sun4i: hdmi: Move mode_set into enable > > > > With those two (the second depends on the first) cherry-picked on top of > > v6.6.31, the HDMI output is working again. Likewise on v6.8.10. > > They from what I can see are not yet in 6.6.y or on their way there (6.8 > is EOL now). Did anyone ask Greg to pick this up? If not: Månsm could > you maybe do that? CCing him on a reply and asking is likely enough if > both changes apply cleanly. Both now queued up, thanks. greg k-h