From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5B85C27C4F for ; Fri, 14 Jun 2024 01:18:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JkEkW+3sCSycHe6JuHQ8j6MCKpBEQNJITqNSFUIVlv8=; b=YFZCO9XLPgdLp50tVyYRrlnEeO 1haBovmEW0TMvfX9XpximS54GqgS4Bvx+C6pH/7ylgt0QnTw4TA6L2yby1gxKh+cm5xXgiNjJSx+w IQH6Sj6NQqv19ZnIQkQOaBAQXmsW0O9fkuswo3ll6nfpHrFeews69BOh95Zw052bkrA3ENlKDrTUV Hy0aRf0IoND2juZEB/T4Latqg8UNf2VCKK8nQYqhZAChhGhKU4BbNfCoRYse1rpSMl8ZRBdsnqPdL slIPEugIMYu+QdXpBlUzkU3rWO1yd0WqijRRpWZAsuPF9p4qUzUNqnyNI9k4izoB6/PaBrvHxtbpP 3v4CzWrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHva7-00000000yfV-3QJp; Fri, 14 Jun 2024 01:18:19 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHva3-00000000yex-43Ez for linux-arm-kernel@lists.infradead.org; Fri, 14 Jun 2024 01:18:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 236DD61821; Fri, 14 Jun 2024 01:18:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CE72C2BBFC; Fri, 14 Jun 2024 01:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718327894; bh=mgyOAziEuF5dLoY3SVasa/F54zKNQeGUaNP4KbuGUY4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=s1Ta7p4A4luCkj5qnPlasVhv+/Gg3eidQjjiELWr1vIgCQ2GEElJxlBsKXYji0rd+ FMhle+qqBxCo39gDdg/MJFSfnJ9VQD8iKv+c3kY2RmnPkKQiWx3Ru53tK9wqybpFhi 9eu0cbPkTzJdmR/+WEideu4BWXkzz5gN0YPW2a6Zw3jsvHvZbtr87eQ+TeOeymWbQm G38vGvjT9CXKcocFRUxbPl1t4xIwxHbQ7zatTnYYw1lbbE8eTOdDNb+JUFA2tfvje2 yUsyedtNqFR214FM/UlEK+r5w6yVVFmxkxwNI2DtI/2TqfbxAJEwVlfaOuoilI+rIT JEmJsRXCyTgxw== Date: Thu, 13 Jun 2024 18:18:12 -0700 From: Jakub Kicinski To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart Subject: Re: [PATCH net-next v13 07/13] net: ethtool: Introduce a command to list PHYs on an interface Message-ID: <20240613181812.27d02c88@kernel.org> In-Reply-To: <20240607071836.911403-8-maxime.chevallier@bootlin.com> References: <20240607071836.911403-1-maxime.chevallier@bootlin.com> <20240607071836.911403-8-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240613_181816_096383_DA879CB3 X-CRM114-Status: GOOD ( 11.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 7 Jun 2024 09:18:20 +0200 Maxime Chevallier wrote: > + it's parent PHY through = an SFP its > +static int ethnl_phy_parse_request(struct ethnl_req_info *req_base, > + struct nlattr **tb) > +{ > + struct phy_link_topology *topo =3D req_base->dev->link_topo; > + struct phy_req_info *req_info =3D PHY_REQINFO(req_base); > + struct phy_device_node *pdn; > + > + if (!req_base->phydev) > + return 0; > + > + if (!topo) > + return 0; > + > + pdn =3D xa_load(&topo->phys, req_base->phydev->phyindex); > + memcpy(&req_info->pdn, pdn, sizeof(*pdn)); > + xa_for_each_start(&dev->link_topo->phys, ctx->phy_index, pdn, ctx->phy_= index) { > + ehdr =3D ethnl_dump_put(skb, cb, ETHTOOL_MSG_PHY_GET_REPLY); > + if (!ehdr) { > + ret =3D -EMSGSIZE; > + break; > + } > + > + ret =3D ethnl_fill_reply_header(skb, dev, ETHTOOL_A_PHY_HEADER); > + if (ret < 0) { > + genlmsg_cancel(skb, ehdr); > + break; > + } > + > + memcpy(&pri->pdn, pdn, sizeof(*pdn)); Why do you copy the pdn each time =F0=9F=A4=94=EF=B8=8F > + return ret; > +} > + double new line at the end