From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72AFAC27C4F for ; Thu, 13 Jun 2024 10:03:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G8t/dnyOSvvCj7CMC4JsxPThuNOee3PY/Ww/fnwxEpA=; b=QmhJ9SeAYTAsf+2emhaKebudl3 cXMxt+8QWILHEVzRxB7GNhSg9/1kUxEQu99DpUSfUQyjh/BuvomadJQdB3tRUfBc9dVWqNolujNAR oH/eIZQ4WUhhsZ4ypLpYMIir4JF/trmUNYUVyIHliZ1DP5ANYIKAyfSe19G3Kr5EjZVZArNAlJe3H rHw7dLWpalj35zkA7uAj567M9U8YfiuPFwcvCE7SQ0eDdNIE+SL6ui0Kor+JEU1F3vyjzwzGnY/le TRUPJJ6RUaZSVFuG2QAGEwK3HIr2/+EPejBIhmzetZwrr0q4d1bmrKhPSM8jyvruLjm2PFrm5x246 JeQn8aWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHhIW-0000000G4Po-2wzK; Thu, 13 Jun 2024 10:03:12 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHhIT-0000000G4OM-2iv5 for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2024 10:03:11 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 840E6CE24B3; Thu, 13 Jun 2024 10:03:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18679C2BBFC; Thu, 13 Jun 2024 10:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718272986; bh=CqHO2/KK7eIKe3EFoA4TtHPEMTMPdLClBxAJ4UmrvLg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NqNPZhTJEpyCvzXfGU5AnNh2gavLMwsYzQ5eTYx5mLDPdSSIqSRAKZLJPIpCHaYJR ZbGmNlNWp/ql5XfAGCsjaIZewR5YWdNBQPF/JbE+b4CeU2YsQUlvxT4PItgpgWF4TL CUhzvnxOEk/9SvVUdnWqARHGMUiC0hjz2Vn2kezE= Date: Thu, 13 Jun 2024 12:03:03 +0200 From: Greg Kroah-Hartman To: Peter Zijlstra Cc: Boqun Feng , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, llvm@lists.linux.dev, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Alan Stern , Andrea Parri , Will Deacon , Nicholas Piggin , David Howells , Jade Alglave , Luc Maranget , "Paul E. McKenney" , Akira Yokosawa , Daniel Lustig , Joel Fernandes , Nathan Chancellor , Nick Desaulniers , kent.overstreet@gmail.com, elver@google.com, Mark Rutland , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Catalin Marinas , torvalds@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, Trevor Gross , dakr@redhat.com Subject: Re: [RFC 1/2] rust: Introduce atomic API helpers Message-ID: <2024061353-stillness-unearned-dc4f@gregkh> References: <20240612223025.1158537-1-boqun.feng@gmail.com> <20240612223025.1158537-2-boqun.feng@gmail.com> <2024061341-whole-snowfall-89a6@gregkh> <20240613091747.GB17707@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240613091747.GB17707@noisy.programming.kicks-ass.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240613_030309_874475_CDA0A2B6 X-CRM114-Status: GOOD ( 18.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 13, 2024 at 11:17:47AM +0200, Peter Zijlstra wrote: > On Thu, Jun 13, 2024 at 07:38:51AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Jun 12, 2024 at 03:30:24PM -0700, Boqun Feng wrote: > > > +// Generated by scripts/atomic/gen-rust-atomic-helpers.sh > > > +// DO NOT MODIFY THIS FILE DIRECTLY > > > > Why not just build this at build time and not check the file into the > > tree if it is always automatically generated? That way it never gets > > out of sync. We do this for other types of auto-generated files in the > > kernel today already. > > Part of the problem is, is that a *TON* of files depend on the atomic.h > headers. If we'd generate it on every build, you'd basically get to > rebuild the whole kernel every single time. > > Also, these files don't change too often. And if you look, there's a > hash in those files which is used to check if things somehow got stale. Ok, fair enough, if you all don't think this will change often...