From: Shivamurthy Shastri <shivamurthy.shastri@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
maz@kernel.org, tglx@linutronix.de, anna-maria@linutronix.de,
shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
bhelgaas@google.com, rdunlap@infradead.org, vidyas@nvidia.com,
ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com,
kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp,
andrew@lunn.ch, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org,
rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org,
lorenzo.pieralisi@arm.com, jgg@mellanox.com,
ammarfaizi2@gnuweeb.org, robin.murphy@arm.com,
lpieralisi@kernel.org, nm@ti.com, kristo@kernel.org,
vkoul@kernel.org, okaya@kernel.org, agross@kernel.org,
andersson@kernel.org, mark.rutland@arm.com,
shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com,
shivamurthy.shastri@linutronix.de
Subject: [PATCH v3 05/24] irqchip/gic-v3-its: Provide MSI parent infrastructure
Date: Fri, 14 Jun 2024 12:23:44 +0200 [thread overview]
Message-ID: <20240614102403.13610-6-shivamurthy.shastri@linutronix.de> (raw)
In-Reply-To: <20240614102403.13610-1-shivamurthy.shastri@linutronix.de>
From: Thomas Gleixner <tglx@linutronix.de>
To support per device MSI domains the ITS must provide MSI parent domain
functionality.
Provide the basic skeleton for this:
- msi_parent_ops
- child domain init callback
- the MSI parent flag set in irqdomain::flags
This does not make ITS a functional parent domain as there is no bit set in
the bus_select_mask yet, but it provides the base to implement PCI and
platform MSI support gradually on top.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
Signed-off-by: Shivamurthy Shastri <shivamurthy.shastri@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <maz@kernel.org>
---
v3: enabled MSI_FLAG_PCI_MSI_MASK_PARENT in msi_parent_ops::supported_flags
---
drivers/irqchip/Kconfig | 1 +
drivers/irqchip/Makefile | 2 +-
drivers/irqchip/irq-gic-common.h | 3 ++
drivers/irqchip/irq-gic-v3-its-msi-parent.c | 31 +++++++++++++++++++++
drivers/irqchip/irq-gic-v3-its.c | 5 ++++
5 files changed, 41 insertions(+), 1 deletion(-)
create mode 100644 drivers/irqchip/irq-gic-v3-its-msi-parent.c
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 2bf8d940504c..b51863fa9b38 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -41,6 +41,7 @@ config ARM_GIC_V3
config ARM_GIC_V3_ITS
bool
select GENERIC_MSI_IRQ
+ select IRQ_MSI_LIB
default ARM_GIC_V3
config ARM_GIC_V3_ITS_PCI
diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index 72c7f6289411..6e4f7715206d 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile
@@ -32,7 +32,7 @@ obj-$(CONFIG_ARCH_REALVIEW) += irq-gic-realview.o
obj-$(CONFIG_IRQ_MSI_LIB) += irq-msi-lib.o
obj-$(CONFIG_ARM_GIC_V2M) += irq-gic-v2m.o
obj-$(CONFIG_ARM_GIC_V3) += irq-gic-v3.o irq-gic-v3-mbi.o irq-gic-common.o
-obj-$(CONFIG_ARM_GIC_V3_ITS) += irq-gic-v3-its.o irq-gic-v3-its-platform-msi.o irq-gic-v4.o
+obj-$(CONFIG_ARM_GIC_V3_ITS) += irq-gic-v3-its.o irq-gic-v3-its-platform-msi.o irq-gic-v4.o irq-gic-v3-its-msi-parent.o
obj-$(CONFIG_ARM_GIC_V3_ITS_PCI) += irq-gic-v3-its-pci-msi.o
obj-$(CONFIG_ARM_GIC_V3_ITS_FSL_MC) += irq-gic-v3-its-fsl-mc-msi.o
obj-$(CONFIG_PARTITION_PERCPU) += irq-partition-percpu.o
diff --git a/drivers/irqchip/irq-gic-common.h b/drivers/irqchip/irq-gic-common.h
index f407cce9ecaa..eb4a220dd6ad 100644
--- a/drivers/irqchip/irq-gic-common.h
+++ b/drivers/irqchip/irq-gic-common.h
@@ -8,6 +8,7 @@
#include <linux/of.h>
#include <linux/irqdomain.h>
+#include <linux/msi.h>
#include <linux/irqchip/arm-gic-common.h>
struct gic_quirk {
@@ -29,6 +30,8 @@ void gic_enable_quirks(u32 iidr, const struct gic_quirk *quirks,
void gic_enable_of_quirks(const struct device_node *np,
const struct gic_quirk *quirks, void *data);
+extern const struct msi_parent_ops gic_v3_its_msi_parent_ops;
+
#define RDIST_FLAGS_PROPBASE_NEEDS_FLUSHING (1 << 0)
#define RDIST_FLAGS_RD_TABLES_PREALLOCATED (1 << 1)
#define RDIST_FLAGS_FORCE_NON_SHAREABLE (1 << 2)
diff --git a/drivers/irqchip/irq-gic-v3-its-msi-parent.c b/drivers/irqchip/irq-gic-v3-its-msi-parent.c
new file mode 100644
index 000000000000..cdc0844229b5
--- /dev/null
+++ b/drivers/irqchip/irq-gic-v3-its-msi-parent.c
@@ -0,0 +1,31 @@
+// SPDX-License-Identifier: GPL-2.0-only
+// Copyright (C) 2022 Linutronix GmbH
+// Copyright (C) 2022 Intel
+
+#include "irq-gic-common.h"
+#include "irq-msi-lib.h"
+
+#define ITS_MSI_FLAGS_REQUIRED (MSI_FLAG_USE_DEF_DOM_OPS | \
+ MSI_FLAG_USE_DEF_CHIP_OPS)
+
+#define ITS_MSI_FLAGS_SUPPORTED (MSI_GENERIC_FLAGS_MASK | \
+ MSI_FLAG_PCI_MSIX | \
+ MSI_FLAG_MULTI_PCI_MSI | \
+ MSI_FLAG_PCI_MSI_MASK_PARENT)
+
+static bool its_init_dev_msi_info(struct device *dev, struct irq_domain *domain,
+ struct irq_domain *real_parent, struct msi_domain_info *info)
+{
+ if (!msi_lib_init_dev_msi_info(dev, domain, real_parent, info))
+ return false;
+
+ return true;
+}
+
+const struct msi_parent_ops gic_v3_its_msi_parent_ops = {
+ .supported_flags = ITS_MSI_FLAGS_SUPPORTED,
+ .required_flags = ITS_MSI_FLAGS_REQUIRED,
+ .bus_select_token = DOMAIN_BUS_NEXUS,
+ .prefix = "ITS-",
+ .init_dev_msi_info = its_init_dev_msi_info,
+};
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index 3c755d5dad6e..d770d6aedb29 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -38,6 +38,7 @@
#include <asm/exception.h>
#include "irq-gic-common.h"
+#include "irq-msi-lib.h"
#define ITS_FLAGS_CMDQ_NEEDS_FLUSHING (1ULL << 0)
#define ITS_FLAGS_WORKAROUND_CAVIUM_22375 (1ULL << 1)
@@ -3688,6 +3689,7 @@ static void its_irq_domain_free(struct irq_domain *domain, unsigned int virq,
}
static const struct irq_domain_ops its_domain_ops = {
+ .select = msi_lib_irq_domain_select,
.alloc = its_irq_domain_alloc,
.free = its_irq_domain_free,
.activate = its_irq_domain_activate,
@@ -4993,6 +4995,9 @@ static int its_init_domain(struct its_node *its)
irq_domain_update_bus_token(inner_domain, DOMAIN_BUS_NEXUS);
+ inner_domain->msi_parent_ops = &gic_v3_its_msi_parent_ops;
+ inner_domain->flags |= IRQ_DOMAIN_FLAG_MSI_PARENT;
+
return 0;
}
--
2.34.1
next prev parent reply other threads:[~2024-06-14 11:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 10:23 [PATCH v3 00/24] genirq, irqchip: Convert ARM MSI handling to Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 01/24] irqdomain: Fix formatting irq_find_matching_fwspec() kerneldoc comment Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 02/24] irqchip/imx-mu-msi: Fix codingstyle in imx_mu_msi_domains_init() Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 03/24] PCI/MSI: Provide MSI_FLAG_PCI_MSI_MASK_PARENT Shivamurthy Shastri
2024-06-14 16:09 ` Bjorn Helgaas
2024-06-17 12:52 ` Thomas Gleixner
2024-06-14 10:23 ` [PATCH v3 04/24] irqchip: Provide irq-msi-lib Shivamurthy Shastri
2024-06-14 10:23 ` Shivamurthy Shastri [this message]
2024-06-14 10:23 ` [PATCH v3 06/24] irqchip/irq-msi-lib: Prepare for PCI MSI/MSIX Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 07/24] irqchip/gic-v3-its: Provide MSI parent for PCI/MSI[-X] Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 08/24] irqchip/irq-msi-lib: Prepare for DEVICE MSI to replace platform MSI Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 09/24] irqchip/mbigen: Prepare for real per device MSI Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 10/24] irqchip/irq-msi-lib: Prepare for DOMAIN_BUS_WIRED_TO_MSI Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 11/24] irqchip/gic-v3-its: Switch platform MSI to MSI parent Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 12/24] irqchip/mbigen: Remove platform_msi_create_device_domain() fallback Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 13/24] genirq/msi: Remove platform_msi_create_device_domain() Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 14/24] genirq/gic-v3-mbi: Remove unused wired MSI mechanics Shivamurthy Shastri
2024-06-15 17:24 ` Marc Zyngier
2024-06-17 12:55 ` Thomas Gleixner
2024-06-17 13:03 ` Marc Zyngier
2024-06-17 14:02 ` Thomas Gleixner
2024-06-17 14:15 ` Thomas Gleixner
2024-06-21 14:04 ` Thomas Gleixner
2024-06-23 11:26 ` Thomas Gleixner
2024-06-25 7:37 ` Marc Zyngier
2024-06-25 7:47 ` Thomas Gleixner
2024-06-14 10:23 ` [PATCH v3 15/24] genirq/gic-v3-mbi: Switch to MSI parent Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 16/24] irqchip/gic-v2m: Switch to device MSI Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 17/24] irqchip/imx-mu-msi: Switch to MSI parent Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 18/24] irqchip/irq-mvebu-icu: Prepare for real per device MSI Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 19/24] irqchip/mvebu-gicp: Switch to MSI parent Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 20/24] irqchip/mvebu-odmi: Switch to parent MSI Shivamurthy Shastri
2024-06-14 10:24 ` [PATCH v3 21/24] irqchip/irq-mvebu-sei: Switch to MSI parent Shivamurthy Shastri
2024-06-14 10:24 ` [PATCH v3 22/24] irqchip/irq-mvebu-icu: Remove platform MSI leftovers Shivamurthy Shastri
2024-06-14 10:24 ` [PATCH v3 23/24] genirq/msi: " Shivamurthy Shastri
2024-06-14 10:24 ` [PATCH v3 24/24] genirq/msi: Move msi_device_data to core Shivamurthy Shastri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614102403.13610-6-shivamurthy.shastri@linutronix.de \
--to=shivamurthy.shastri@linutronix.de \
--cc=agross@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=ammarfaizi2@gnuweeb.org \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=anna-maria@linutronix.de \
--cc=apatel@ventanamicro.com \
--cc=bhelgaas@google.com \
--cc=den@valinux.co.jp \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jgg@mellanox.com \
--cc=kevin.tian@intel.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=nipun.gupta@amd.com \
--cc=nm@ti.com \
--cc=okaya@kernel.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=robin.murphy@arm.com \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=vidyas@nvidia.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).