From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 232D6C27C6E for ; Fri, 14 Jun 2024 06:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jdE2B23F+tJcjPtFeOhi9fdYtlsfAZupJf6xWSNLSTA=; b=GoyTE3FOCm4d5im+NyZNwn8Vtm tFODcTLojQzYGMpGOMq3H1v+NECdV7ST6SF12+mKS0UT2uSQjwDo6ShJHR/BHhaVwtOXFCCYlOeRo dKCk/p7ocvWro12DkIfJsFXOvYj9Y5DeNNxwVLSehkwQzZh32kXWfs749r3+xRjlugaSbjgSFXG3d dKaErgcbaEfJmkMJziwwsfy5OqOtjF2Ao47/AwPOL/MyIuEr1iJ2Y46wYvcArFcCkvkdLWOsma2uS J5II76hQwJBjnDjZYpZLlv9owsHgvOtNgfwo1687ZlfHk1rETE6EgboeC8kMtpEmW44VxgRddCeKv WC6HD9qw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sI0lN-00000001g55-2coJ; Fri, 14 Jun 2024 06:50:17 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sI0lL-00000001g4R-0769; Fri, 14 Jun 2024 06:50:16 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E7743CE290F; Fri, 14 Jun 2024 06:50:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D805C2BD10; Fri, 14 Jun 2024 06:50:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718347811; bh=jt9YTgTk6SZvNJvRMAeqZX4LPxGTdXb5HZRZ4VuwGRQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GzXnHHU7+MuXoJt0yt/sVJkev7OLM4Sogl9iiK1QoSRWdYYj62Q3bFIImEeJoBP24 pjt0m9cNY6tWDwyIs8gu5y+Vbdg4veRGgtLdk/setNt/L6T6P1ox3Gzp6rgq7NrN9P CAZGYG6atDRhLOKzYiHjVY6hULqw2Yfh7lGAfpHA= Date: Fri, 14 Jun 2024 08:50:08 +0200 From: Greg Kroah-Hartman To: Kieran Bingham Cc: Umang Jain , Florian Fainelli , linux-rpi-kernel@lists.infradead.org, Broadcom internal kernel review list , Stefan Wahren , Laurent Pinchart , Dave Stevenson , detule , Dan Carpenter , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:STAGING SUBSYSTEM" , open list Subject: Re: [PATCH] staging: vc04_services: vchiq_arm: Fix initialisation check Message-ID: <2024061436-twister-survival-a05c@gregkh> References: <20240613194150.2915202-1-kieran.bingham@ideasonboard.com> <20240613194150.2915202-2-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240613194150.2915202-2-kieran.bingham@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240613_235015_343080_CCFA6956 X-CRM114-Status: GOOD ( 14.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 13, 2024 at 08:41:46PM +0100, Kieran Bingham wrote: > The vchiq_state used to be obtained through an accessor > which would validate that the VCHIQ had been initialised > correctly with the remote. > > In commit 42a2f6664e18 ("staging: vc04_services: Move global g_state to > vchiq_state") the global state was moved to the vchiq_mgnt structures > stored as a vchiq instance specific context. This conversion removed the > helpers and instead replaced users of this helper with the assumption > that the state is always available and the remote connected. > > Fix this broken assumption by re-introducing the logic that was lost > during the conversion. > > Fixes: 42a2f6664e18 ("staging: vc04_services: Move global g_state to vchiq_state") > Signed-off-by: Kieran Bingham > --- > .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++-- > .../staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 5 +++++ > .../staging/vc04_services/interface/vchiq_arm/vchiq_dev.c | 7 ++++++- > 3 files changed, 13 insertions(+), 3 deletions(-) You sent 2 different patches here, both with the same subject, which one is correct? Please send a v2 so that I know what to apply, I've dropped this one from my queue now, thanks. greg k-h