From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39A4BC27C4F for ; Sat, 15 Jun 2024 09:56:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=tg5u5ShuykptgMBL5I5DS/hZACOm+i1CYfL5BzH1+bY=; b=JqWvQZvkdBUUMbBJGS5yCGFAy/ 0h5Y3ljYMadXj7Qj3hWCXmk+b8LXjJsBOT6lwA/QF6nXkXIDgLphoaTBVvDj37vI0/kOcSTYlrYZS 4JfnzQo0uC+TLsjUfmkvyck5z7ORs5SW+2qkTlQXAUc/6Y+Y4iGT/l3rtkHmCWHxbi0i1RiNpy65g p9Z2nTB9bkbRjsL0/V8GplDoDN77uvLrBKabGpCkyTbXNoMpFeR3wBQpFyPGFP0XqmRByltpNPj+7 oUrecOsW87T1Vvhw537IGXi+ZI4VAr+4KbZt6Aryw746Y6Y1W6Q7sO3VHiaTlqo8s7tJRgcdNzfaa 8NUFSknw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sIQ99-00000005ADK-2Ibl; Sat, 15 Jun 2024 09:56:31 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sIQ95-00000005ACa-1rZl for linux-arm-kernel@lists.infradead.org; Sat, 15 Jun 2024 09:56:29 +0000 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-70109d34a16so2632337b3a.2 for ; Sat, 15 Jun 2024 02:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718445384; x=1719050184; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tg5u5ShuykptgMBL5I5DS/hZACOm+i1CYfL5BzH1+bY=; b=goSFMk4Jv3dAoRx5Xb9VRlpjUnhToZPoX9zzhIs0Q9EoCfNpmYLmSuKnF/+nWrLmGh XtPMhSBt9rQ+SkvLJwKARiCv+0Zm7B07sqMwoCet3iQCUBPoESly3C31rGdXVDpyqHmu RPe8uU3IlQwDxhM5c1JbYBnifMQ7GDwxon6cp+XCJouQuQzrYWrCyL4JRv+puj9SCZPm oAezOB4Shmqjf0AAFgDsOqwTh9hRGzMDeGlTrIzYc7+6mlmQ9hNbXPEkljJnFExfdwmS f7xNArwaHFGJ/xG+nKdsWS+agoQK1U8eEpxSLjDIq9uDc/i/OO5C8+svoNJczNgja2gb kSWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718445384; x=1719050184; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tg5u5ShuykptgMBL5I5DS/hZACOm+i1CYfL5BzH1+bY=; b=OfV3ANp7eDYdVIFWkhxLjkZdYMRKbzj6cvQtTUIhbTn5QrmbShG3qieXUHZTlN0Pg4 eIQ20zsXDeelVpfE3qhzVHPqJ0YhYaldlcF3H3ZhIzdO0sxU/rnJ+RgB+lOPMiFDpDzC 72qLEyr393vV5mftkYqTlVCA3rAExhH4fJGCtsRwKJoKe8FoUq6HGuxuO/YD38Lshzot b6R3TRYHQumxRG9MeUQurfHPD+9Iyw4Q/18jAWsf+VmidZzo+dxThhMeGYdSQYxMM8Hc RqBUobtQEe9paJ7HtvyfLStN1MQZCuGSbvD0ecqJLw/s4eTN0jjnY7roxMDuXGX1C9lO zlVg== X-Forwarded-Encrypted: i=1; AJvYcCXhaKxlAH/21Km6KzRRIg0/kIbYgqo/rCHca0k3TSqn/doqAHLm8cF3Yd69s5wnB+JvKZ15qB4P/SeB5DcpvGFamK9eZ0kNhQ2ul1o2ADYpAdTt6j4= X-Gm-Message-State: AOJu0YzlflJZGrv5aOswkTlkz8I1KS7/uVna/YRGM4s5qOQyC/+v736k 0+Xr3jGT1uYx4Hr0Pp7ZyllDzcvNqs5V8bHX+VmyED2FXzkzA3ll X-Google-Smtp-Source: AGHT+IEDUVaqWTyE5K7lkt2gzZ4FztGsgWD9JDp9eG7o9DJF60GqM8BDrnujcRy+GpHK8csEE5ZSVA== X-Received: by 2002:aa7:8b94:0:b0:702:65de:19e5 with SMTP id d2e1a72fcca58-705d722b7a3mr5165325b3a.33.1718445384256; Sat, 15 Jun 2024 02:56:24 -0700 (PDT) Received: from localhost.localdomain ([129.146.253.192]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-705ccb71715sm4531309b3a.175.2024.06.15.02.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jun 2024 02:56:23 -0700 (PDT) From: Furong Xu <0x1207@gmail.com> To: "Russell King (Oracle)" , Eric Dumazet , Vadim Fedorenko , "David S. Miller" , Alexandre Torgue , Jose Abreu , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , Corinna Vinschen Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com, Furong Xu <0x1207@gmail.com> Subject: [PATCH net-next v4] net: stmmac: Enable TSO on VLANs Date: Sat, 15 Jun 2024 17:56:11 +0800 Message-Id: <20240615095611.517323-1-0x1207@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240615_025627_514321_7F3ABE61 X-CRM114-Status: GOOD ( 15.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The TSO engine works well when the frames are not VLAN Tagged. But it will produce broken segments when frames are VLAN Tagged. The first segment is all good, while the second segment to the last segment are broken, they lack of required VLAN tag. An example here: ======== // 1st segment of a VLAN Tagged TSO frame, nothing wrong. MacSrc > MacDst, ethertype 802.1Q (0x8100), length 1518: vlan 100, p 1, ethertype IPv4 (0x0800), HostA:42643 > HostB:5201: Flags [.], seq 1:1449 // 2nd to last segments of a VLAN Tagged TSO frame, VLAN tag is missing. MacSrc > MacDst, ethertype IPv4 (0x0800), length 1514: HostA:42643 > HostB:5201: Flags [.], seq 1449:2897 MacSrc > MacDst, ethertype IPv4 (0x0800), length 1514: HostA:42643 > HostB:5201: Flags [.], seq 2897:4345 MacSrc > MacDst, ethertype IPv4 (0x0800), length 1514: HostA:42643 > HostB:5201: Flags [.], seq 4345:5793 MacSrc > MacDst, ethertype IPv4 (0x0800), length 1514: HostA:42643 > HostB:5201: Flags [P.], seq 5793:7241 // normal VLAN Tagged non-TSO frame, nothing wrong. MacSrc > MacDst, ethertype 802.1Q (0x8100), length 1022: vlan 100, p 1, ethertype IPv4 (0x0800), HostA:42643 > HostB:5201: Flags [P.], seq 7241:8193 MacSrc > MacDst, ethertype 802.1Q (0x8100), length 70: vlan 100, p 1, ethertype IPv4 (0x0800), HostA:42643 > HostB:5201: Flags [F.], seq 8193 ======== When transmitting VLAN Tagged TSO frames, never insert VLAN tag by HW, always insert VLAN tag to SKB payload, then TSO works well on VLANs for all MAC cores. Tested on DWMAC CORE 5.10a, DWMAC CORE 5.20a and DWXGMAC CORE 3.20a Signed-off-by: Furong Xu <0x1207@gmail.com> --- Changes in v4: - Re-arrange variables to keep reverse x-mas tree order. Changes in v3: - Drop packet and increase stats counter when vlan tag insert fails. Changes in v2: - Use __vlan_hwaccel_push_inside() to insert vlan tag to the payload. --- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 32 +++++++++++-------- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 5ddbb0d44373..83b654b7a9fd 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -4237,18 +4237,32 @@ static netdev_tx_t stmmac_tso_xmit(struct sk_buff *skb, struct net_device *dev) { struct dma_desc *desc, *first, *mss_desc = NULL; struct stmmac_priv *priv = netdev_priv(dev); - int nfrags = skb_shinfo(skb)->nr_frags; - u32 queue = skb_get_queue_mapping(skb); + int tmp_pay_len = 0, first_tx, nfrags; unsigned int first_entry, tx_packets; struct stmmac_txq_stats *txq_stats; - int tmp_pay_len = 0, first_tx; struct stmmac_tx_queue *tx_q; - bool has_vlan, set_ic; + u32 pay_len, mss, queue; u8 proto_hdr_len, hdr; - u32 pay_len, mss; dma_addr_t des; + bool set_ic; int i; + /* Always insert VLAN tag to SKB payload for TSO frames. + * + * Never insert VLAN tag by HW, since segments splited by + * TSO engine will be un-tagged by mistake. + */ + if (skb_vlan_tag_present(skb)) { + skb = __vlan_hwaccel_push_inside(skb); + if (unlikely(!skb)) { + priv->xstats.tx_dropped++; + return NETDEV_TX_OK; + } + } + + nfrags = skb_shinfo(skb)->nr_frags; + queue = skb_get_queue_mapping(skb); + tx_q = &priv->dma_conf.tx_queue[queue]; txq_stats = &priv->xstats.txq_stats[queue]; first_tx = tx_q->cur_tx; @@ -4301,9 +4315,6 @@ static netdev_tx_t stmmac_tso_xmit(struct sk_buff *skb, struct net_device *dev) skb->data_len); } - /* Check if VLAN can be inserted by HW */ - has_vlan = stmmac_vlan_insert(priv, skb, tx_q); - first_entry = tx_q->cur_tx; WARN_ON(tx_q->tx_skbuff[first_entry]); @@ -4313,9 +4324,6 @@ static netdev_tx_t stmmac_tso_xmit(struct sk_buff *skb, struct net_device *dev) desc = &tx_q->dma_tx[first_entry]; first = desc; - if (has_vlan) - stmmac_set_desc_vlan(priv, first, STMMAC_VLAN_INSERT); - /* first descriptor: fill Headers on Buf1 */ des = dma_map_single(priv->device, skb->data, skb_headlen(skb), DMA_TO_DEVICE); @@ -7682,8 +7690,6 @@ int stmmac_dvr_probe(struct device *device, ndev->features |= NETIF_F_RXHASH; ndev->vlan_features |= ndev->features; - /* TSO doesn't work on VLANs yet */ - ndev->vlan_features &= ~NETIF_F_TSO; /* MTU range: 46 - hw-specific max */ ndev->min_mtu = ETH_ZLEN - ETH_HLEN; -- 2.34.1