From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59EAFC2BD05 for ; Mon, 17 Jun 2024 15:01:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=b+ymucZ3m6lrJGr3WTAeCvzidHKg4xOe2grvPyQxJhA=; b=APdOtMV/Ih9DSCFZiJn3P4ztSH xadVdFgmj+3+ajshvpVmoRhmJJb85R2q8D9DMIkYnuatNl8+mX01xqALmRPWgKLvV5A/AU9SDrVmj XzsqWe/k5MO5xK0nH/1sm3A8DNJlcBgiuDO8z2dEj+o0V1r3ZEa7jgiv8+X8qaKDFu6g+qvTN6to3 ecS6KLGh5rm+rgpp2dWb5c3J5pc+5gZEYq9A85DE2dbUl39gT2qxRma/IrKnoXL3gEO+IzEr9fq5R WOaTySFn1JXUeY7YdKjMOO5ZJGB4Y0Zd3ObDQbFEXioEbzDHO59ODNmO21sBQnHF8aE97jv+EYQtZ MUhgznTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJDrI-0000000BKRv-0OzT; Mon, 17 Jun 2024 15:01:24 +0000 Received: from mail-qk1-x72b.google.com ([2607:f8b0:4864:20::72b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCl2-0000000Axbv-1SVA for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 13:50:57 +0000 Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-797e2834c4eso366754685a.0 for ; Mon, 17 Jun 2024 06:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718632251; x=1719237051; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=b+ymucZ3m6lrJGr3WTAeCvzidHKg4xOe2grvPyQxJhA=; b=cg3m+UNm5cj53SiOCopffSu2NrqsqVryVEFNFdIQ2hXMJcsvJQo++7XitZxgt5zlxB Wr9+hcNO9yCxxGweqiXArTiyE8iKuLVHMFhyQUQ4eVBTPzDQ2Ho82FKUT4BggamkdXEw SpyRd4mgH7lxwIEo6fqCqgBEc+P+IIeVwG8lgqcUk0bczTDx7Ra6SDCldl0jiynsXtek De3pF4e1+MDj51KBNO5K9FlMQ/ExP+Rd+d+05S8QLDX2iCjrsKyz0EBpYjSllaqh/xYQ pQfzgniJvZzr5DkJltiGPokl+X5YzWub84S2lZpxIlWa3DYeFSEnzHTz/VQ0YE70fEdN wL7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718632251; x=1719237051; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b+ymucZ3m6lrJGr3WTAeCvzidHKg4xOe2grvPyQxJhA=; b=NFTk2xZ5BLjSZS/OBTokrbKuzZ5oPGi9OseO+3Lnp5pb9M8zpCfvDKWV51ECHPxj3A 8mJcE/v33AfoskwRQXtGMYmMKZZiI0aGseJcdo8WOAAgN9AL3aPx+II5ZddITUdeeG2o KChnI1q/j/VGsisX1HkXvbzBgobBwoOA9JRxB+llomzycbkhweui0Js/jVcpMOV+OR0e rc6AVuvWTFJ8LjQGod4G5Mo/vsKMZDqw5f9UPKQ0w/7exCNM7gegp2aGFjiNzleGSJdP +WefH2xJo8r3J2Nr4WdgPoHv7UyBv/LLP1WuLi85iIYUYu/5O6hS7A1ae2u92d3zM+iE i8Zw== X-Forwarded-Encrypted: i=1; AJvYcCVQlxebJj/utJVMBODs/R8qqsOCQA0kPYh36xKzk5g/yJzh4VJ4Wzbcl+BxezmDElwh3VvQ2F7uZYR5GCDX65VP+eVlw/SfmQfs6GI4nPW/i/TMq1A= X-Gm-Message-State: AOJu0YwWWoU95qqeuGBCAMJlely/jDADjajmjZnxM7g8oMFL6VA3N8Fp 79o4XSv1NYB/0XlblPSjT9MpTFb6gbjUF/HrkjtTf/ASid0G+DzNqdjcJKZlk+s= X-Google-Smtp-Source: AGHT+IFhD2JefGeiJgsg6Ae7QRIe/BDndSP0Z/WiCRPC91zIn6+wpqBzLsiQzn3/JIP4kN+hagVe4g== X-Received: by 2002:a05:620a:4056:b0:795:56a1:6c0a with SMTP id af79cd13be357-798d03b78c4mr1852443685a.30.1718632251285; Mon, 17 Jun 2024 06:50:51 -0700 (PDT) Received: from megalith.oryx-coho.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aaecc004sm432892285a.31.2024.06.17.06.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 06:50:51 -0700 (PDT) From: Trevor Gamblin Date: Mon, 17 Jun 2024 09:50:11 -0400 Subject: [PATCH v3 31/41] iio: light: st_uvis25_core: make use of regmap_clear_bits() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20240617-review-v3-31-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> In-Reply-To: <20240617-review-v3-0-88d1338c4cca@baylibre.com> To: Jonathan Cameron , Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Nuno_S=C3=A1?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Trevor Gamblin X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_065052_596921_EB26158B X-CRM114-Status: GOOD ( 11.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Instead of using regmap_update_bits() and passing val = 0, use regmap_clear_bits(). Suggested-by: Uwe Kleine-König Signed-off-by: Trevor Gamblin --- drivers/iio/light/st_uvis25_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/st_uvis25_core.c b/drivers/iio/light/st_uvis25_core.c index d4e17079b2f4..fba3997574bb 100644 --- a/drivers/iio/light/st_uvis25_core.c +++ b/drivers/iio/light/st_uvis25_core.c @@ -330,8 +330,8 @@ static int st_uvis25_suspend(struct device *dev) struct iio_dev *iio_dev = dev_get_drvdata(dev); struct st_uvis25_hw *hw = iio_priv(iio_dev); - return regmap_update_bits(hw->regmap, ST_UVIS25_REG_CTRL1_ADDR, - ST_UVIS25_REG_ODR_MASK, 0); + return regmap_clear_bits(hw->regmap, ST_UVIS25_REG_CTRL1_ADDR, + ST_UVIS25_REG_ODR_MASK); } static int st_uvis25_resume(struct device *dev) -- 2.45.2