From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AC40C27C79 for ; Mon, 17 Jun 2024 13:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EcLjABCmPDgHOzLEYjNK5DROGA4JTxd15k6kwWpFoxg=; b=ryELbFisoem0GWOwd4lUEYfRLw WWz49CS8BrESqZroA+G57oC6CiDvXSA/jIQmopRBW2rpv5IhqW3ei/A/by7NvBx264OO5vsUMWxGh 7ek4Yxeof+3hW3ve03lrpqVjFzAt6RllRVCFA3vHTZgDORKYXU9CR+cPEx6oZLKvgqwD33DSVm+yC 0woTHowy0wgvOv9ZsOTVuTqNMhunB40Si4G33yzbNeGJH35cA7cYL6YkPJg2jlJwK/+gCz85Qq6FO SOW0EnOpwG9qWTcEg4nmZUURBOQ1ufHD3JmjmvaGaWdw85Oyuemzb0nnz8Fe5IQOdCZAU53NsedKe 158nUw4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCkQ-0000000Ax1S-1wA0; Mon, 17 Jun 2024 13:50:14 +0000 Received: from mail-oa1-x30.google.com ([2001:4860:4864:20::30]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCk6-0000000AwkW-3Rkb for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 13:49:56 +0000 Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-2508320e62dso2268437fac.3 for ; Mon, 17 Jun 2024 06:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718632193; x=1719236993; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EcLjABCmPDgHOzLEYjNK5DROGA4JTxd15k6kwWpFoxg=; b=J/7agfne7tU6CRXIFGIpvWDHjGHCgF4Scqa7m+d/e6OFW1YAV1cXG8DXkV2xOSNTmG RjhDklAHEfMa1DxAsW9QDousc+CLRy5OurBgSSAgCrEHpJj0Zot4Hh2qVauDt0bykcLa MEqKdjW/Pcxfq+hxIMyUiScO2pqHamkwh3oWXCNOUieBTYOQucZnzaVseLb7/1vwfgJ2 ZLDQvYsnPP5+Cy5HC/cwyMltoKZmxnpSvpdPavzGKvdeNsMJjDaEnX5b4UiH0krPrdHF zQh9q0AuzGJju1Fy3WnezqBwcAcCN4noXXyCYv6ptvXU3iIx/ikW0+MyA/PYaw+wC+7j q0ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718632193; x=1719236993; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EcLjABCmPDgHOzLEYjNK5DROGA4JTxd15k6kwWpFoxg=; b=mWWNRn8ONDox+sWurBSkNfKreie76GLp2FOf/ehMNU8I9Lt1hE+rEefuXKoh0rJw5V rbNEE+V//5sdf3DrRAQckIVBUDz46lMR2014h4vmzBDCmoAiERJMXEiGQ9YQDom+cqjp jyPnJatny7BytzIn3SNldG+0TfACzhR1TgODgstAjMzsjW6T8Jf4QBBVIaM3WA0olxkE +HkQ2nTGpZYdqty0mg6WIWaHl895zzZQKToNVKE5GRy34webRkSfJjkpv2JZVcOdF3Mg 3NQ7Rjc+cGV4PxTj36rIQaX9J86QF3rrzvatGj8I41487FzHYK/3Gt1rqM4VVxOAxLL+ I13A== X-Forwarded-Encrypted: i=1; AJvYcCVZKzymLhXo8u/ePoS4jFviHM8WmdaeRBmjZUQwZUxdju2RkbV19rjsq7Kl/3VzF1NIhBU1w54IAe1ki9o3EU4PdDCduUFLAwo1flzRnUXQdIClSzg= X-Gm-Message-State: AOJu0Yw9Mrmqq6aKM/y8YZ4KL+PvQz/BDIj8GGPAozp/TizresXM9N+4 J+YKXs1FTkFilxSGtjaY1OjRxFmY1YC3cvmHm2pLvtxZjeKCmnsk0jEq2beo8Lw= X-Google-Smtp-Source: AGHT+IGzXK8LLO+jQf8g3iL5MCifYqjIipjPlFcW7eDQk67H8aKJxfmuoG4FYBXo33Z8PvtltK6jug== X-Received: by 2002:a05:6870:4728:b0:24f:d9de:3bed with SMTP id 586e51a60fabf-25842b793famr10756815fac.41.1718632193273; Mon, 17 Jun 2024 06:49:53 -0700 (PDT) Received: from megalith.oryx-coho.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aaecc004sm432892285a.31.2024.06.17.06.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 06:49:53 -0700 (PDT) From: Trevor Gamblin Date: Mon, 17 Jun 2024 09:49:44 -0400 Subject: [PATCH v3 04/41] iio: adc: ad4130: make use of regmap_clear_bits() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20240617-review-v3-4-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> In-Reply-To: <20240617-review-v3-0-88d1338c4cca@baylibre.com> To: Jonathan Cameron , Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , =?utf-8?q?Nuno_S=C3=A1?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Trevor Gamblin X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_064955_108049_449AEF21 X-CRM114-Status: GOOD ( 11.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Instead of using regmap_update_bits() and passing val = 0, use regmap_clear_bits(). Suggested-by: Uwe Kleine-König Signed-off-by: Trevor Gamblin --- drivers/iio/adc/ad4130.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad4130.c b/drivers/iio/adc/ad4130.c index aaf1fb0ac447..e134d6497827 100644 --- a/drivers/iio/adc/ad4130.c +++ b/drivers/iio/adc/ad4130.c @@ -1883,8 +1883,8 @@ static int ad4130_setup(struct iio_dev *indio_dev) if (ret) return ret; - ret = regmap_update_bits(st->regmap, AD4130_FIFO_CONTROL_REG, - AD4130_FIFO_CONTROL_HEADER_MASK, 0); + ret = regmap_clear_bits(st->regmap, AD4130_FIFO_CONTROL_REG, + AD4130_FIFO_CONTROL_HEADER_MASK); if (ret) return ret; -- 2.45.2