From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7400C27C79 for ; Mon, 17 Jun 2024 15:19:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UM34Ri+PIvlXre1do+sFrortKg88knpFg8X+BMXkdQY=; b=Z35aC0V96ZeDUSxgBBlyfwkCam zVi8GiT4NFghGbia3I9Ko3Ckz3r3ykMzkM4QcAkjDnkWdbuFAMFgMAMSa2CvYehIQRf17xrRFmlH/ XsxseFJx2zN7jh/pzw5OjJ2BglKyszOYbS/a6o6Aj1KehZYn0BtbEPqmUccAjdPryy7liEoZCwGGl pe27SUZceIzN/t29U/oY+HhWOgx4aqgnw0SST4KRpg23lCSePWNce5k3M6k6JdwI//4sciRi0S0S7 nWt8NjajLt34sG5ngqJt/CdvkveZBMrCC+Wx5uNh3eCFSkamzTLw9AVYniOx6VeVJiSmSe0Wu3j6k 38npT4ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJE91-0000000BPrw-0vFO; Mon, 17 Jun 2024 15:19:43 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJE8w-0000000BPpZ-2Zao for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 15:19:41 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B7A7CCE10B2; Mon, 17 Jun 2024 15:19:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B61E1C2BD10; Mon, 17 Jun 2024 15:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718637576; bh=naIpIa1Kqns2NPV2ho5gEYD9eBsk6s5vBFjFML3y3gY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QcD6Akg1FReoE8UPj/9zF6jZ1yON9EcKYgTCgFyPoyQ9Wte08cmcGhBeGg10nC+52 O07VNeU9KgWCAhkTidcKUHPuLZVhNLLHF7Q2CVLDMy96838Aq1knZ40LRDYWYRw9h7 wRFVHZzx65ta+Hy8nTLvQW+TchUfJ9RzIAW8G9NnlcHxNMURuZ77x09vgNM2ZJoAVH B/9g1CHT4IbzAUQLyY1zCq9Q0DAdAZMfnRVNwzKAta163AL8eRs5wW5Xu6D7Y6LSYz 9R9F+CYDa8ySAitMzmOL9BByawEiEH6S/JI+Lqni/isTureAiD5nlUV0rBD+3sZzUh WskH6GRMGuisw== Date: Mon, 17 Jun 2024 16:19:30 +0100 From: Conor Dooley To: claudiu beznea Cc: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, alexandre.belloni@bootlin.com, magnus.damm@gmail.com, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Claudiu Beznea Subject: Re: [PATCH 02/12] dt-bindings: clock: renesas,rzg3s-vbattb-clk: Document the VBATTB clock driver Message-ID: <20240617-subsoil-creed-04bf5f13d081@spud> References: <20240614071932.1014067-1-claudiu.beznea.uj@bp.renesas.com> <20240614071932.1014067-3-claudiu.beznea.uj@bp.renesas.com> <20240615-angler-occupier-6188a3187655@spud> <3d9ed0ec-ca9a-45b4-a633-8f7051d13cff@tuxon.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="56coL768YMNwi762" Content-Disposition: inline In-Reply-To: <3d9ed0ec-ca9a-45b4-a633-8f7051d13cff@tuxon.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_081939_064275_F1914E39 X-CRM114-Status: GOOD ( 22.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --56coL768YMNwi762 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 17, 2024 at 10:02:47AM +0300, claudiu beznea wrote: >=20 >=20 > On 15.06.2024 15:17, Conor Dooley wrote: > > On Fri, Jun 14, 2024 at 10:19:22AM +0300, Claudiu wrote: > >> From: Claudiu Beznea > >> > >> The VBATTB IP of the Renesas RZ/G3S SoC controls the clock that feeds > >> the RTC and the tamper detector. Add documentation for the VBATTB clock > >> driver. > >> > >> Signed-off-by: Claudiu Beznea > >> --- > >> .../clock/renesas,rzg3s-vbattb-clk.yaml | 90 +++++++++++++++++++ > >> 1 file changed, 90 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/clock/renesas,rz= g3s-vbattb-clk.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/clock/renesas,rzg3s-vba= ttb-clk.yaml b/Documentation/devicetree/bindings/clock/renesas,rzg3s-vbattb= -clk.yaml > >> new file mode 100644 > >> index 000000000000..ef52a0c0f874 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/clock/renesas,rzg3s-vbattb-clk= =2Eyaml > >> @@ -0,0 +1,90 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/clock/renesas,rzg3s-vbattb-clk.yam= l# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Renesas VBATTB clock > >> + > >> +maintainers: > >> + - Claudiu Beznea > >> + > >> +description: > >> + Renesas VBATTB module is an always on powered module (backed by bat= tery) which > >> + generates a clock (VBATTCLK). This clocks feeds the RTC and the tam= per detector > >> + modules. > >> + > >> +properties: > >> + compatible: > >> + const: renesas,rzg3s-vbattb-clk > >> + > >> + reg: > >> + maxItems: 1 > >> + > >> + clocks: > >> + items: > >> + - description: VBATTB module clock > >> + - description: VBATTB input xtal > >> + > >> + clock-names: > >> + items: > >> + - const: bclk > >> + - const: vbattb_xtal > >> + > >> + '#clock-cells': > >> + const: 0 > >> + > >> + power-domains: > >> + maxItems: 1 > >> + > >> + renesas,vbattb-load-nanofarads: > >> + description: load capacitance of the on board xtal > >> + $ref: /schemas/types.yaml#/definitions/uint32 > >> + enum: [ 4000, 7000, 9000, 12500 ] > >> + > >> + renesas,vbattb-osc-bypass: > >> + description: set when external clock is connected to RTXOUT pin > >> + type: boolean > >=20 > > When you say "external clock", is that an input or an output? >=20 > I took that statement from the HW manual. As of the HW manual [1], table > 42.2, that would be an input. Forgive me for not wanting to open the zip etc and find the information in the document, but why do you need an extra property? Is it not something you can determine from the clocks/clock-names properties? It sounds like an additional clock from your description, is it actually different way to provide the second clock you mention above? >=20 > [1] > https://www.renesas.com/us/en/products/microcontrollers-microprocessors/r= z-mpus/rzg3s-general-purpose-microprocessors-single-core-arm-cortex-a55-11-= ghz-cpu-and-dual-core-cortex-m33-250 >=20 --56coL768YMNwi762 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZnBUAgAKCRB4tDGHoIJi 0rZQAQCewakzSyZHrcYUH8+d8xIo+9/OP7zyCp6sCDIWB4L7sAEAzqCsVwlD4cn+ 2oxxeZnpGsG3xJ+EYOZM76MqaXgtQwQ= =GLxB -----END PGP SIGNATURE----- --56coL768YMNwi762--