From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30203C27C6E for ; Mon, 17 Jun 2024 07:19:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q7QMgSvLT6tpB5yAK78EPV33Z7ib0EHfluQ4HnCmDtA=; b=foICeeSEvd1cstFptukmP+i3Xb eGrHIIu02b7dDZi//30u1JUAx0dwpwSnHhxK7B9/AhO+LhpwbnJ/YRvQiYYkJgr33Maycyz3PHSaE 8SDHGO0iMwtZ7funlvTvfIB/2t+kUsa6Nncuev4FHBLXvWPhrd7/wvYucfQrUkfPlcMBMFdLZdvMl K/diXk7tZqSm1OAbHA9350RfS+2r7kv2JIcHmk1xByQt9oOrmX6VN3xqZkNw1y6kYUk1V3rAb82JA R2VdXvrD8GXq2tpgOrWuySMlhLB8t0+TyLKm68WnUaiCpukTj+56fW50KdleRXsKIbwZm+2387o/C Dn4PbqvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ6dl-00000009beF-234v; Mon, 17 Jun 2024 07:18:57 +0000 Received: from mail11.truemail.it ([2001:4b7e:0:8::81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ6dh-00000009bbV-0wiO for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 07:18:55 +0000 Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 533561F9B7; Mon, 17 Jun 2024 09:18:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1718608726; bh=q7QMgSvLT6tpB5yAK78EPV33Z7ib0EHfluQ4HnCmDtA=; h=From:To:Subject; b=h94ImflPQUu4NOfRwurKDZh3mex8qrJffrsVdqZiAyAnXVNwdC3SpN64OT/BzlJiT ALmvT5QSxy9YF4ccCZnHCEonCzQrFxVhVcbrmjcHa2VGtfBYuWEfnzzMccsWh7RePT iYtuLRR+otcTYriw3xug1WqG8+ZvLcsEtpkV0s+bPwAA+jF0mxNMW037G0JsX5i0In V0+6wyYERIYpWrseAz2T/4vqp2xXhBb+WG00KKz9l4t1V6s1eA9XpG1mfh7Ex/s61o r53+RN2WHrunBZKPTXyYOXJMkwL53QQrORtb5/tO2AQCWvvoUj89XhHQ2Dux9H/wTL bCRvDah91j7dA== Date: Mon, 17 Jun 2024 09:18:42 +0200 From: Francesco Dolcini To: Shawn Guo Cc: Vitor Soares , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vitor Soares , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] arm64: dts: imx8mm-verdin: add TPM device Message-ID: <20240617071842.GA4832@francesco-nb> References: <20240613134150.318755-1-ivitro@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_001854_113219_B21DFA24 X-CRM114-Status: GOOD ( 16.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Shawn, On Mon, Jun 17, 2024 at 10:33:50AM +0800, Shawn Guo wrote: > On Thu, Jun 13, 2024 at 02:41:50PM +0100, Vitor Soares wrote: > > From: Vitor Soares > > > > Add TPM device found on Verdin iMX8M Mini PID4 0090 variant. > > > > Signed-off-by: Vitor Soares > > --- > > arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 16 +++++++++++----- > > 1 file changed, 11 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > index 4768b05fd765..c9ae5f0bb526 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > @@ -227,15 +227,16 @@ &ecspi2 { > > pinctrl-0 = <&pinctrl_ecspi2>; > > }; > > > > -/* Verdin CAN_1 (On-module) */ > > +/* On-module SPI */ > > &ecspi3 { > > #address-cells = <1>; > > #size-cells = <0>; > > - cs-gpios = <&gpio5 25 GPIO_ACTIVE_LOW>; > > + cs-gpios = <&gpio5 25 GPIO_ACTIVE_LOW>, <&gpio4 19 GPIO_ACTIVE_LOW>; > > pinctrl-names = "default"; > > - pinctrl-0 = <&pinctrl_ecspi3>; > > + pinctrl-0 = <&pinctrl_ecspi3>, <&pinctrl_pmic_tpm_ena>; > > Would it make more sense to have tpm pinctrl in node tpm@1 below? It's the pinctrl of the SPI Chip Select pin, not something about the TPM, I think it's correct to have it into the ecspi node. > > + verdin_som_tpm: tpm@1 { > > + compatible = "atmel,attpm20p", "tcg,tpm_tis-spi"; > > + reg = <0x1>; > > + spi-max-frequency = <36000000>; > > + }; > > }; Francesco