From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9417BC27C6E for ; Mon, 17 Jun 2024 09:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9RQSHhiPr5P5gr0BCPxUZ9s6tE/N/ZAdq52SswK/jus=; b=w20AHtTnJP+fsVDUWs6p6KgTsk SNTgMlSvrXEczRll+PVZ11YAYfnRB+pDs4lcXrE9H+rs3hXeiTNiWuBtc3PI+L95PHO802ATV6NJd sFSyUTN7Hou8sk2e+3Wl02GrlOJpK1B2LksUr5LJdp3PAvbC0iFA2VGq5/3yx2KrN9xeNtaACaxCn LBJWfrCinvVjWRRLCJhKZPNt8FZg3JP6hXEh1JI3AC4dRe+f4wRey6r529CEA8TnCqikJ4bJHdgiy hcjXdmnpHGg3fBxKk8A6xIj0cbaLT1fGOCttxohRAiaKXUbxvCJn1tj0dY2V/eknKa1L8mQonDBu8 AikUmb7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ8RD-00000009ynJ-0Lgh; Mon, 17 Jun 2024 09:14:07 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ8R5-00000009yig-2hha for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 09:14:02 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B98DDCE1003; Mon, 17 Jun 2024 09:13:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA09CC3277B; Mon, 17 Jun 2024 09:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718615637; bh=2Qw+7Rve50c6UoNrfytgIz8RzG/OQfuJ1xjLwlqspyo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gSgLRADIKoOCmMyFRz+CnOHRTTUWVz36ssNelNd6IkjvMKrJEc9aQ82LdxSAMh9S8 peNxBrFbD3hFQEevslagbikhL4fvdMvvdB6/wLBjPI/WkDoVrhB/1jMlnUdzzm3snl adk2dQjYfmBivIiWVk0cDHdvFYP06g2KV+jNo619u+aehEkLMnArTxxedkpbBgZmVu 1osLfnHwZ5GYDsfHcFaRTo8X8xAfJmeIThRDU0TeKxgvD5vY+3BT3qGWJlTUoTyc9A hr0jzg5dzS+DgZK+1Tg9cMWLJyWU8kq2h6XqOu1FeqIuFi+qe8e3bBQG4ynzZbhJwK 5zeC/R0g4Kb6A== From: Michael Walle To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Li Yang Cc: Pengutronix Kernel Team , Fabio Estevam , Priit Laes , Michael Grzeschik , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marco Felsch , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Michael Walle Subject: [PATCH v3 02/13] ARM: dts: imx6qdl-kontron-samx6i: fix PHY reset Date: Mon, 17 Jun 2024 11:13:30 +0200 Message-Id: <20240617091341.2375325-3-mwalle@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240617091341.2375325-1-mwalle@kernel.org> References: <20240617091341.2375325-1-mwalle@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_021359_997736_0B8EBC56 X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The PHY reset line is connected to both the SoC (GPIO1_25) and the CPLD. We must not use the GPIO1_25 as it will drive against the output buffer of the CPLD. Instead there is another GPIO (GPIO2_01), an input to the CPLD, which will tell the CPLD to assert the PHY reset line. Fixes: 2a51f9dae13d ("ARM: dts: imx6qdl-kontron-samx6i: Add iMX6-based Kontron SMARC-sAMX6i module") Fixes: 5694eed98cca ("ARM: dts: imx6qdl-kontron-samx6i: move phy reset into phy-node") Signed-off-by: Michael Walle --- arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi index d8c1dfb8c9ab..d6c049b9a9c6 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi @@ -269,7 +269,7 @@ mdio { ethphy: ethernet-phy@1 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <1>; - reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; + reset-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>; reset-assert-us = <1000>; }; }; @@ -516,7 +516,7 @@ MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b0b0 MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x1b0b0 MX6QDL_PAD_ENET_MDC__ENET_MDC 0x1b0b0 MX6QDL_PAD_ENET_REF_CLK__ENET_TX_CLK 0x1b0b0 - MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1b0b0 /* RST_GBE0_PHY# */ + MX6QDL_PAD_NANDF_D1__GPIO2_IO01 0x1b0b0 /* RST_GBE0_PHY# */ >; }; -- 2.39.2