From: Simon Horman <horms@kernel.org>
To: xiaolei wang <xiaolei.wang@windriver.com>
Cc: olteanv@gmail.com, linux@armlinux.org.uk,
alexandre.torgue@foss.st.com, andrew@lunn.ch,
joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com,
wojciech.drewek@intel.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [net PATCH] net: stmmac: No need to calculate speed divider when offload is disabled
Date: Mon, 17 Jun 2024 11:29:01 +0100 [thread overview]
Message-ID: <20240617102901.GO8447@kernel.org> (raw)
In-Reply-To: <ec41f61f-d500-4dda-8a79-37a68ddafced@windriver.com>
On Sun, Jun 16, 2024 at 09:15:05AM +0800, xiaolei wang wrote:
>
> On 6/15/24 22:47, Simon Horman wrote:
> > On Fri, Jun 14, 2024 at 04:19:16PM +0800, Xiaolei Wang wrote:
...
> > /* Final adjustments for HW */
> > value = div_s64(qopt->idleslope * 1024ll * ptr, port_transmit_rate_kbps);
> > priv->plat->tx_queues_cfg[queue].idle_slope = value & GENMASK(31, 0);
> >
> > value = div_s64(-qopt->sendslope * 1024ll * ptr, port_transmit_rate_kbps);
> > priv->plat->tx_queues_cfg[queue].send_slope = value & GENMASK(31, 0);
> >
> > And the div_s64() lines above appear to use
> > ptr uninitialised in the !qopt->enable case.
>
> Oh, when deleting the configuration, idleslope and sendslope are both 0, do
> you mean we also need to set ptr to 0?
Understood, if idleslope and sendslope are 0, then ptr could be set to any
value and the result would be the same. And, based on my limited
understanding, 0 does not seem to be a bad choice.
My point is that ptr shouldn't be uninitialised at this point.
...
next prev parent reply other threads:[~2024-06-17 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 8:19 [net PATCH] net: stmmac: No need to calculate speed divider when offload is disabled Xiaolei Wang
2024-06-15 14:47 ` Simon Horman
2024-06-16 1:15 ` xiaolei wang
2024-06-17 10:29 ` Simon Horman [this message]
2024-06-18 2:31 ` xiaolei wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617102901.GO8447@kernel.org \
--to=horms@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=wojciech.drewek@intel.com \
--cc=xiaolei.wang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).