From: Sudeep Holla <sudeep.holla@arm.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: "cristian.marussi@arm.com" <cristian.marussi@arm.com>,
"robh@kernel.org" <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
"arm-scmi@vger.kernel.org" <arm-scmi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: scmi mailbox max_rx_timeout_ms value
Date: Mon, 17 Jun 2024 14:28:11 +0100 [thread overview]
Message-ID: <20240617132811.adcqbpf5u7e4xqe7@bogus> (raw)
In-Reply-To: <AM6PR04MB59414DB0445EDF6ECA46B02F88CD2@AM6PR04MB5941.eurprd04.prod.outlook.com>
On Mon, Jun 17, 2024 at 09:17:11AM +0000, Peng Fan wrote:
> Hi Sudeep, Cristian and DT maintainers
>
> In drivers/firmware/arm_scmi/mailbox.c, current max_rx_timeout_ms
> is 30ms, we wanna to enlarge the value.
Care to provide the reason for the same ? Few possible bottle-neck/issues:
1. Transport
2. Firmware implementation
3. Processing capability of co-processor implementing SCMI
> NXP downstream value is set to 1000ms, but for upstream I think it may
> not be a good solution that just enlarge it for all scmi users,
I think it may not be good solution on any modern platform to have
such high latency for P2A or A2P communication. Even Juno(a decade old
platform copes well with 30ms with SCP running at 50MHz(IIRC). So I am
interesting in getting more info about i.MX before we can decide on the
right path to progress here.
> Each platform may have its own max timeout value depends on scmi firmware
> design.
Fair enough, but 30ms to 1000ms just seems wrong to me to start with.
I simple need more information to get convinced here.
> So I am thinking to use a device tree property for this, saying
> "mbox-rx-timeout-us", just as "atomic-threshold-us" in arm,scmi.yaml
>
May be, I am not completely against it as we need this if some platforms
need say 50ms instead of 30ms. Typically any sync command needs to be
processed with few 100s of uS not even as high as a mS. So as I said
before 1000mS needs lot of convincing. I am not even sure of 1s is
tolerable latency in general for some of the SCMI perf commands.
--
Regards,
Sudeep
next prev parent reply other threads:[~2024-06-17 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 9:17 scmi mailbox max_rx_timeout_ms value Peng Fan
2024-06-17 13:28 ` Sudeep Holla [this message]
2024-06-18 2:12 ` Peng Fan
2024-06-18 10:07 ` Sudeep Holla
2024-06-18 13:01 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617132811.adcqbpf5u7e4xqe7@bogus \
--to=sudeep.holla@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=conor+dt@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox