From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD03FC27C53 for ; Wed, 19 Jun 2024 17:28:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Wkc9z1wGlq+E/Ko97W2wwakgM3PY6xgDbiO5m6jBKgY=; b=s/TZ80io9lEbW5673BvXhdkbi5 XD8w55H9fKmNttILzuFSKM4Xvrb5l7UF1ienSYH/MKdhplMAWl/mKLFyMJnRMqaqmXMLvb8G5oUi1 NsJ3qPo4+Ku3CDF8zwbcEr3R2Bi8Hs67yHBi1X2bc+8JC44NVROXDsS9dbzN77zglZaNbbHxFM2JL sVkvrKRTy6Saswpt1BrIHtnGP5jQCD7dr2sVkoWOCMelFE2E3973JwvMAQ3s6+z09jY+hVL9FINx/ UuRobzNKJ7sNKlIZ7ld1eao04Qy5xsTsFfIRaBFhr34weYvndND0DiWfIxYpNSH6IjiY+k0rX8b+v n7Ci2sQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJz6Y-00000002DbS-2aH6; Wed, 19 Jun 2024 17:28:19 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJz5o-00000002DAI-1fJs for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2024 17:27:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1775361F23; Wed, 19 Jun 2024 17:27:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0590C32786; Wed, 19 Jun 2024 17:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718818050; bh=Rnex5JNhxKQCf5yHFRYCGEwnY7umcsl6iVUbeibuU4s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VXJb9PcjkY2X1Fqqmt8e/n7x1YemeoPPoWMO1Z1jq+u8gQ6qCAK3dIB+WByTnBcJ7 D+EKEDfKHkfHDOoH7N9hhC53d6YaSD16alIqwYFV6O23mlePAZQluA4Pr12/OEds91 4Yh2P19ekSo3vKJO4dcsyV1UFdO8bD4AhiGkq/4UlZNO1TrwHn/obVZsJsg5H4j6lS YE2xip64WqQCU3BquM6/p6V/AldfYXE+HSogTM9/72ACoM+G4TnxscIUldNNwggpHP JZuGXDahiv6TdZ3BLu7Rqbc+mYLZVqExu6Qyb+a6B3JO9pT/L+8E3KfWjwH3nQtB4J po47kbRiRbZTw== Date: Wed, 19 Jun 2024 18:27:26 +0100 From: Conor Dooley To: Kanak Shilledar Cc: Vladimir Zapolskiy , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: i2c: convert to dt schema Message-ID: <20240619-exemplify-tabloid-9d15e5005513@spud> References: <20240619154941.144011-2-kanakshilledar@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RH7b0jy6yN7Cw144" Content-Disposition: inline In-Reply-To: <20240619154941.144011-2-kanakshilledar@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240619_102733_221917_012FE6DF X-CRM114-Status: GOOD ( 17.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --RH7b0jy6yN7Cw144 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 19, 2024 at 09:19:36PM +0530, Kanak Shilledar wrote: $subject is missing a prefix for the device in question. > diff --git a/Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml b= /Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml > new file mode 100644 > index 000000000000..79d6774dd54f > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/nxp,lpc1788-i2c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP I2C controller for LPC2xxx/178x/18xx/43xx > + > +maintainers: > + - Vladimir Zapolskiy > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + const: nxp,lpc1788-i2c > + > + reg: > + description: physical address and length of the device registers Drop all of these descriptions as they're obvious, other than... > + maxItems: 1 > + > + interrupts: > + description: a single interrupt specifier > + maxItems: 1 > + > + clocks: > + description: clock for the device > + maxItems: 1 > + > + clock-frequency: > + description: the desired I2C bus clock frequency in Hz =2E.maybe this one. Otherwise this looks okay to me. Thanks, Conor. > + default: 100000 > + > + resets: > + description: reset for the device > + maxItems: 1 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 These two come for free with the ref to i2c-controller.yaml :) > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - "#address-cells" > + - "#size-cells" > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include "dt-bindings/clock/lpc18xx-ccu.h" > + > + i2c@400a1000 { > + compatible =3D "nxp,lpc1788-i2c"; > + reg =3D <0x400a1000 0x1000>; > + interrupts =3D <18>; > + clocks =3D <&ccu1 CLK_APB1_I2C0>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + }; > --=20 > 2.45.2 >=20 --RH7b0jy6yN7Cw144 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZnMU/gAKCRB4tDGHoIJi 0sGHAP4g3+hIwfKb7xaf7XuqndD2LwEcQZhcfUAKlFVfZeUqewD/flKPkwXSVu1E dmuDqAz/Gr5I39tTkIGwN/fx38BMvAY= =Ntw3 -----END PGP SIGNATURE----- --RH7b0jy6yN7Cw144--