From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E20B5C2BA15 for ; Wed, 19 Jun 2024 00:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T1gHGAybh6zXVSjwqLU0JVKnZSW1Frkr9/eSggVKigs=; b=XW6tO9IQPEjsdi6qcVlt3QYjaT Dq5BsVV+ukpXpaKtX24RSRmypNvulDaoyBWanl6SxdG/HUu0eZppUTuwaKvRczfRXzFpe+i8cVJhm xoE2YJ5g+qN8/55U+LJGc2jBtN6V0Mro/3hpG41q2bqryLtIRli3ak4WMnpk0QqW8vuOMio7kzPX6 suIXF+/jROErI+IJ/TanHxn8vNIqc7F3t6JwwHqgoUgdL1ququBE0tAHvp3yEtQnwLGfuVWSanLFM BGwjIcSZC5olSzHXrrMzvB9DBGkM4Jq5inFuVAwIHD3e1c9GfZujFsmDIRNPMcWS0WKLfdHpJm3ve YfJ7/LRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJimF-0000000GxgY-0m1v; Wed, 19 Jun 2024 00:02:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJimA-0000000GxfT-19MS for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2024 00:02:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D545CDA7; Tue, 18 Jun 2024 17:02:33 -0700 (PDT) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0FD333F64C; Tue, 18 Jun 2024 17:02:06 -0700 (PDT) Date: Wed, 19 Jun 2024 01:00:35 +0100 From: Andre Przywara To: Ryan Walklin Cc: Yangtao Li , "Rafael J . Wysocki" , Viresh Kumar , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Chris Morgan , Sudeep Holla , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Stephen Boyd , Rob Herring Subject: Re: [PATCH 2/3] arm64: dts: allwinner: h616: add additional CPU OPPs for the H700 Message-ID: <20240619010035.7aa1bd04@minigeek.lan> In-Reply-To: <20240607092140.33112-3-ryan@testtoast.com> References: <20240607092140.33112-1-ryan@testtoast.com> <20240607092140.33112-3-ryan@testtoast.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240618_170210_616621_F8AB8744 X-CRM114-Status: GOOD ( 17.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 7 Jun 2024 21:20:34 +1200 Ryan Walklin wrote: Hi, > The H700 now shows stable operation with the 1.008, 1.032 and 1.512 GHz > DVFS operating points. The 1.5GHz OPP requires a VDD-CPU of 1.16V, > obtained from the vendor BSP. This voltage is slightly above the > recommended operating voltage for the H616 (H700 datasheet not publicly > available) but well within the absolute maximum of 1.3V. > > Add the additional 1.032 GHz operating point to the H616 CPU-OPP table, > and enable the 1.008 and 1.512 points for the H700. This matches the values I had in the previous version of this patch: > Signed-off-by: Ryan Walklin Reviewed-by: Andre Przywara Cheers, Andre > --- > .../dts/allwinner/sun50i-h616-cpu-opp.dtsi | 25 +++++++++++++------ > 1 file changed, 18 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-cpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616-cpu-opp.dtsi > index aca22a7f0191c..dd10aaf472b66 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h616-cpu-opp.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-cpu-opp.dtsi > @@ -11,7 +11,7 @@ opp-480000000 { > opp-hz = /bits/ 64 <480000000>; > opp-microvolt = <900000>; > clock-latency-ns = <244144>; /* 8 32k periods */ > - opp-supported-hw = <0x1f>; > + opp-supported-hw = <0x3f>; > }; > > opp-600000000 { > @@ -25,7 +25,7 @@ opp-720000000 { > opp-hz = /bits/ 64 <720000000>; > opp-microvolt = <900000>; > clock-latency-ns = <244144>; /* 8 32k periods */ > - opp-supported-hw = <0x0d>; > + opp-supported-hw = <0x2d>; > }; > > opp-792000000 { > @@ -50,8 +50,16 @@ opp-1008000000 { > opp-microvolt-speed2 = <950000>; > opp-microvolt-speed3 = <950000>; > opp-microvolt-speed4 = <1020000>; > + opp-microvolt-speed5 = <900000>; > clock-latency-ns = <244144>; /* 8 32k periods */ > - opp-supported-hw = <0x1f>; > + opp-supported-hw = <0x3f>; > + }; > + > + opp-1032000000 { > + opp-hz = /bits/ 64 <1032000000>; > + opp-microvolt = <900000>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + opp-supported-hw = <0x20>; > }; > > opp-1104000000 { > @@ -59,8 +67,9 @@ opp-1104000000 { > opp-microvolt-speed0 = <1000000>; > opp-microvolt-speed2 = <1000000>; > opp-microvolt-speed3 = <1000000>; > + opp-microvolt-speed5 = <950000>; > clock-latency-ns = <244144>; /* 8 32k periods */ > - opp-supported-hw = <0x0d>; > + opp-supported-hw = <0x2d>; > }; > > opp-1200000000 { > @@ -70,8 +79,9 @@ opp-1200000000 { > opp-microvolt-speed2 = <1050000>; > opp-microvolt-speed3 = <1050000>; > opp-microvolt-speed4 = <1100000>; > + opp-microvolt-speed5 = <1020000>; > clock-latency-ns = <244144>; /* 8 32k periods */ > - opp-supported-hw = <0x1f>; > + opp-supported-hw = <0x3f>; > }; > > opp-1320000000 { > @@ -85,15 +95,16 @@ opp-1416000000 { > opp-hz = /bits/ 64 <1416000000>; > opp-microvolt = <1100000>; > clock-latency-ns = <244144>; /* 8 32k periods */ > - opp-supported-hw = <0x0d>; > + opp-supported-hw = <0x2d>; > }; > > opp-1512000000 { > opp-hz = /bits/ 64 <1512000000>; > opp-microvolt-speed1 = <1100000>; > opp-microvolt-speed3 = <1100000>; > + opp-microvolt-speed5 = <1160000>; > clock-latency-ns = <244144>; /* 8 32k periods */ > - opp-supported-hw = <0x0a>; > + opp-supported-hw = <0x2a>; > }; > }; > };