From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58594C27C53 for ; Wed, 19 Jun 2024 13:33:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MD+D1y+GrJcG8JPVcDvXcrczcgggdHe/LVKDHJFnlHQ=; b=jLwrIefEpVEfeSAzoapRX6DClj 2lyKsytpGyChiLL1hyPdq84VEOVvJw9JgdKplyVG8se2bTNXxQuatEQRJJsjLvPZZ+jOI+kLckJg2 v3mZLFGC/i+8+TxbhLVREp91UwULGFVmqKCXUCyDdIWuP1ah3RHNStc4ykx6ZquXGtgunS2Q5JcEY ZZnmucdmrpm/8hia689CNZSbfYPTLmYppLgtkE0ekU5njnahad7mlVIcqPcaXXIZ3xCx6/sJLopjU QRp8wkPgUF8jswuxZNFrSarmFXCvW9Kr4wBTCLnnFS/BpQKTdBvUle5yL57VIYkj7C8mTI0+tVZPS +AJV99oQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJvR1-00000001Knb-0P4q; Wed, 19 Jun 2024 13:33:11 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJvQy-00000001KmX-0yBx for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2024 13:33:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 15C31CE1E42; Wed, 19 Jun 2024 13:33:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97689C32786; Wed, 19 Jun 2024 13:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718803984; bh=cXx5NUHhqlxc6cafd7sTdps6tZxJqDAhS3XY1Phuj1M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pzhczgTIRyBDNWGzGauAT3G2Oej6hlyTNTfHpbprV5+PvMZLyrueFIbhOSvAwJweg 6RrF4IbERvR3V4w4Fb39anT/pU1NfWMYahU/fBJcMQCNb7kj9126OIRnn/+htT3G5w sCUUpoUrTQvLEmSJGtugOzPJk+AGAolkSYIampZrWKI2nDWX8TEJgv+ApvIER9gZtu j0eX985u/AnuLSqxL/Nt4V+9+jueBT38OcqFZWg1YI8hbDzpvuQyrG+6X8pnWv2Mvx LEaKidLVBAeg8KzoP2yZFl0+Gj/nQo/uIB37ZuSUVS0vCAvKbTw0BHp6zNkeP1/Th3 NLumK4yOWWnUg== Date: Wed, 19 Jun 2024 14:32:59 +0100 From: Will Deacon To: Jinjie Ruan Cc: catalin.marinas@arm.com, mark.rutland@arm.com, dianders@chromium.org, swboyd@chromium.org, sumit.garg@linaro.org, frederic@kernel.org, scott@os.amperecomputing.com, misono.tomohiro@fujitsu.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: smp: Fix missing IPI statistics Message-ID: <20240619133258.GA3526@willie-the-truck> References: <20240607074716.4068975-1-ruanjinjie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240607074716.4068975-1-ruanjinjie@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240619_063308_474702_D82FCD17 X-CRM114-Status: GOOD ( 20.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 07, 2024 at 03:47:16PM +0800, Jinjie Ruan wrote: > commit 83cfac95c018 ("genirq: Allow interrupts to be excluded from > /proc/interrupts") is to avoid IPIs appear twice in /proc/interrupts. > But the commit 331a1b3a836c ("arm64: smp: Add arch support for backtrace > using pseudo-NMI") and commit 2f5cd0c7ffde("arm64: kgdb: Implement > kgdb_roundup_cpus() to enable pseudo-NMI roundup") set CPU_BACKTRACE and > KGDB_ROUNDUP IPIs "IRQ_HIDDEN" flag but not show them in > arch_show_interrupts(), which cause the interrupt kstat_irqs accounting > is missing in display. > > Fixes: 331a1b3a836c ("arm64: smp: Add arch support for backtrace using pseudo-NMI") > Signed-off-by: Jinjie Ruan > --- > arch/arm64/kernel/smp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > index 31c8b3094dd7..7f9a5cf0f3b8 100644 > --- a/arch/arm64/kernel/smp.c > +++ b/arch/arm64/kernel/smp.c > @@ -1039,7 +1039,8 @@ void __init set_smp_ipi_range(int ipi_base, int n) > } > > ipi_desc[i] = irq_to_desc(ipi_base + i); > - irq_set_status_flags(ipi_base + i, IRQ_HIDDEN); > + if (i < NR_IPI) > + irq_set_status_flags(ipi_base + i, IRQ_HIDDEN); > } Please can you show the contents of /proc/interrupts before and after this patch and put that in the commit message? I'm not seeing how the two new IPIs get picked up by arch_show_interrupts(). Thanks, Will