From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1DEEC27C79 for ; Wed, 19 Jun 2024 13:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9HwMeBhVPqwTPDRBqhATty1XaDccZTZc82ksGzhhOTg=; b=2ElMnL/hkFJYiUuU2nUl+KDuto 0kTYm5/fmwqPNqWf99GCLeGS8E9K1qGFNGXY7C7JIt7vU8kb9oqFKUni3NdEVyV/GCHuTLcYl6kNp 0bx6FGrNhYxc45F1FszWWdaIuy+XydNByaTl2icB0gAMPwLyeuiIr4k8iVGQliatFKHHqBei5MtjT YnsKMsFp6QNjTmiupvpxderR7aKs+o9PlQ6Ndz3qmjTF+FJJSv9n7+LbLMMhwUhMr51IwENiMTsFs uguSqZtInOMD3BDXdXreFGOSLcADqM3dZm1Ev5I1HUlELP0ftWVQMfgSh3ENIYjruVf8FA1mUtTrq B27Vpkjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJvoE-00000001Ook-3HeJ; Wed, 19 Jun 2024 13:57:10 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJvoA-00000001OnD-0SYX for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2024 13:57:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CB6DCCE1EF6; Wed, 19 Jun 2024 13:57:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31722C4AF09; Wed, 19 Jun 2024 13:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718805423; bh=TyaQfQKJsGMA8keYr1hp7wYXz2EM065ExSkm3viI+o0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R/deu9VxpmCRDGd5dFsoRTcU1BnrqE6yXALbINS2b8zmXpVUYfA3YwgZq9EoaSDWR Sdix+N/JuEfjl+pj/iryCgzyKNHeExXb2Gcl72tfy4ykcOPO3rV9STDfdpwNW0LprM mOv4pWKLZOZbEZMgKiSXmDX8Z0bjIL6qzBo7lED7N9fNEVaQEXdj+pqlUHYQj5QNX1 I/4sQFs9LPuL9ktiDy8px+KyQDdDjGZaj+yWEvsLUYJRr7gFY4LyujuXG1KnooPZZy j6a7/vvEgYszliFfX3Yzfbj6/NGLRk3UhuGw6hyMh7ipeYdiMLqCtfj0Qps2RBDrzE zhxLBVbgeanAw== Date: Wed, 19 Jun 2024 14:56:56 +0100 From: Simon Horman To: Christophe Roullier Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown , Marek Vasut , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [net-next,PATCH v2 2/2] net: stmmac: dwmac-stm32: stm32: add management of stm32mp25 for stm32 Message-ID: <20240619135656.GG690967@kernel.org> References: <20240617154516.277205-1-christophe.roullier@foss.st.com> <20240617154516.277205-3-christophe.roullier@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240617154516.277205-3-christophe.roullier@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240619_065706_351366_C359B543 X-CRM114-Status: GOOD ( 18.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 17, 2024 at 05:45:16PM +0200, Christophe Roullier wrote: > Add Ethernet support for STM32MP25. > STM32MP25 is STM32 SOC with 2 GMACs instances. > GMAC IP version is SNPS 5.3x. > GMAC IP configure with 2 RX and 4 TX queue. > DMA HW capability register supported > RX Checksum Offload Engine supported > TX Checksum insertion supported > Wake-Up On Lan supported > TSO supported > > Signed-off-by: Christophe Roullier The nit below notwithstanding, this looks good to me, and appears to address review of earlier versions. Reviewed-by: Simon Horman > --- > .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 77 ++++++++++++++++++- > 1 file changed, 74 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c ... > @@ -365,6 +423,9 @@ static int stm32_dwmac_parse_data(struct stm32_dwmac *dwmac, > return err; > } > > + if (dwmac->ops->is_mp2) > + return err; > + nit: As far as I understand things, the intention here is to return early, rather than to return an error. And err will always be 0. So it might be clearer to simply: return 0; > dwmac->mode_mask = SYSCFG_MP1_ETH_MASK; > err = of_property_read_u32_index(np, "st,syscon", 2, &dwmac->mode_mask); > if (err) { ...