From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27570C27C79 for ; Wed, 19 Jun 2024 15:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gC7WNA1QA+YwkrX8gjXlglJDeCpaBidYafu3xduhGfM=; b=EFK6Fy5RQkeSz3nXep6b3sTiYs mdEGwfweUM3pqwO+cJ0HAWJ6vwRdVHVvQ4GD3fDoiaOXsbUBSGytwH55QqlXhd0i97nSFeKEDwDMP 3bM3IVspHAs7X08t04DGwbaW7zAdbqLgKaMd//tGDisN26ds7hCczxpJih3XMn13gIUhHXAHWnZ07 2GYwyIgx4/Tn4YTkkMu3gcNbMmUdJmJXG5xrLrlbcM5Gv2plkmAkPg0CPM++59mnxCxsrxtzJF6aJ uzZB/DrKnjtcF96fhc2KKHwSOVDSvtStRHPxTDozrvpUBlPSgSB/+kLcOc/EpIbOSsuR01oS1muh1 UhOjIhDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJx3h-00000001lp7-2Fl8; Wed, 19 Jun 2024 15:17:13 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJx3e-00000001lnr-1Dwx for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2024 15:17:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718810228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gC7WNA1QA+YwkrX8gjXlglJDeCpaBidYafu3xduhGfM=; b=fyLFgHhyfVrmhLrE5H8e5iR7zGf5xlsKfVcQJpknIcoqSkM67TXfw6jMb9slLbfUQpTYyr mPLODQYaVT0rZvIBsuvIRiEWGzf7bZL57VDp28TFUm3VZrsFJrX2POgvhZiETdVc+PgKva aTyu2T1fg+VUcMGscuMkp4vu8In0mV4= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-xiTvddoYPcSYiaLGHLgSeQ-1; Wed, 19 Jun 2024 11:17:04 -0400 X-MC-Unique: xiTvddoYPcSYiaLGHLgSeQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 09CA41955E82; Wed, 19 Jun 2024 15:17:02 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.168]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 5D1551956087; Wed, 19 Jun 2024 15:16:56 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 19 Jun 2024 17:15:30 +0200 (CEST) Date: Wed, 19 Jun 2024 17:15:24 +0200 From: Oleg Nesterov To: Tiezhu Yang Cc: Will Deacon , Mark Rutland , Catalin Marinas , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: hw_breakpoint: Save privilege of access control via ptrace Message-ID: <20240619151524.GB24240@redhat.com> References: <20240618071010.11214-1-yangtiezhu@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240618071010.11214-1-yangtiezhu@loongson.cn> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240619_081710_443307_145E9738 X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I don't understand what this patch does, but... On 06/18, Tiezhu Yang wrote: > > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -467,6 +467,7 @@ struct perf_event_attr { > __u32 wakeup_watermark; /* bytes before wakeup */ > }; > > + __u8 bp_priv; > __u32 bp_type; Is it safe to add the new member in the middle of uapi struct? This will break userspace... Oleg.