From: "Marek Behún" <kabel@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Gregory Clement" <gregory.clement@bootlin.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org, arm@kernel.org,
"Andy Shevchenko" <andy@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH 1/4] irqchip/armada-370-xp: Do not allow mapping IRQ 0 and 1
Date: Wed, 19 Jun 2024 21:25:09 +0200 [thread overview]
Message-ID: <20240619212509.7008b115@thinkpad> (raw)
In-Reply-To: <3bff3312-ce49-4f7f-9bcc-7127fa43070b@lunn.ch>
On Wed, 19 Jun 2024 19:08:04 +0200
Andrew Lunn <andrew@lunn.ch> wrote:
> On Wed, Jun 19, 2024 at 04:11:31PM +0200, Marek Behún wrote:
> > From: Pali Rohár <pali@kernel.org>
> >
> > IRQs 0 (IPI) and 1 (MSI) are handled internally by this driver,
> > generic_handle_domain_irq() is never called for these IRQs.
> >
> > Disallow mapping these IRQs.
> >
> > Fixes: 344e873e5657 ("arm: mvebu: Add IPI support via doorbells")
> > Fixes: 31f614edb726 ("irqchip: armada-370-xp: implement MSI support")
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > [ changed commit message, added Fixes tags ]
> > Signed-off-by: Marek Behún <kabel@kernel.org>
>
> Is this needed in stable? Is the problem being fixed a real bug that
> bothers people?
Not as far as I know, but I have been asked to add Fixes tag for less.
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>
> If you would like this back ported in stable, please post it as a
> separate patch. Otherwise it can be kept as part of the series. The
> Fixes: might result in it being backported anyway.
I don't need it backported. Semantically it is a fix, but it doesn't
bother anyone.
I will post v2 without the Fixes tags.
Marek
next prev parent reply other threads:[~2024-06-19 19:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 14:11 [PATCH 0/4] armada-370-xp irqchip updates Marek Behún
2024-06-19 14:11 ` [PATCH 1/4] irqchip/armada-370-xp: Do not allow mapping IRQ 0 and 1 Marek Behún
2024-06-19 17:08 ` Andrew Lunn
2024-06-19 19:25 ` Marek Behún [this message]
2024-06-19 14:11 ` [PATCH 2/4] irqchip/armada-370-xp: Exit ipi_resume() early if IPI is not used Marek Behún
2024-06-19 17:11 ` Andrew Lunn
2024-06-19 19:27 ` Marek Behún
2024-06-19 14:11 ` [PATCH 3/4] irqchip/armada-370-xp: Do not touch IPI registers on platforms without IPI Marek Behún
2024-06-19 17:17 ` Andrew Lunn
2024-06-19 14:11 ` [PATCH 4/4] irqchip/armada-370-xp: Add support for 32 MSI interrupts on non-IPI platforms Marek Behún
2024-06-19 17:21 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619212509.7008b115@thinkpad \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=andy@kernel.org \
--cc=arm@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=pali@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).