From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA74EC27C53 for ; Wed, 19 Jun 2024 08:13:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y2NwcadAPGpMgLXymCk4uwfXYhN5YmxaMbhuX0jJAls=; b=pBWplP5/Di9WwLDjc26OwVN7Zq 9mHNZYTtHb9bCPnwFkFZL0RYdTyHIfEDC7+/KKsBi2pQaNfDEHF+mhaBsXoe8HwecCxjx7a8zC2Qk 731ZYVe4cGA0Y2uzEiWs4zMvDwOma9xxpD75B2KEd9EZKFCJu8Pl3LdYiJ7ggt2qMK57/1n20qMAa Y8ja9C/8miyi9K9ydD/J1tz7MuOV1HPN4Edv5/XIrPMa0+AZ/zJ9rLAGAGwZL3qz8Gfpo4d+OOHKg SS//kL8Ls4iU1V+FLpTXkOfywvhQwgvRz6rsE2LH2lAllH2eNJoRxYIzb4Wzp82YOKR+LBDu1xKJi yTDz9qVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJqRA-00000000LTL-3HCQ; Wed, 19 Jun 2024 08:13:00 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJqR7-00000000LSY-21tA for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2024 08:12:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7BA3ECE1C97; Wed, 19 Jun 2024 08:12:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 390ECC2BBFC; Wed, 19 Jun 2024 08:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718784774; bh=d22ozv8UZzsbdeCLyzbmyCDhwksXbO4tqNyJiRNzVpM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FRxw+0cDYZFJozbRUuujZdkbvcFzUBdF99vdYElj/iTAhc2AmqbsuXU4OhghUY0V2 cY+wdFFl+mpsiRarjMYjdBdXpoBDovhiv5K+JJahLex4yeoYkuPRRrMJlIai0FDMoc 0sCElbyU81+aJIT2xLdwj91jyQjXxJ3UF/qOa/kQ= Date: Wed, 19 Jun 2024 10:12:51 +0200 From: Greg Kroah-Hartman To: Markus Elfring Cc: Jie Gan , coresight@lists.linaro.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alexander Shishkin , Konrad Dybcio , Krzysztof Kozlowski , Mathieu Poirier , Mike Leach , Rob Herring , Suzuki Poulouse , LKML , Bjorn Andersson , Jinlong Mao , Song Chai , Tao Zhang , Tingwei Zhang , Trilok Soni , Yuanfang Zhang , quic_liuxin@quicinc.com, quic_sijiwu@quicinc.com, quic_xinlon@quicinc.com, quic_xueqnie@quicinc.com, quic_yanzl@quicinc.com, quic_yijiyang@quicinc.com, quic_yuanjiey@quicinc.com Subject: Re: [PATCH 2/3] coresight: Add coresight slave register driver to support data filter function in sysfs mode Message-ID: <2024061947-street-italics-0cdf@gregkh> References: <20240618072726.3767974-3-quic_jiegan@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240619_011257_963735_9854CBBD X-CRM114-Status: GOOD ( 15.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 19, 2024 at 09:55:25AM +0200, Markus Elfring wrote: > … > > +++ b/drivers/hwtracing/coresight/coresight-csr.c > > @@ -0,0 +1,315 @@ > … > > +static int __csr_set_etr_traceid(struct coresight_device *csdev, > > + uint32_t atid_offset, uint32_t traceid, > > + bool enable) > > +{ > … > > + spin_lock_irqsave(&drvdata->spin_lock, flags); > > + CS_UNLOCK(drvdata->base); > … > > + CS_LOCK(drvdata->base); > > + spin_unlock_irqrestore(&drvdata->spin_lock, flags); > > + return 0; > > +} > … > > Would you become interested to apply a statement like “guard(spinlock_irqsave)(&drvdata->spin_lock);”? > https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/spinlock.h#L574 Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot