Re: [PATCH v3 04/14] drm/mediatek: Fix XRGB setting error in Mixer

Shawn Sung (宋孝謙)
2024-10-09T06:29:48Z

On Mon, 2024-10-07 at 13:36 +0200, Markus Elfring wrote:
> > Although the alpha channel in XRGB formats can be ignored,
> > ALPHA_CON
> > must be configured accordingly when using XRGB formats or it will
> > still
> > affects CRC generation.
>
> affect?

Yes, didn't notice that.
This is a typo, but the series has been merged.

>
>
> Can such a change description become a bit nicer with an additional
> imperative wording?
>
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n94

Honestly, I wasn't familiar with the term "imerative mood" before this.
After studying it, I now understand. Thank you for pointing this out; I
will keep this in mind for the future.

As a result, I asked AI to refine the description using imperative
wording as a reference example:

"Ensure that ALPHA_CON is configured appropriately when using XRGB
formats, even though the alpha channel can be ignored. Failing to do so
will affect CRC generation."

Regards,
Shawn
>
> Regards,
> Markus