From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D70D6C2BA18 for ; Thu, 20 Jun 2024 08:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=b1BHsBjPkj6FAsZwIvDy83LH1YkspQYgGMfz94Unkvc=; b=y3xcG2KyGbHAEvKTdJdHiVaI8J 6a+M3L9sNs1XVTeqSxRIkM21O1vBR0P//3KygSf6RMS5bdRMQ9fAKosCyQQQDieIdaegRbqaDrCvg MTi849HErPfTDR0EN+dBwN+yFuWfB97jXeDJkzYP9JHcGWp/2yKNQ6B7AwkCMYieO6eZLXknxNuIn ugppMTJUaNyOWqVJOmu+sAFJOwoYRDVpfsEGcA/1s1ekcm0QKaFOX0tq0cMr2JzomIPYM48YmxXGh UYTABEfpjh9hwS2SX6WxWLNsVUBYGV65gRtI2QtGTG0dbnYrHU4j1bFBoTl9Rq+6lbOCV/5+Bfle2 93exSNKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKDPi-00000004E0I-0ssP; Thu, 20 Jun 2024 08:45:02 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKDPf-00000004DxN-1f5c for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2024 08:45:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 46042CE2050; Thu, 20 Jun 2024 08:44:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 309ECC2BD10; Thu, 20 Jun 2024 08:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718873096; bh=g9sCHOwPXjh8FEzTD/8HrE3pyN+mCBZy4wtJBPu7b7U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KF1lig/HOJVi8YdqwyKDsPovl8wMVEneFLEOEmECkeLiFt9vTvQwyKINK8+IfIuwI yGw5HXHSFkwivUMmwgTH4XQxfhlV1cdKKarV+k6DR/k2dKZIJtJ3BPyrwp9u63HAbH kTxSOnSrHfVeUG6OGkfSgbMFgYfRohuiGDLDQaBiokltB7oPRkL3wNyTql7xAQDp2y JPa8cj9BrXw02ZnqMr2Me4pe9pQ1eLPOIxThDyoHDwNSuatEq9CvITiHHbrkZwmUaz PZsfw6HqGgt0A933CT5c5fljlAASg9+LsVUiHaeDM++b/gXiUAvfAIg4oB0pguevpc 9jQu4eF9f3JBA== Date: Thu, 20 Jun 2024 09:44:51 +0100 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Fabrice Gasnier , William Breathitt Gray , Maxime Coquelin , Alexandre Torgue , linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thorsten Scherer Subject: Re: [PATCH v2 3/5] counter: stm32-timer-cnt: Use TIM_DIER_CCxIE(x) instead of TIM_DIER_CCxIE(x) Message-ID: <20240620084451.GC3029315@google.com> References: <126bd153a03f39e42645573eecf44ffab5354fc7.1718791090.git.u.kleine-koenig@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <126bd153a03f39e42645573eecf44ffab5354fc7.1718791090.git.u.kleine-koenig@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_014459_677071_BE0D3846 X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 19 Jun 2024, Uwe Kleine-König wrote: > These two defines have the same purpose and this change doesn't > introduce any differences in drivers/counter/stm32-timer-cnt.o. > > The only difference between the two is that > > TIM_DIER_CC_IE(1) == TIM_DIER_CC2IE > > while > > TIM_DIER_CCxIE(1) == TIM_DIER_CC1IE > > . That makes it necessary to have an explicit "+ 1" in the user code, > but IMHO this is a good thing as this is the code locatation that > "knows" that for software channel 1 you have to use TIM_DIER_CC2IE > (because software guys start counting at 0, while the relevant hardware > designer started at 1). > > Signed-off-by: Uwe Kleine-König > --- > drivers/counter/stm32-timer-cnt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Did you drop William's Ack on purpose? -- Lee Jones [李琼斯]