From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44323C27C79 for ; Thu, 20 Jun 2024 09:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uFCMGrlSeHdQyohcUGcdM5GmiohRIWASdED+XbIQyJk=; b=ldEGVb45MIPjokOaw2MAKZolVs qyXgV4M9xPWGoGbsAcQmS5U6EAnv5t1TYf/UvjUgKcc2LhK3UfREg7paDrlmvWNVGv3GFw2c4pYZY 60jkK1lnVC+Zz9QhQZZwUc+i5EdmudzLXFPwovV3pQNrkMb7ZQ9sII5eAdonsvBkPf0/3HP/ZruGo 8LEZT+Fw55j0NYDIdoh/+amfSJalBRz1ohmy+IOp21qiEbwkHEfLf8YH3TH2w2c6QULLG3ILHERkW 6uJGYqbByIX5UGaACpPYYOzUjXKDl1clbDun4vNNSZbqV9tOXAurloupsXxlGGRpk7M23cMTLAQcK RecCozpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKE9l-00000004Ove-2D22; Thu, 20 Jun 2024 09:32:37 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKE9i-00000004Oux-2pgV for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2024 09:32:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C14E7CE1D15; Thu, 20 Jun 2024 09:32:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5B89C2BD10; Thu, 20 Jun 2024 09:32:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718875952; bh=O/Et+olhzP5XobD8bdj3w1CIIC0vknNGVO0piDAW26s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EtrvQbvjvB3OlS0NqQVMZ78pc5yjJBlgxYROJaDdmAeUuwpZ8PiDoIYaZiiohLS/m dqJQcp+fiJC0KNtb5Fs1T5S3WX79Ftgk5Y8xP62GafReVKgi1HtoSGJo7HXCJb/ihD sq4+4RX9VfZBaAld4D2usmp06jkDelxewiIrEbdiY1JcRlhyizfGiKXR1apqEHkWvZ Eb8ELdwoKiR/1DVZMqNE6V2lE3zd6kDsrDhZ5kom+uoxBCnIFNlgJSdHNlAeDkpyrM yTK1Im4WXdZJSlwXXKMmTJpW2s+/7eteThN+IyFz4jcV0KfbPEy7p33D5fwS80kinE NwQ91k8PEhPlw== Date: Thu, 20 Jun 2024 10:32:27 +0100 From: Lee Jones To: William Breathitt Gray Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thorsten Scherer Subject: Re: [PATCH v2 3/5] counter: stm32-timer-cnt: Use TIM_DIER_CCxIE(x) instead of TIM_DIER_CCxIE(x) Message-ID: <20240620093227.GI3029315@google.com> References: <126bd153a03f39e42645573eecf44ffab5354fc7.1718791090.git.u.kleine-koenig@baylibre.com> <20240620084451.GC3029315@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_023235_019984_E309FAC6 X-CRM114-Status: GOOD ( 22.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 20 Jun 2024, William Breathitt Gray wrote: > On Thu, Jun 20, 2024 at 09:44:51AM +0100, Lee Jones wrote: > > On Wed, 19 Jun 2024, Uwe Kleine-König wrote: > > > > > These two defines have the same purpose and this change doesn't > > > introduce any differences in drivers/counter/stm32-timer-cnt.o. > > > > > > The only difference between the two is that > > > > > > TIM_DIER_CC_IE(1) == TIM_DIER_CC2IE > > > > > > while > > > > > > TIM_DIER_CCxIE(1) == TIM_DIER_CC1IE > > > > > > . That makes it necessary to have an explicit "+ 1" in the user code, > > > but IMHO this is a good thing as this is the code locatation that > > > "knows" that for software channel 1 you have to use TIM_DIER_CC2IE > > > (because software guys start counting at 0, while the relevant hardware > > > designer started at 1). > > > > > > Signed-off-by: Uwe Kleine-König > > > --- > > > drivers/counter/stm32-timer-cnt.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Did you drop William's Ack on purpose? > > > > -- > > Lee Jones [李琼斯] > > No problem, here it is again for the sake of the LKML scraper tools: > > Acked-by: William Breathitt Gray > > Lee, do you prefer taking this patchset through your tree? I think that would make things easier. A pull-request for you and the PWM folk would follow. -- Lee Jones [李琼斯]