From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C774C27C79 for ; Thu, 20 Jun 2024 17:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5U6MyExDzmt+O4baTehDdPjrIBPEdNk8UzV+UsVen24=; b=SqnCn07aFOnsUd2UQzi9Y1m4/z Q+ElIgN1rTVDgsaztHllb/So4EIZbvRB6zPbdhsRR0gnQ25qF9gieVc/FqaY8S+7+HQurvoE5xiLU vL57zqn/H+uxdTuKxoLywmoOU/N8h5jUYngOqE75FHDpkbdcYXyoPn+cXDPEBiREY2L2XNGLAbBC3 lBuyXOrx3ESkmcSA4hBudR5x41/Pc8hajX0zOjiXxJ+xyWz2cMRxhjzENIIgQ88VMJRyQi+XqHGEJ SW4GGdTnwmvz3budeb/vUtSFLk072RMzW6Ia5Z2jal74sX3v2r+l98Rk7JJu0YyALfudxHgK0p6T0 Ec2palww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKLkJ-000000066QB-339c; Thu, 20 Jun 2024 17:38:51 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKLkC-000000066MN-2EO6 for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2024 17:38:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8FB3362238; Thu, 20 Jun 2024 17:38:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16421C32786; Thu, 20 Jun 2024 17:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718905123; bh=eu4204Po9QE0cYQjUDURrwCjSksfyHPOc0038gSWWEo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lDAK5onKrqnhU5bYs5axr1F0ZcK/BSq0+01f/D2Yvr21A0lXiv+VFAHRgHFt/qumm KfxMCVqD1+T2Zx5DCCrefKTtncP9krvMzuY1zmPG8s68s89wpWPf1atPZxaunBkdCj 83fSnFHmJUGy5ddv/1hbrhHKDtj5vNYPNhR1ybXn9geYDP96R+huEH5tlitVltQpx0 s4zrvbC2Pv3P/MIj0w4FfSjQrKA6yZZx+XD4Hhf5eaYesvuL/sgnENd2O0cwYaOZeR FrEB8k1ug51kAo8Y8R3KD/EqjVKvTpisZGmwJpvW6/p3wjQmUQRQir1Z2HJPO7v0W3 kFXmQLFHdRBAg== Date: Thu, 20 Jun 2024 18:38:38 +0100 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Fabrice Gasnier , William Breathitt Gray , Maxime Coquelin , Alexandre Torgue , linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thorsten Scherer Subject: Re: [PATCH v2 3/5] counter: stm32-timer-cnt: Use TIM_DIER_CCxIE(x) instead of TIM_DIER_CCxIE(x) Message-ID: <20240620173838.GB1318296@google.com> References: <126bd153a03f39e42645573eecf44ffab5354fc7.1718791090.git.u.kleine-koenig@baylibre.com> <20240620084451.GC3029315@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_103844_671505_1529D3AA X-CRM114-Status: GOOD ( 25.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 20 Jun 2024, Uwe Kleine-König wrote: > Hello Lee, > > On Thu, Jun 20, 2024 at 09:44:51AM +0100, Lee Jones wrote: > > On Wed, 19 Jun 2024, Uwe Kleine-König wrote: > > > > > These two defines have the same purpose and this change doesn't > > > introduce any differences in drivers/counter/stm32-timer-cnt.o. > > > > > > The only difference between the two is that > > > > > > TIM_DIER_CC_IE(1) == TIM_DIER_CC2IE > > > > > > while > > > > > > TIM_DIER_CCxIE(1) == TIM_DIER_CC1IE > > > > > > . That makes it necessary to have an explicit "+ 1" in the user code, > > > but IMHO this is a good thing as this is the code locatation that > > > "knows" that for software channel 1 you have to use TIM_DIER_CC2IE > > > (because software guys start counting at 0, while the relevant hardware > > > designer started at 1). > > > > > > Signed-off-by: Uwe Kleine-König > > > --- > > > drivers/counter/stm32-timer-cnt.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Did you drop William's Ack on purpose? > > Yes, because a) I was unsure what he didn't like about the subject, and > (more importantly) b) I split the patch in question. I should have > written that in the cover letter, sorry. > > (Note I only announced to have fixed the subject prefix of the pwm > patch. I assume you won't include that in your pull request, but if you > do, please do s/-/: / on it. That's another thing I failed with for this > series.) Which patches need to be in the pull-request and which can be hoovered up by their associated subsystems? -- Lee Jones [李琼斯]