From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD567C27C79 for ; Thu, 20 Jun 2024 17:19:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:To:From: Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6HKwLFpOQJzhN2+bpXmHjR3V9//mN4V0ElrLJbo8UOo=; b=ewIlTpxPI9KZoyH/2EzXuJi3ym RrLCCeRvuxo/h3BaMpRkPT3tNrzPjYv9sVX4XyXsOMMyVPSs7UWp0Kpld4vZP4sozNceoO5Ez+/3l mLlHKmfgdhI9szmRtY/niThK2ImYjJoaalA6nXLQp8syfRNpag9mMd6OSQi9CXw3u3QCpM4h9IdJ3 o1fFUqmqP1OgAWfumKJlZpbx+26HZ4S7WPcBHwMG/CdXSe228hpd9q9cBAmGAng/u903NZ3DlvMJa aECc1QNEQpEps10mVFDOB/qOknFJ5A0Xj23B8kEPVQciGDsWiH9wneNNRDXjpV1sHrlOjqVKduvN6 hcHb2cDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKLRh-000000061mZ-0j9x; Thu, 20 Jun 2024 17:19:37 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKLRd-000000061jX-0lyQ for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2024 17:19:35 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 4996940002; Thu, 20 Jun 2024 17:19:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1718903968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6HKwLFpOQJzhN2+bpXmHjR3V9//mN4V0ElrLJbo8UOo=; b=onNLPtUC8hcLlTUZP2ijmtuTvPuCiZXtx4goHw82layaODRfq6Sxhms5AqfW/+tASAF5NB BdvEXZbn0qev8NHoDoGzbhcagb83Wnm1sxwKgGccr2hCSY+yT+T7BCAF8Qj7e3t1550TTc qfy6z1i7Raurhx78cG16fjYN9PXbteuzONUQduhXpJqh9jhiGVWiXe1jJ6SieBwmMglT0D 1Sqt81uFySKMA6xANHzjHtcKuF1dQPtq+O0vaQww+dOm3+xBgOV1IDPOtP2H5meHQNXwCZ j4CxDegBAA/pDn7gWnH26osDI0Acq8GheckEUgownkF6icLtkTu2dVc1HFjtNg== Date: Thu, 20 Jun 2024 19:19:23 +0200 From: Herve Codina To: Andy Shevchenko , Simon Horman , Sai Krishna Gajula , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lee Jones , Arnd Bergmann , Horatiu Vultur , UNGLinuxDriver@microchip.com, Andrew Lunn , Heiner Kallweit , Russell King , Saravana Kannan , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , Alexandre Belloni , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v2 18/19] mfd: Add support for LAN966x PCI device Message-ID: <20240620191923.3d62c128@bootlin.com> In-Reply-To: <20240620184309.6d1a29a1@bootlin.com> References: <20240527161450.326615-1-herve.codina@bootlin.com> <20240527161450.326615-19-herve.codina@bootlin.com> <20240620175646.24455efb@bootlin.com> <20240620184309.6d1a29a1@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_101933_512286_2354D6A9 X-CRM114-Status: GOOD ( 39.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, On Thu, 20 Jun 2024 18:43:09 +0200 Herve Codina wrote: > My bad, I wrongly answered first in private. > I already eesend my answers with people in Cc > > Now, this is the Andy's your reply. > > Sorry for this mistake. > > Herve > > On Thu, 20 Jun 2024 18:07:16 +0200 > Andy Shevchenko wrote: > > > On Thu, Jun 20, 2024 at 5:56 PM Herve Codina wrote: > > > On Wed, 5 Jun 2024 23:24:43 +0300 > > > Andy Shevchenko wrote: > > > > Mon, May 27, 2024 at 06:14:45PM +0200, Herve Codina kirjoitti: > > > > ... > > > > > > > + if (!dev->of_node) { > > > > > + dev_err(dev, "Missing of_node for device\n"); > > > > > + return -EINVAL; > > > > > + } > > > > > > > > Why do you need this? The code you have in _create_intr_ctrl() will take care > > > > already for this case. > > > > > > The code in _create_intr_ctrl checks for fwnode and not an of_node. > > > > > > The check here is to ensure that an of_node is available as it will be use > > > for DT overlay loading. > > > > So, what exactly do you want to check? fwnode check covers this. > > > > > I will keep the check here and use dev_of_node() instead of dev->of_node. > > > > It needs to be well justified as from a coding point of view this is a > > duplication. On DT based system, if a fwnode is set it is an of_node. On ACPI, if a fwnode is set is is an acpi_node. The core PCI, when it successfully creates the DT node for a device (CONFIG_PCI_DYNAMIC_OF_NODES) set the of_node of this device. So we can have a device with: - fwnode from ACPI - of_node from core PCI creation This driver needs the of_node to load the overlay. Even if the core PCI cannot create a DT node for the PCI device right now, I don't expect this LAN855x PCI driver updated when the core PCI is able to create this PCI device DT node. > > > > ... > > > > > > > + pci_set_master(pdev); > > > > > > > > You don't use MSI, what is this for? > > > > > > DMA related. > > > Allows the PCI device to be master on the bus and so initiate transactions. > > > > > > Did I misunderstood ? > > > > So, you mean that the PCI device may initiate DMA transactions and > > they are not related to MSI, correct? That's my understanding. Right now, the internal LAN966x DMA controller is not used but it will be used in a near future. > > > > ... > > > > > > > +static struct pci_device_id lan966x_pci_ids[] = { > > > > > + { PCI_DEVICE(0x1055, 0x9660) }, > > > > > > > > Don't you have VENDOR_ID defined somewhere? > > > > > > No and 0x1055 is taken by PCI_VENDOR_ID_EFAR in pci-ids.h > > > but SMSC acquired EFAR late 1990's and MCHP acquired SMSC in 2012 > > > https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/microchip/lan743x_main.h#L851 > > > > > > I will patch pci-ids.h to create: > > > #define PCI_VENDOR_ID_SMSC PCI_VENDOR_ID_EFAR > > > #define PCI_VENDOR_ID_MCHP PCI_VENDOR_ID_SMSC > > > As part of this patch, I will update lan743x_main.h to remove its own #define > > > > > > And use PCI_VENDOR_ID_MCHP in this series. > > > > Okay, but I don't think (but I haven't checked) we have something like > > this ever done there. In any case it's up to Bjorn how to implement > > this. Right, I wait for Bjorn reply before changing anything. Best regards, Hervé