From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2CDCC27C4F for ; Fri, 21 Jun 2024 11:26:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i8sLZv1n+Ku2QMjcmS+4EdIPRc6Cam45MqmcajWwNAI=; b=VNycqK5u/v5h/XqU+194rKdhSG FJDWm7vEOWh6YqI+5A1gJ/BDhy+P2Ksz7Ra4wgNYOdl7/ty5Sd5XEw3VA5CqjQZ4fSzmXnY4aaKuz lSivAYtCIHoCvR7cLLGV4Gm4WPz7h/Uea4VHbHUz79oo7Ra/vvY4a8ySqXjpBw+/FLIQBa4ii3Ioa RZg1CVW1JHP2XZ6t2aDdTHaGKGQYKnKV6jenP92zVktyD3LfbPBGiB55bm5JV9tQOXqaAutbjiPaU 1GvkEpiALfZVSsmug4Q7PBlLY05SotcYjCQ01lJqW2mjI9iO5bP8FO92yqOpqzLJMm+NrPFcA7xWG JdO7hCWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKcPA-00000008vSX-2bVI; Fri, 21 Jun 2024 11:26:08 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKcP6-00000008vRb-40yv for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2024 11:26:06 +0000 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-a6f7b785a01so204927266b.1 for ; Fri, 21 Jun 2024 04:26:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718969163; x=1719573963; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=i8sLZv1n+Ku2QMjcmS+4EdIPRc6Cam45MqmcajWwNAI=; b=ZxdbRCn6xPmkAHlAv88D/DUcO2M0WQRif8iOUpqHVVesXRQ6TaznSTvzZ/OhbYma38 y3D5HZdyRPvK7mVXWoZ4ctY9UXd9sIXT9fJHvRtiEoWrNMYyP4iwoQxTyS0EbA1Yee1+ kn5sWLvB/uOHyKhDuNlDUWeUbmxWhkzT9c3vdZ/3xwbuuMyAK7bBh1kqNM37ICzj+FCf OvMhOI8ejT3yHk/b8p7fL7CERaZ3Pe8z9ybeoR4M+QMAfPcdJGGbNbzWz5+9g+6cnJQk 11GPgfPQzdLwfHdc2aPLhUCpEgn08BEUBPhjk/v3rpwRW6E0ieG8wkXyigXWTB0JfvW0 21uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718969163; x=1719573963; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i8sLZv1n+Ku2QMjcmS+4EdIPRc6Cam45MqmcajWwNAI=; b=qrNd/Yz8MsNnccf8vjNBXCacQOPWXT/a1Ea5W6d+RH8etfVZ7JidWK7nCbTrutsbU9 0HUAWVtJzqQBii1MNSYL7ARSZQGjPNO2VbrAVpj+oeQJWVnOP1rIHvWU0LrtfSHiQWwA 0e/3WtNB+MAcYYOQ4W5lMGWjNPrUv05eBQqPQ6V1hqyPE9VJeknWRHCD0qGpTwInCTr3 HrVF/9RT6/sV5FUsR/BkDaRcL4LuWvdUDlIL1+OAT5r7boxuvgAhzmnptKdlkyDT0AA4 HANxMApAPab0yUFhWJhq9uRpsmWEh0X+nc8Pv6Lc+xjfq6QEs434dprlBlbc80BrL8Hv Qhjw== X-Forwarded-Encrypted: i=1; AJvYcCURLXTmZ/nwJg7I5gjoju8wnfZRJAbWUKiRvoG3eIlaZIGSzTOCxl3IYM1m6R99Dqs/15hP+FnqtzWt0cp0FDaBC/D6ZpnXF0a6KSxMrNUE6PmZL7Q= X-Gm-Message-State: AOJu0YxOHiPX8umxRnF0sfEI/cG377fqvSQs9+YJMHKQSf6NSfeTT+WK 21vHRQnkRcZnEWK1IYy8ix/nEW1IJRziHotM5tIX6NZljRtaUaM0 X-Google-Smtp-Source: AGHT+IEyjIILM29yLfV/vXCYggcQVFh0n6Mx/M2e70SYGzH2rtFIwFqH2zYjTAuliqRLT+DG1jMAKA== X-Received: by 2002:a17:906:d283:b0:a6f:6701:cd5a with SMTP id a640c23a62f3a-a6fab643427mr420372166b.44.1718969162970; Fri, 21 Jun 2024 04:26:02 -0700 (PDT) Received: from skbuf ([188.25.55.166]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6fcf48b17esm73795266b.88.2024.06.21.04.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 04:26:02 -0700 (PDT) Date: Fri, 21 Jun 2024 14:26:00 +0300 From: Vladimir Oltean To: Frank Li Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev Subject: Re: [PATCH v3 1/3] spi: fsl-dspi: use common proptery 'spi-cs-setup(hold)-delay-ns' Message-ID: <20240621112600.sshdjicucwtigq64@skbuf> References: <20240620-ls_qspi-v3-0-1a2afcf417e4@nxp.com> <20240620-ls_qspi-v3-1-1a2afcf417e4@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240620-ls_qspi-v3-1-1a2afcf417e4@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_042605_016459_CAF7C895 X-CRM114-Status: GOOD ( 16.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Typo in title: property On Thu, Jun 20, 2024 at 12:58:27PM -0400, Frank Li wrote: > Use SPI common DT binding properties 'spi-cs-setup-delay-ns' and > 'spi-cs-hold-delay-ns'. If these properties do not exist, fall back to > legacy 'fsl,spi-cs-sck-delay' and 'fsl,spi-sck-cs-delay'. > > Signed-off-by: Frank Li > --- > drivers/spi/spi-fsl-dspi.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c > index 0a2730cd07c6a..7c1f8af9d215e 100644 > --- a/drivers/spi/spi-fsl-dspi.c > +++ b/drivers/spi/spi-fsl-dspi.c > @@ -1018,11 +1018,15 @@ static int dspi_setup(struct spi_device *spi) > pdata = dev_get_platdata(&dspi->pdev->dev); > > if (!pdata) { > - of_property_read_u32(spi->dev.of_node, "fsl,spi-cs-sck-delay", > - &cs_sck_delay); > - > - of_property_read_u32(spi->dev.of_node, "fsl,spi-sck-cs-delay", > - &sck_cs_delay); > + cs_sck_delay = spi_delay_to_ns(&spi->cs_setup, NULL); > + if (!cs_sck_delay) > + of_property_read_u32(spi->dev.of_node, "fsl,spi-cs-sck-delay", > + &cs_sck_delay); > + > + sck_cs_delay = spi_delay_to_ns(&spi->cs_hold, NULL); > + if (!sck_cs_delay) > + of_property_read_u32(spi->dev.of_node, "fsl,spi-sck-cs-delay", > + &sck_cs_delay); Keep the 80 character line limit please.