From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3743AC27C4F for ; Fri, 21 Jun 2024 12:54:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qYJaA7XS25MstQlFWDdKfpHlFF9Sx8XLgOyXscP6JLU=; b=CFEaLnn7Sh8Zve+kepW64mUw3g a3Jf2ZfDB73dYy6IT7vOjN+7l3ArAma8TSoCUJuZBc53MKtgt1NE/YEU60JXqwjnvT3aeRkjPZD7G uuRqTERZ+Suj/0+uR5tUa8/qdOXTi9aQIZqpBc3vNXaJDNWdd8Xz0NG8AvkazrPgVw3Q6GrpixjD4 iNRyuVxYHEOAdHqPwFpv2YV2p+AejMJl/MoXdUFmpUAnQE74PxvsRHm9TgDxzzzvlFMVjEkVVBalb tjd687nRnGmujwo3/1S2Zl6YM55wD32qZ2OjdakjJa7uprZJ80gp8aRsyjjDKWkcdZ6DPMRgCSPWe eiskIjxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKdmN-00000009F92-3RdG; Fri, 21 Jun 2024 12:54:11 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKdmJ-00000009F7e-2UcK for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2024 12:54:09 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a6efe62f583so194555766b.3 for ; Fri, 21 Jun 2024 05:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718974445; x=1719579245; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qYJaA7XS25MstQlFWDdKfpHlFF9Sx8XLgOyXscP6JLU=; b=TCsMRZEPdEJUh2dhuKqdYi7e2gVd0EN62YGhsD84TGK58EwIgPeC2YaeEWgIOtLf9A 9rJJn80HeEVVHBA84UAGzl3ULuk8Ew2C1OOnxtBkPNrzoLjT6LJT76oTF64PE2+EvzAi OCW5TBKpUWp6YoLwSVSUwGxbHTH7BwmJw6Qh0G/Z8JVd2iizbjHsqlMMJ909Z/GVmYqw wGmhEyOsM5ZQqhWNYkDtnPWkJLSsbVr0I0M0ZK9KANsYbazznxhjr6caaVnCG3LwjyFL IeRGVmmkMlYKrcMPV94297ZBT8LzIZS1w1O+KEiTzfNSCJECQkIBeI9pLxh4Hgg/U210 AbJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718974445; x=1719579245; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qYJaA7XS25MstQlFWDdKfpHlFF9Sx8XLgOyXscP6JLU=; b=PBwcVhrz7e4bi5mYrK8xrdxu/bNuJsWm0VwYLFgIiYm0C64lZS6jZhRKT/OPykZbdg niKJtElM9QBZie1QpuzCVv+l0jNQzR9nvOrrhPlkePH4B0ZAaG9TWDiU2LeZZ8snvzQf 4hy0MuFtBk6JM3D9SXrJ7FSFtvIfFPv0xs46eopCfMNdFCzXK3rA5Zb8Nnx+vifTb7BY FWp8xTQJ510Yj3kJd3oOqihxFgNIAXlj5QA8eQ1DU53NN3rwu0vD0BnkNS6YKJcjioAT lXRAwiU9TH8+5aLaMpZKtLb5geQSnd93q/KbjMX2rcRxL9qYZDc9EnLB0i86CBqvvJ9X o2WQ== X-Forwarded-Encrypted: i=1; AJvYcCXp18g4+EL0ZYsk/YFlGy2wlYobuGOHICYgh/T9Qm/bB2JvBMj7zfOBBS7pE/fJAv8eKhOBiH+IwqA5bn95PYEZtvET0K+tMuOv1gFJ46j7cVoH+ac= X-Gm-Message-State: AOJu0Yz0qXt9CAS5S7zBU1JJ6fMTtktSNGxdHJPTW5WoT9hS+cYCGxOS c2HqzQvXZzAi3fQVwJAW6wjAdYiP+GdjAXQ/xQ5cCovgHsCsiJdVMJWUji/b X-Google-Smtp-Source: AGHT+IHRru8dj1JPrNty1M+sqrOOATWLXykc/0tIQFtaLKd3tUycWUm6+/vMJitFroUxg9wBZEO6Ew== X-Received: by 2002:a17:907:a4c7:b0:a6f:c167:614e with SMTP id a640c23a62f3a-a6fc167622bmr318798866b.31.1718974444550; Fri, 21 Jun 2024 05:54:04 -0700 (PDT) Received: from skbuf ([188.25.55.166]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6fcf560532sm80916166b.163.2024.06.21.05.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 05:54:04 -0700 (PDT) Date: Fri, 21 Jun 2024 15:54:01 +0300 From: Vladimir Oltean To: Frank Li Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev Subject: Re: [PATCH v3 3/3] arm64: dts: fsl-ls1043a-rdb: use common spi-cs-setup(hold)-delay-ns Message-ID: <20240621125401.of5rge7imyp4fdhz@skbuf> References: <20240620-ls_qspi-v3-0-1a2afcf417e4@nxp.com> <20240620-ls_qspi-v3-0-1a2afcf417e4@nxp.com> <20240620-ls_qspi-v3-3-1a2afcf417e4@nxp.com> <20240620-ls_qspi-v3-3-1a2afcf417e4@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240620-ls_qspi-v3-3-1a2afcf417e4@nxp.com> <20240620-ls_qspi-v3-3-1a2afcf417e4@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_055407_737895_27233407 X-CRM114-Status: GOOD ( 18.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 20, 2024 at 12:58:29PM -0400, Frank Li wrote: > Use SPI common propteries 'spi-cs-setup-delay-ns' and properties > 'spi-cs-hold-delay-ns', mark private properties 'fsl,spi-cs-sck-delay' > and 'fsl,spi-sck-cs-delay' as depericated. deprecated > > Signed-off-by: Frank Li > --- > arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts > index 26f8540cb101b..fef3534157a1d 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts > @@ -104,6 +104,11 @@ flash@0 { > compatible = "n25q128a13", "jedec,spi-nor"; /* 16MB */ > reg = <0>; > spi-max-frequency = <1000000>; /* input clock */ > + /* Add common SPI property */ I guess if you do insist on adding comments for this (not necessary IMO), we could improve on the stylistic elegance by saying "Standard CS timing properties replace the deprecated vendor variants below" or something like that. But currently it doesn't look great when there is a verb in the present tense and another in the past tense. Also, the plural form should have been used for 'property'. Additionally, I don't believe that a new line between the groups of properties is necessary. > + spi-cs-setup-delay-ns = <100>; > + spi-cs-hold-delay-ns = <100>; Do you plan on deprecating the fsl, CS timing parameters tree-wide, or are you going to stop at the LS1043A-RDB?