From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C689C2BA1A for ; Fri, 21 Jun 2024 14:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/z44+Phcyrx8OYVcHmZa41w4yuoKh8jjDFK/DcSA2mk=; b=trbTTIgRu85L15Yp2PTv04PVTy ak9UVNU919jYmnLdD05c5rFNKDJUWVFv1J62BITkRtCDKiL05Yd1fMx0OtXkpIGBYDs3L4aYbhC/1 FRsbRlue7wpMvpf7fZ75CdbYqO9EAnlqeT4q9fMIokkAzHDqU+ZGNZYjAE3W4ia5qN+jNAvT21c64 3pGFnGOsM42fkRd59iZ8NiLUPnPY5Ytw4RA/122Mrw1d1Wguc6Pu964HWiNdgpkXjWsZCys2NEF45 rdZSEnOxdi/xzoDjJ49G+VjrKBGkpuPWe8nZLMFBIkwWLI7oaqoz+PBJD2MkG1MxvZu23ame+MzaV t7dNXbBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKfYI-00000009a03-0JUv; Fri, 21 Jun 2024 14:47:46 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKfYE-00000009Zyz-28rl for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2024 14:47:43 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3608e6d14b6so1432262f8f.0 for ; Fri, 21 Jun 2024 07:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718981261; x=1719586061; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/z44+Phcyrx8OYVcHmZa41w4yuoKh8jjDFK/DcSA2mk=; b=nk0+VY5EOcM7p3sVhZ6CeAfAm7ZXOhXrmYX/DqK5xaGOdXNrIQEGBFxIZKT9Ht2LLe PCwX6G51y9/SxeyXidXHW5BHGF5PSg40cfz19ncwtLrSYvscnKcQOHaMAr8Vxgmpoi6C B0axfWfNIcDuLwmTyj6CYxu8SzF2eyLevTb5VSJg1MXQpooZng8Tob7db5AMFsdU+OhT A0ozFdmJMhPKPTRS2ku6zY3yn3PByA40AgkL+wuIYVDYoq59B2RS40p0J8bDR4aE/aga urLJZTRDCeowDpWSKbZDQS6ehbpmVyNmFrZJMdeNLbQMnx4b3MC3TjS7FD3+aJEx3/Rc v0TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718981261; x=1719586061; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/z44+Phcyrx8OYVcHmZa41w4yuoKh8jjDFK/DcSA2mk=; b=hDvvrLYNgMgaIhilXemgzTtRkm0iv6kv2bx3+jwWFfid5/3UsU4U1wMaCLGjyAPjUZ ps7APRfo3ZK7L0JKSE01qRE30G01qvELcHSJq2EAIR3uE3ni8Jd6b3oguMkto9x+IjTz 7GtOjACR7dX1V/MLfMfYteYDfMN2BK+n84SrhahRV8gecWrJEZjL6im+UEpSRTH1z9DB /beK+rwVgrkKE0zlNUgBCw3PZs3p+6JWVy0aFAm/saimrlEXE+oMoKriJRG1gjaLDImo HROC3TNqss6OZgwax9+5u2Kdtx32EIuA92n3yzS+U4+cXlg4HPuZK+lx+Mcu+izzB0Qy MT1w== X-Forwarded-Encrypted: i=1; AJvYcCVyjWk5eYai+mlQ7cxsMj3p73V94BNUwqB5zlQ0vk5H6bUzCTMbtLB2NQbPNm5Anx31SB+dUwwJ1z2YWAsdOyt05CoUqd9rT+ba1HVoxno+mAmY/iM= X-Gm-Message-State: AOJu0Yy0qda4Gzbw7JxC1ryA6czyWoQEodL39z+y2TheN/bDLn375xsD r9jUtYItTVI6ZI1e2zMtBsFrZ+bpQOd7m96Yg54a4oXnJ9vdGDmF X-Google-Smtp-Source: AGHT+IGkUiQ8/JHxqC9cXg/EgQkUBEudQn16W8dQas9PKPraVTUmyUfCQHL+5/9JPk9VV7HjRS/MOw== X-Received: by 2002:adf:f98c:0:b0:35f:20da:e1a2 with SMTP id ffacd0b85a97d-36317b7d57dmr6247272f8f.30.1718981260653; Fri, 21 Jun 2024 07:47:40 -0700 (PDT) Received: from skbuf ([188.25.55.166]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-366389b88easm1942929f8f.39.2024.06.21.07.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 07:47:40 -0700 (PDT) Date: Fri, 21 Jun 2024 17:47:37 +0300 From: Vladimir Oltean To: Frank Li Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev Subject: Re: [PATCH v3 2/3] spi: dt-bindings: fsl-dspi: Convert to yaml format Message-ID: <20240621144737.l7bwipq2i3grspxa@skbuf> References: <20240620-ls_qspi-v3-0-1a2afcf417e4@nxp.com> <20240620-ls_qspi-v3-2-1a2afcf417e4@nxp.com> <20240621124211.pueymngpq5luokvj@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_074742_570545_3B13C2F8 X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 21, 2024 at 10:39:33AM -0400, Frank Li wrote: > On Fri, Jun 21, 2024 at 03:42:11PM +0300, Vladimir Oltean wrote: > > > Use part of Vladimir Oltean's work at > > > https://lore.kernel.org/linux-spi/20221111224651.577729-1-vladimir.oltean@nxp.com/ > > > > Hm, you took part of that but gave no attribution? The portion below --- > > is also discarded when the patch is applied, so even the link is lost, > > FYI. > > I am not sure what should be added in comments? > > Ref part of Vladimir Oltean's work at https:// ... (I am not sure if allow > http link). > > Or coworked-with Vladimir Oltean ... > Or use seperated patch for your part. > > What do you like? > > Frank Well, it depends on how much from that work you end up taking. I would recommend taking all of it :) and completing the unfinalized review feedback with your work, plus some additions like the standard CS timing parameters. Then, you could keep that sign off chain and add yours at the bottom. At least that was my approach when I tried to continue Kuldeep's work. If you take a very small portion, I guess you could at least move the link inside the portion of the commit message that remains visible in the commit log. And for a significant portion, Documentation/process/submitting-patches.rst says you could add Co-developed-by + Signed-off-by, followed by your sign off.