From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Chris Zhong <zyw@rock-chips.com>,
Zhang Qing <zhangqing@rock-chips.com>,
Chris Morgan <macromorgan@hotmail.com>,
Furkan Kardame <f.kardame@manjaro.org>,
Michael Riesch <michael.riesch@wolfvision.net>
Cc: kernel@collabora.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/5] dt-bindings: mfd: rk817: Fixup clocks and reference dai-common
Date: Sat, 22 Jun 2024 00:57:18 +0300 [thread overview]
Message-ID: <20240622-rk809-fixes-v2-1-c0db420d3639@collabora.com> (raw)
In-Reply-To: <20240622-rk809-fixes-v2-0-c0db420d3639@collabora.com>
Ensure 'clocks' property does not allow more than one item and add the
missing reference to dai-common schema.
While at it, move 'clocks*' and '#sound-dai-cells' properties to keep
the list ordered alphabetically.
Additionally, drop all useless/redundant descriptions.
Fixes: 6c38ca03406e ("dt-bindings: mfd: rk808: Convert bindings to yaml")
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
.../devicetree/bindings/mfd/rockchip,rk817.yaml | 33 ++++++++--------------
1 file changed, 11 insertions(+), 22 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
index 8c2fd0fabb92..d70b4307ac77 100644
--- a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
+++ b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
@@ -32,6 +32,13 @@ properties:
minimum: 0
maximum: 1
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ items:
+ - const: mclk
+
clock-output-names:
description:
From common clock binding to override the default output clock name.
@@ -42,6 +49,9 @@ properties:
description:
Telling whether or not this PMIC is controlling the system power.
+ '#sound-dai-cells':
+ const: 0
+
system-power-controller: true
wakeup-source:
@@ -94,26 +104,7 @@ properties:
$ref: /schemas/regulator/regulator.yaml#
unevaluatedProperties: false
- clocks:
- description:
- The input clock for the audio codec.
-
- clock-names:
- description:
- The clock name for the codec clock.
- items:
- - const: mclk
-
- '#sound-dai-cells':
- description:
- Needed for the interpretation of sound dais.
- const: 0
-
codec:
- description: |
- The child node for the codec to hold additional properties. If no
- additional properties are required for the codec, this node can be
- omitted.
type: object
additionalProperties: false
properties:
@@ -123,9 +114,6 @@ properties:
Describes if the microphone uses differential mode.
charger:
- description: |
- The child node for the charger to hold additional properties. If a
- battery is not in use, this node can be omitted.
type: object
$ref: /schemas/power/supply/power-supply.yaml
@@ -168,6 +156,7 @@ properties:
additionalProperties: false
allOf:
+ - $ref: /schemas/sound/dai-common.yaml#
- if:
properties:
'#clock-cells':
--
2.45.2
next prev parent reply other threads:[~2024-06-21 21:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 21:57 [PATCH v2 0/5] DT fixes for Rockchip RK809 audio codec support Cristian Ciocaltea
2024-06-21 21:57 ` Cristian Ciocaltea [this message]
2024-06-22 10:52 ` [PATCH v2 1/5] dt-bindings: mfd: rk817: Fixup clocks and reference dai-common Conor Dooley
2024-06-26 15:44 ` Lee Jones
2024-06-26 16:19 ` Conor Dooley
2024-06-21 21:57 ` [PATCH v2 2/5] dt-bindings: mfd: rk817: Merge support for RK809 Cristian Ciocaltea
2024-06-22 10:54 ` Conor Dooley
2024-06-21 21:57 ` [PATCH v2 3/5] arm64: dts: rockchip: Drop invalid mic-in-differential on rk3568-rock-3a Cristian Ciocaltea
2024-06-21 21:57 ` [PATCH v2 4/5] arm64: dts: rockchip: Fix mic-in-differential usage on rk3566-roc-pc Cristian Ciocaltea
2024-06-21 21:57 ` [PATCH v2 5/5] arm64: dts: rockchip: Fix mic-in-differential usage on rk3568-evb1-v10 Cristian Ciocaltea
2024-06-27 8:30 ` (subset) [PATCH v2 0/5] DT fixes for Rockchip RK809 audio codec support Lee Jones
2024-06-27 19:27 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240622-rk809-fixes-v2-1-c0db420d3639@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.kardame@manjaro.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=michael.riesch@wolfvision.net \
--cc=robh@kernel.org \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).