From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C612C2BB85 for ; Sat, 22 Jun 2024 09:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RdWfekSEnBvHhMrDy3WpE6951FAqx4L8pggEQfxysMY=; b=TAlTnF8Sml0xMCf4uyZfYP9VQA lR8eLioKnUzJPSKNF4pnO0ormPyk8JvJ3x81VEjlt0m4MWNTlpAov1giDnusc5X3I/2x0BwgpPUyA ALcN1qQDq/JdlRibspAqwyhziFfyOVavnAbseCjhgOjrP9TQsciPyWFip5ndnLov7HJCHs0qinboW fSaeBjsAZ0nEVmmFF4RjcuTTdAEQGIlcIgFdIvyib26cUCtv7WNLBiDIPboUymXoYVxewabAkAZeR h/mIT6EORICTqYo4Cn8qnQz4/U4xB9c+wLULISf5vv5UylYYJHRUq4rALm93brzj7qzYxx8BekLuq qa76JzfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKxHc-0000000Bnxx-1CnW; Sat, 22 Jun 2024 09:43:44 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKxHX-0000000Bnx0-12rZ; Sat, 22 Jun 2024 09:43:40 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id AC7AACE0946; Sat, 22 Jun 2024 09:43:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3103FC3277B; Sat, 22 Jun 2024 09:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719049414; bh=uECyP60yqfaB0U3mswQAJu4fxkYx/BeROCYGGUgcZH4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ztm1Gbkr6/gXKWLMPIDWdWu0OlZT4twgLMrMtVhmNo/xuaR9xRMwlzq1ltInAx19f 8lXVoA+r/lbsgv/Rk1PmKxysQIYkzmnut6C1fXtf8I2P2QkFZbOG5JwFNsQVewHU/g OHXe9lP8VHPidyZ+mAudzf/eHGI8D1NdH51f7z8HouohNGaQyvYeJRutLr6vsQm5py LwlazDqAz85cdtfQOtvp4H2f+354NJ9/1dKYhXCysf5+v3xISprRmhJc66fu44re5Y DsKBK3HvQBZHDf+hMVfv3g3yzVhp48oZ0zGADxqK/mbijTndbUDv/EG70MWlQUEymB ZRevAamIdbsfA== Date: Sat, 22 Jun 2024 10:43:19 +0100 From: Jonathan Cameron To: Trevor Gamblin Cc: Lars-Peter Clausen , Dmitry Rokosov , Michael Hennerich , Cosmin Tanislav , Chen-Yu Tsai , Hans de Goede , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Saravanan Sekar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Nuno =?UTF-8?B?U8Oh?= , Linus Walleij , Jean-Baptiste Maneyrol , Crt Mori , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Uwe =?UTF-8?B?S2xlaW5lLUvDtm5p?= =?UTF-8?B?Zw==?= Subject: Re: [PATCH v3 02/41] iio: accel: kxsd9: Make use of regmap_clear_bits() Message-ID: <20240622104319.60b0f0d5@jic23-huawei> In-Reply-To: <20240617-review-v3-2-88d1338c4cca@baylibre.com> References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> <20240617-review-v3-2-88d1338c4cca@baylibre.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240622_024339_680181_EC03F67E X-CRM114-Status: GOOD ( 13.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 17 Jun 2024 09:49:42 -0400 Trevor Gamblin wrote: > Instead of using regmap_update_bits() and passing val =3D 0, use > regmap_clear_bits(). >=20 > Suggested-by: Uwe Kleine-K=C3=B6nig > Signed-off-by: Trevor Gamblin > --- > drivers/iio/accel/kxsd9.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/iio/accel/kxsd9.c b/drivers/iio/accel/kxsd9.c > index ba99649fe195..03ce032e06ff 100644 > --- a/drivers/iio/accel/kxsd9.c > +++ b/drivers/iio/accel/kxsd9.c > @@ -370,10 +370,8 @@ static int kxsd9_power_down(struct kxsd9_state *st) > * make sure we conserve power even if there are others users on the > * regulators. > */ > - ret =3D regmap_update_bits(st->map, > - KXSD9_REG_CTRL_B, > - KXSD9_CTRL_B_ENABLE, > - 0); > + ret =3D regmap_clear_bits(st->map, KXSD9_REG_CTRL_B, > + KXSD9_CTRL_B_ENABLE); Now fits neatly on one line at precisely 80 chars. I rewrapped whilst applying. Jonathan > if (ret) > return ret; > =20 >=20