linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm: dts: k3-am642-evm-nand: Add bootph-all to NAND related nodes
@ 2024-06-23  7:24 Roger Quadros
  2024-06-27 12:48 ` Nishanth Menon
  0 siblings, 1 reply; 2+ messages in thread
From: Roger Quadros @ 2024-06-23  7:24 UTC (permalink / raw)
  To: Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: srk, praneeth, linux-arm-kernel, devicetree, linux-kernel,
	Roger Quadros

NAND boot would require these nodes to be present at early stage.
Ensure that by adding "bootph-all" to relevant nodes.

Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
 arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso b/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
index dc70b6fbc3d7..babd681666f4 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
@@ -13,6 +13,7 @@
 
 &main_pmx0 {
 	gpmc0_pins_default: gpmc0-pins-default {
+		bootph-all;
 		pinctrl-single,pins = <
 			AM64X_IOPAD(0x0094, PIN_INPUT, 7) /* (T19) GPMC0_BE1n.GPIO0_36 */
 			AM64X_IOPAD(0x003c, PIN_INPUT, 0) /* (T20) GPMC0_AD0 */
@@ -49,7 +50,9 @@ AM64X_IOPAD(0x00a4, PIN_OUTPUT, 0) /* (N17) GPMC0_DIR */
 };
 
 &main_gpio0 {
+	bootph-all;
 	gpio0-36 {
+		bootph-all;
 		gpio-hog;
 		gpios = <36 0>;
 		input;
@@ -58,10 +61,12 @@ gpio0-36 {
 };
 
 &elm0 {
+	bootph-all;
 	status = "okay";
 };
 
 &gpmc0 {
+	bootph-all;
 	status = "okay";
 	pinctrl-names = "default";
 	pinctrl-0 = <&gpmc0_pins_default>;
@@ -69,6 +74,7 @@ &gpmc0 {
 	#size-cells = <1>;
 
 	nand@0,0 {
+		bootph-all;
 		compatible = "ti,am64-nand";
 		reg = <0 0 64>;		/* device IO registers */
 		interrupt-parent = <&gpmc0>;

---
base-commit: 4031a2866a9f0f5c585cfee65b3fb5ab17c95276
change-id: 20240623-am642-evm-nand-bootph-03b68b4c9d9e

Best regards,
-- 
Roger Quadros <rogerq@kernel.org>



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm: dts: k3-am642-evm-nand: Add bootph-all to NAND related nodes
  2024-06-23  7:24 [PATCH] arm: dts: k3-am642-evm-nand: Add bootph-all to NAND related nodes Roger Quadros
@ 2024-06-27 12:48 ` Nishanth Menon
  0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Menon @ 2024-06-27 12:48 UTC (permalink / raw)
  To: Roger Quadros
  Cc: Vignesh Raghavendra, Tero Kristo, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, srk, praneeth,
	linux-arm-kernel, devicetree, linux-kernel

On 10:24-20240623, Roger Quadros wrote:
> NAND boot would require these nodes to be present at early stage.
> Ensure that by adding "bootph-all" to relevant nodes.
> 
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
>  arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso b/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
> index dc70b6fbc3d7..babd681666f4 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
> @@ -13,6 +13,7 @@
>  
>  &main_pmx0 {
>  	gpmc0_pins_default: gpmc0-pins-default {
> +		bootph-all;
>  		pinctrl-single,pins = <
>  			AM64X_IOPAD(0x0094, PIN_INPUT, 7) /* (T19) GPMC0_BE1n.GPIO0_36 */
>  			AM64X_IOPAD(0x003c, PIN_INPUT, 0) /* (T20) GPMC0_AD0 */
> @@ -49,7 +50,9 @@ AM64X_IOPAD(0x00a4, PIN_OUTPUT, 0) /* (N17) GPMC0_DIR */
>  };
>  
>  &main_gpio0 {
> +	bootph-all;
>  	gpio0-36 {
> +		bootph-all;
>  		gpio-hog;
>  		gpios = <36 0>;
>  		input;
> @@ -58,10 +61,12 @@ gpio0-36 {
>  };
>  
>  &elm0 {
> +	bootph-all;
>  	status = "okay";
>  };
>  
>  &gpmc0 {
> +	bootph-all;

NAK. please add bootph property ONLY to leaf nodes.

>  	status = "okay";
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&gpmc0_pins_default>;
> @@ -69,6 +74,7 @@ &gpmc0 {
>  	#size-cells = <1>;
>  
>  	nand@0,0 {
> +		bootph-all;
>  		compatible = "ti,am64-nand";
>  		reg = <0 0 64>;		/* device IO registers */
>  		interrupt-parent = <&gpmc0>;
> 
> ---
> base-commit: 4031a2866a9f0f5c585cfee65b3fb5ab17c95276
> change-id: 20240623-am642-evm-nand-bootph-03b68b4c9d9e
> 
> Best regards,
> -- 
> Roger Quadros <rogerq@kernel.org>
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-27 12:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-23  7:24 [PATCH] arm: dts: k3-am642-evm-nand: Add bootph-all to NAND related nodes Roger Quadros
2024-06-27 12:48 ` Nishanth Menon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).