From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CD51C2BD09 for ; Mon, 24 Jun 2024 13:37:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I0Tf9UtUNeBssRAHfKtA6/HfyAzeFBs+QlF+edmj4Qg=; b=orNrPXrzawSnMl7Az6QfpTY6ez NSozJfoF5cuZhjRS8ufbHeqKHB2LVQr0HoFM81uV7cpce/f7g7sFNOVRda5ZEY5XhrE6sbuT863H7 rOzKyvZuoZBPUi9UZhD1uavdFDnVQUmDK7QgEidxstxUMtDG3VQJ/BD2gDC6fL+ciD1BKQfbRXwAA NMoZe62h0pxag4Jd+UNT9emoj1se0aflCrwhTml2jrQfRldagpT4k+5eVt8wccRFKf/MUiOcNXsJk KjJd42NnxDoALV4FxNMxp+yI2iwg9OhaHzdtTo1O8B7myQd1HGG477SEZQbVrTPyDnjdADp4PzrJY 4vlekdvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLjt7-0000000GxbI-2jss; Mon, 24 Jun 2024 13:37:41 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLjt1-0000000GxZY-3ORN for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2024 13:37:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B794ACE016A; Mon, 24 Jun 2024 13:37:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 041FBC2BBFC; Mon, 24 Jun 2024 13:37:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1719236252; bh=1cgL7/UMBWpOqRwOkjepbWNoCYLDMNABKYbz44Gt3QY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zyDIt5HEof/y1y+siBNeA+CSVAOtQkc4PceG9oHrEwwTmy6b2ocTDk/30VP3X8YPc pEJLtDoCiF/WvE3suQRNlGaJTTj/D82Ju0KFqRpSsTPNNJrIpbBrbfGFhL60ue1psN wN3AeWBgzxuD3EtI+ZssAl+2taleGAQfxpyORExc= Date: Mon, 24 Jun 2024 15:37:29 +0200 From: Greg KH To: Jacky Huang Cc: dan.carpenter@linaro.org, jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jacky Huang Subject: Re: [PATCH v2] tty: serial: ma35d1: Add a NULL check for of_node Message-ID: <2024062404-avoid-grieving-a3fa@gregkh> References: <20240614054554.80-1-ychuang570808@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240614054554.80-1-ychuang570808@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240624_063736_084987_315AD6BB X-CRM114-Status: GOOD ( 11.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 14, 2024 at 05:45:54AM +0000, Jacky Huang wrote: > From: Jacky Huang > > The pdev->dev.of_node can be NULL if the "serial" node is absent. > Add a NULL check to return an error in such cases. > > Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support") > Signed-off-by: Jacky Huang You forgot a "Reported-by:" line as Dan did report this to you. > --- > drivers/tty/serial/ma35d1_serial.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) Also, no info as to what changed from v1 :( thanks, greg k-h