From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B32FC2BD09 for ; Mon, 24 Jun 2024 14:42:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3qbUwApjxlkJgxNxmxhPxvVAe4aCjLT5L7BP/AlmbjM=; b=O41yS1NU7QjJTcOW/3Oad87MNl QzU38qiqZSHPx/c+cNb0ztWLaOnUIpPdYVqVft6Zx1J7bB2JuPTrVloGIwEUi7cg/JN8XPQeEnMru 9e4BYbaLPFfPqSVa4wDNWjTXgqUf0rSSgqP4OW7NZK2VpFB9J7H5P+3hvNboZr/P52URgy/vyQ456 lKP/1PrmVsxtvVDIyQwc4gpTLyQiNj8FWMGJB7IMIa346lex6iX/AQ5HmtxVoXJePpZvjOvC/Vvrw peLsoEBTiHYhK+a3zhaEZbIRdIQDoeGSZhaWUwBpm241H6ZPfj02ErOKoWvJAO1FhsS1BFEK9TxPi SJo+UNEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLku0-0000000H8Dx-0fuu; Mon, 24 Jun 2024 14:42:40 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLktu-0000000H8Bq-1AgJ for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2024 14:42:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D350B60C8D; Mon, 24 Jun 2024 14:42:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53E17C2BBFC; Mon, 24 Jun 2024 14:42:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719240152; bh=SyswWu1AqB72FEdhCtLY98PQ4fTBCKFZWNGbvA8Dmn8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tSngehcO0yI2RZYE6Fx1x4NNKaD2rIHcIsgUqv7WDPhC+S9TNy/HLtAO4jGX1eIWr esyGUJxcfzYmspAzGjne+nbdM4ZnVdiN0brqUkc61sr9AbIbAojXj4xDVqBQao7693 cjuu5IjyEJPY1iPRAhFFsREgmedRbKiAFAm75JZXnq2LhM8aAemvyep3XgtZ/Y4+CI Vq2v/HwPIByfWrMCYKn2DmyFvAKjTlKcpwR8ajmHwK/F4p7RpJi+YZ4Jp8YZWLtMBU zr96MkEY4jCKuo3R9uqgjjiceS2W5sMrybhHETwGLsKMw/reEwzwHllmHLfI3TjyIn YiXis8zSOyHxA== Date: Mon, 24 Jun 2024 15:42:28 +0100 From: Will Deacon To: Liu Wei Cc: andrew@lunn.ch, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, prarit@redhat.com Subject: Re: [PATCH V3] ACPI: Add acpi=nospcr to disable ACPI SPCR as default console on arm64 Message-ID: <20240624144227.GA8706@willie-the-truck> References: <20240624050404.84512-1-liuwei09@cestc.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240624050404.84512-1-liuwei09@cestc.cn> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240624_074234_404269_1550BD36 X-CRM114-Status: GOOD ( 20.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 24, 2024 at 01:04:04PM +0800, Liu Wei wrote: > From: Andrew Lunn > > > On Sat, Jun 22, 2024 at 05:35:21PM +0800, Liu Wei wrote: > > > For varying privacy and security reasons, sometimes we would like to > > > completely silence the serial console, and only enable it when needed. > > > > > > But there are many existing systems that depend on this console, > > > so add acpi=nospcr for this situation. > > > > Maybe it is just me, but i see nospcr and my brain expands it to "no > > speaker". Adding to that, your commit message says "completely > > silence"... > > > > > + nospcr -- disable ACPI SPCR as default console on ARM64 > > > + For ARM64, ONLY "acpi=off", "acpi=on", "acpi=force" or > > > + "acpi=nospcr" are available > > > + For RISCV64, ONLY "acpi=off", "acpi=on" or "acpi=force" > > > + are available > > > > How about putting the word 'serial' in here somewhere, just to give > > users an additional clue you are not talking about a speaker, CTRL-G > > etc. > > Thank you for your suggestion. > > You mean acpi=nospcr_serial or acpi=no_spcrserial? However, it appears > somewhat unconventional compared to the original acpi=* parameter. > > How about introducing a new one, such as acpi_no_spcr_serial or > acpi_no_spcr_console? I think acpi=nospcr is fine like it is. Just expand the acronym in the documentation so that it's obviously not talking about a speaker. Will