From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1B37C2BD09 for ; Mon, 24 Jun 2024 19:49:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KBDO0kSvVyhPNYYN2uyOv/PLsBTuchnCDut64rZfAOU=; b=ax+fFY9db8QV0fUvZTh+WWcs9s /ErLaUiuPj+79j2lUWVtvfs7XkglzgW20jS6EWIqZpeD9zu//20WzEUupymGJVB52zH/BTZ/HVMsp PJHJ01VrJiArEzwdEAPRQ6oVuZKSqiXR0cKrXEr5UjJCX8MXwGjKj54AYkDvI3fJqyOwDDahRVqdc olBtvy5W8H8wEvykAZf8dFum7xFw/4Xfy3I/++UbJrWiUR7NhPgbT9WGJaV6h5hAKDhE0HTqZE4cG awyX8imHEnttqOYyTVgfsl/EVQrUIrRJX/tBgz+HXRAVBQmoFNbWqI5LJHiI+7dwLcBuyKG6Hbmli bU80x7ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLpgr-00000000TZG-3QVR; Mon, 24 Jun 2024 19:49:25 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLpgm-00000000TXy-068g for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2024 19:49:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 93730CE13C2; Mon, 24 Jun 2024 19:49:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2FF3C2BBFC; Mon, 24 Jun 2024 19:49:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719258554; bh=bitaMLMQKsPB3ypqXTwY23B+hxKKZ4D/Ve0iLG51d5s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rJodd4Bj7XmE4r73Uerxpla8Ds2P5QYdoxcVeQeWSe7jZIfQy6lKO56KXk08RRW/F VArZXItIkBweO64cxcM3TqbNU2Mj4mVsi0DZobeptHoLngqaYf00REqt07n07uOjVq PVRn0cnv6Ne1Zm/+V+v9n9Cvd1m+AlIB4VxKusZ8KEJiVZn/Kg2gFxtqp68df+IyeA auhYCDfsVgnBwwQwh2YGi38vtHPod06QnYV4PNcR5KYRqdsiugy5HMJZm5nfK5bEcE 79B/Z35swG/Wz12mtoxv9X0S9mRB+AqRgfWoUR5XOer5KZPyKRetXrRp7pjTxPHbP3 RKPnooTR3wc1A== Date: Mon, 24 Jun 2024 13:49:13 -0600 From: Rob Herring To: Andrei Simion Subject: Re: [PATCH v2 3/3] dt-bindings: eeprom: at24: Add at24,mac02e4 and at24,mac02e6 Message-ID: <20240624194913.GA267989-robh@kernel.org> References: <20240621121340.114486-1-andrei.simion@microchip.com> <20240621121340.114486-4-andrei.simion@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240621121340.114486-4-andrei.simion@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240624_124920_276093_D9680AED X-CRM114-Status: GOOD ( 15.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, conor+dt@kernel.org, arnd@arndb.de, alexandre.belloni@bootlin.com, gregkh@linuxfoundation.org, brgl@bgdev.pl, claudiu.beznea@tuxon.dev, linux-i2c@vger.kernel.org, krzk+dt@kernel.org, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 21, 2024 at 03:13:40PM +0300, Andrei Simion wrote: > Update regex check and add pattern to match both EEPROMs. The subject is wrong as 'at24' is not the vendor. > > Signed-off-by: Andrei Simion > --- > v1 -> v2: > - change patter into "^atmel,(24(c|cs|mac)[a-z0-9]+|spd)$" to keep simpler > --- > Documentation/devicetree/bindings/eeprom/at24.yaml | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml > index 3c36cd0510de..f914ca37ceea 100644 > --- a/Documentation/devicetree/bindings/eeprom/at24.yaml > +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml > @@ -18,7 +18,7 @@ select: > properties: > compatible: > contains: > - pattern: "^atmel,(24(c|cs|mac)[0-9]+|spd)$" > + pattern: "^atmel,(24(c|cs|mac)[a-z0-9]+|spd)$" > required: > - compatible > > @@ -37,8 +37,8 @@ properties: > - allOf: > - minItems: 1 > items: > - - pattern: "^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[0-9]+|spd)$" > - - pattern: "^atmel,(24(c|cs|mac)[0-9]+|spd)$" > + - pattern: "^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[a-z0-9]+|spd)$" > + - pattern: "^atmel,(24(c|cs|mac)[a-z0-9]+|spd)$" Are these devices available from multiple vendors? If not, I think I'd add specific compatible strings with the right vendor rather than adding to this pattern. It's rather loosely defined because that's what was in use already. Rob