From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFA93C2BBCA for ; Tue, 25 Jun 2024 16:15:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vlJqgfNlv/E6Ab+QFkdXJzV9DYXilIj9Dqhbwg5Yv4A=; b=L/pYp0uner4WwkIb9VhDObJ93a QYLjmJTu/w2S0q07ksShathDlkG6LlROruyN5uqGr8Prss1i67oyfBVCw1VbWM+04fK97SHvQ9t2m SYpMWZQRRLRj88qjUG+TMGHnUlkmBfpURUOjnOBJUMCc7PM03+S5joXy+ruaR43KphADV0oo//IiV P29UIF3SBWdOdt8GCoqpsDzGyJSJEOunxxKTvmQt6fka7VviUfkz0GKorIfAEayU3b3/YGJJQtcj0 LvkCATQmD0Ehrwp61AhDSkYytskmwmuWWl67gIZ2qMdgR2cZ41NDjd8Fkh/UzaEftWGlFv1A8mt6H hXrSNlNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM8p8-00000003eog-2q9d; Tue, 25 Jun 2024 16:15:14 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM8p2-00000003eng-1XA4 for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2024 16:15:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E5301614BC; Tue, 25 Jun 2024 16:15:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D24F1C32781; Tue, 25 Jun 2024 16:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719332106; bh=XQohTkrMk3w4JsHXkU/yJh/3BOrnzSPrBLO6SVzxBHU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZnfgTCyrXOezzPIysx6VazlMHDnu5Ix5DQFtaxQyv0kSoO2aOKkA7wyWg0usE1Zrb pzNFQ6/NTB7nnE/Am9/EmLnqQyb8IudDMSa4efPW0u+TeR3zlbZbSXpd2pJZ43uYic zGYhumaBwhuFNTezi85P4c1E6pRAbuXDoJmkzpmq+iDcrr5SOOXrFCIBEHLx2yF1yu O8jmrupZ0xmmLYzp8HgNk7DM4ob42SWGxCbZTHtVwnWmi5vbjpbxcTJ2gL9Xu7FPt5 /pxG+hxNCJ6r2GwmHJWbSFwP23aUstQ8jwsh9x9/bws+b+EoO5x/PA1humux+m6Xq0 9iuME81K3Orhw== Date: Tue, 25 Jun 2024 17:15:01 +0100 From: Conor Dooley To: Andrei.Simion@microchip.com Subject: Re: [PATCH v2 3/3] dt-bindings: eeprom: at24: Add at24,mac02e4 and at24,mac02e6 Message-ID: <20240625-satisfy-froth-decbe11ba388@spud> References: <20240621121340.114486-1-andrei.simion@microchip.com> <20240621121340.114486-4-andrei.simion@microchip.com> <20240624194913.GA267989-robh@kernel.org> <53820e28-f512-4129-9a17-a549ef664755@microchip.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AJI6S4BF4a0FtQ1K" Content-Disposition: inline In-Reply-To: <53820e28-f512-4129-9a17-a549ef664755@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240625_091508_520046_5E252DBD X-CRM114-Status: GOOD ( 27.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, arnd@arndb.de, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, brgl@bgdev.pl, alexandre.belloni@bootlin.com, linux-i2c@vger.kernel.org, claudiu.beznea@tuxon.dev, krzk+dt@kernel.org, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --AJI6S4BF4a0FtQ1K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 25, 2024 at 07:33:18AM +0000, Andrei.Simion@microchip.com wrote: > On 24.06.2024 22:49, Rob Herring wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know = the content is safe > >=20 > > On Fri, Jun 21, 2024 at 03:13:40PM +0300, Andrei Simion wrote: > >> Update regex check and add pattern to match both EEPROMs. > >=20 > > The subject is wrong as 'at24' is not the vendor. > > >=20 > My mistake. It needs to be atmel,24mac02e4 and atmel,24mac02e6. >=20 > >> > >> Signed-off-by: Andrei Simion > >> --- > >> v1 -> v2: > >> - change patter into "^atmel,(24(c|cs|mac)[a-z0-9]+|spd)$" to keep sim= pler > >> --- > >> Documentation/devicetree/bindings/eeprom/at24.yaml | 10 +++++++--- > >> 1 file changed, 7 insertions(+), 3 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Docu= mentation/devicetree/bindings/eeprom/at24.yaml > >> index 3c36cd0510de..f914ca37ceea 100644 > >> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml > >> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml > >> @@ -18,7 +18,7 @@ select: > >> properties: > >> compatible: > >> contains: > >> - pattern: "^atmel,(24(c|cs|mac)[0-9]+|spd)$" > >> + pattern: "^atmel,(24(c|cs|mac)[a-z0-9]+|spd)$" > >> required: > >> - compatible > >> > >> @@ -37,8 +37,8 @@ properties: > >> - allOf: > >> - minItems: 1 > >> items: > >> - - pattern: "^(atmel|catalyst|microchip|nxp|ramtron|rene= sas|rohm|st),(24(c|cs|lc|mac)[0-9]+|spd)$" > >> - - pattern: "^atmel,(24(c|cs|mac)[0-9]+|spd)$" > >> + - pattern: "^(atmel|catalyst|microchip|nxp|ramtron|rene= sas|rohm|st),(24(c|cs|lc|mac)[a-z0-9]+|spd)$" > >> + - pattern: "^atmel,(24(c|cs|mac)[a-z0-9]+|spd)$" > >=20 > > Are these devices available from multiple vendors? If not, I think I'd > > add specific compatible strings with the right vendor rather than adding > > to this pattern. It's rather loosely defined because that's what was in > > use already. > > >=20 > So, would you like me to keep how it was before: "^atmel,(24(c|cs|mac)[0= -9]+|spd)$" and "^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(= 24(c|cs|lc|mac)[0-9]+|spd)$" > and to add only:=20 > - items: > pattern: mac02e4$ > - items: > pattern: mac02e6$ > ? >=20 > Or would you like me to add to "the special cases that don't conform to t= he above pattern. Each requires a standard at24 model as fallback." area? I think the suggestion is to explicitly add these two devices down at the bottom instead of adding to the regex. The first hunk I think in this patch needs to remain a regex. --AJI6S4BF4a0FtQ1K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZnrtBQAKCRB4tDGHoIJi 0nAGAP9c9ahF3KKPYkzc54SeH548SMqi21zBcYKc6rYUGCosVAEAnUfWuzDnMMEq cxqJ7Z/xgXL8YmgJR7ul3OSa490w/gY= =lw1j -----END PGP SIGNATURE----- --AJI6S4BF4a0FtQ1K--