From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D8C5C30653 for ; Wed, 26 Jun 2024 00:55:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Izk1NgcsF1MNbPPPjVbJ3RXhMC94mMwoMv0Vo/lTO9A=; b=pwo4wOD/gKctdDKpxLb3Ltk+Ff jIXOPIGDSMZrSHsV0PZE1oO/Al8Vbz9Tk+Czql/gA2sMgnk03lwh/4aLBiXirVK9mo4GB/Phmt4y+ Y82OM9O9PXhZSfbrWq1FI6Eh4k0fSaFwWTvKrwuz0ltsYoXMYasAAZlm74gozf6CdnRP7Xyvi2Zyg SdyLp3gHaBrNmByYwapPzvR3npBFUKksPGPeUL3mtLi32ThzwXuKVpWnXZR62vczGaxjaiB8IyR1g BSGhssSr40rFPjUZFu2p8g9hNoPaDGD2VPDICWYqyPcA1TpkunanEO9tI6INhsM45RKjJ1aiDzIsN XuxYPGsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMGvw-00000004wWD-14nm; Wed, 26 Jun 2024 00:54:48 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMGvn-00000004wUJ-3Rc1 for linux-arm-kernel@lists.infradead.org; Wed, 26 Jun 2024 00:54:41 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3E74ECE0B62; Wed, 26 Jun 2024 00:54:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19BC6C32781; Wed, 26 Jun 2024 00:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719363275; bh=xMiXrxWpqFvHwNreomzAVh6+pEq2p+w+8MNiSYQC9Qo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oO1sLZOGd4dn/1GJXV0GO6FkLkQleqtP2qYcRqaQn8B1V7Uo/0/fhQc9nl7XNuPxO sudgtwV/u3fPLA0ocKVD8hf0k0+iUozSZCy3LWl1st9PEGzb4vixYzDk930VPSPmfM p9+crUVwlZsilwstkFxG332R6/BsLJN7aHvHZq2+p5dV7ghe94dvONHOXvVOBKe+Fy nhuDYId/UDhtJrywcxQ+9n1ckEpknb0cOT5NFFHO99Lno+cRrW0qKx0EOmGbyKWrfC Wd92jaMcOlkS9juTlhltYYzQccPAOMgeOsB2Qu2xIyP7cV0cTawoSmIPBpnw42pH7M s7aLsxn2nohXw== Date: Tue, 25 Jun 2024 17:54:34 -0700 From: Jakub Kicinski To: Breno Leitao Cc: Sunil Goutham , "David S. Miller" , Eric Dumazet , Paolo Abeni , horms@kernel.org, linux-arm-kernel@lists.infradead.org (moderated list:ARM/CAVIUM THUNDER NETWORK DRIVER), netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH net-next] net: thunderx: Unembed netdev structure Message-ID: <20240625175434.53ccea3a@kernel.org> In-Reply-To: <20240624102919.4016797-1-leitao@debian.org> References: <20240624102919.4016797-1-leitao@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240625_175440_071401_E85038A3 X-CRM114-Status: UNSURE ( 7.05 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 24 Jun 2024 03:29:18 -0700 Breno Leitao wrote: > static void bgx_lmac_handler(struct net_device *netdev) > { > - struct lmac *lmac = container_of(netdev, struct lmac, netdev); > + struct lmac *lmac = netdev_priv(netdev); I think you are storing a pointer to lmac, so: struct lmac **priv = netdev_priv(netdev); struct lmac *lmac = *priv; -- pw-bot: cr